Fix update-via-pacman.ps1
#88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The post-install script of `git-extra` (which we source manually) assumes that the native `git.exe` is in the `PATH`. Let's make it so. Signed-off-by: Johannes Schindelin <[email protected]>
The post-install script is supposed to be run in the root directory of the SDK. Let's do that, then. Signed-off-by: Johannes Schindelin <[email protected]>
bash-completion (2.15.0-1 -> 2.16.0-1) filesystem (2023.02.07-3 -> 2024.12.18-1) libguile (3.0.10-1 -> 3.0.10-2) mingw-w64-i686-crt-git (12.0.0.r446.ga2d19218d-1 -> 12.0.0.r459.g63f3f2846-1) mingw-w64-i686-headers-git (12.0.0.r446.ga2d19218d-2 -> 12.0.0.r459.g63f3f2846-1) mingw-w64-i686-libmangle-git (12.0.0.r446.ga2d19218d-1 -> 12.0.0.r459.g63f3f2846-1) mingw-w64-i686-libwinpthread-git (12.0.0.r446.ga2d19218d-1 -> 12.0.0.r459.g63f3f2846-1) mingw-w64-i686-tools-git (12.0.0.r446.ga2d19218d-1 -> 12.0.0.r459.g63f3f2846-1) mingw-w64-i686-winpthreads-git (12.0.0.r446.ga2d19218d-1 -> 12.0.0.r459.g63f3f2846-1) mingw-w64-x86_64-crt-git (12.0.0.r446.ga2d19218d-1 -> 12.0.0.r459.g63f3f2846-1) mingw-w64-x86_64-headers-git (12.0.0.r446.ga2d19218d-2 -> 12.0.0.r459.g63f3f2846-1) mingw-w64-x86_64-libmangle-git (12.0.0.r446.ga2d19218d-1 -> 12.0.0.r459.g63f3f2846-1) mingw-w64-x86_64-libwinpthread-git (12.0.0.r446.ga2d19218d-1 -> 12.0.0.r459.g63f3f2846-1) mingw-w64-x86_64-tools-git (12.0.0.r446.ga2d19218d-1 -> 12.0.0.r459.g63f3f2846-1) mingw-w64-x86_64-winpthreads-git (12.0.0.r446.ga2d19218d-1 -> 12.0.0.r459.g63f3f2846-1) msys2-launcher (1.5-2 -> 1.5-3) pacman (6.1.0-9 -> 6.1.0-10) pacman-mirrors (20240523-1 -> 20241217-1) Signed-off-by: Git for Windows Build Agent <[email protected]>
|
This PR will need to be ported to git-sdk-32 and git-sdk-arm64, too. |
|
The ci-artifacts tests are unfortunately currently expected to time out :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
syncworkflow runs are broken ever sincepacmanwanted to be upgraded.The reason is that
pacmancomes with a newpacman.conf, and we have to re-patch that file to add Git for Windows' Pacman repositories, but that re-patching is done viamingw-w64-git-extra'spost-installscript, which is currently called byupdate-via-pacman.ps1in a way that does not work.This PR addresses this: It ensures that
/mingw64/bin/git.exeis in thePATH, and that thepost-installscript is run in the root directory of the SDK as it expects to be run.