Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop preventing pacman from being updated #28

Closed
dscho opened this issue Dec 30, 2024 · 1 comment
Closed

Stop preventing pacman from being updated #28

dscho opened this issue Dec 30, 2024 · 1 comment

Comments

@dscho
Copy link
Member

dscho commented Dec 30, 2024

There is a left-over IgnorePkg = pacman line in /etc/pacman.conf; I noticed this while investigating why the symptom (a failing sync workflow) did that gave rise to git-for-windows#88 was not seen in git-sdk-arm64, and that left-over line explains it.

@dscho
Copy link
Member Author

dscho commented Jan 2, 2025

Hah, looks like I accidentally removed pacman from the IgnorePkg line and therefore pacman was updated. The mistake was here:

-          sed -i 's/^#\? *\(IgnorePkg *=\).*/\1 msys2-runtime/' etc/pacman.conf &&
+          sed -i 's/^\(# *\(IgnorePkg *=\).*\| *\(IgnorePkg =.*\)\)/\2\3 msys2-runtime/' etc/pacman.conf &&

i.e. if a commented-out IgnorePkg line was found, it should have been replaced by an un-commented line that only adds msys2-runtime, but if an already uncommented IgnorePkg line was found, it should have appended msys2-runtime.

Oh well, at least this ticket is addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant