Update the dotnet-install script URL in Fake.DotNet.getGenericDotNetC… #2853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…liInstallerUrl The scripts have been updated due to dotnet/core#9671, but according to https://github.com/dotnet/sdk/blob/main/scripts/obtain/dotnet-install-readme the source for the scripts was changed from https://github.com/dotnet/sdk to https://github.com/dotnet/install-scripts some years ago
Numpsy
commented
Jan 12, 2025
| @@ -136,7 +136,7 @@ module DotNet = | |||
| /// Get .NET Core SDK download uri | |||
| /// </summary> | |||
| let private getGenericDotNetCliInstallerUrl branch installerName = | |||
| sprintf "https://raw.githubusercontent.com/dotnet/cli/%s/scripts/obtain/%s" branch installerName | |||
| sprintf "https://raw.githubusercontent.com/dotnet/install-scripts/%s/src/%s" branch installerName | |||
There was a problem hiding this comment.
I'm not really certain if this should be pulling the scripts from github or the 'distribution' urls such as https://dot.net/v1/dotnet-install.sh - but thats a bigger change which would mean dropping the configurable branch, so I just tried to keep it minimal for now
There was a problem hiding this comment.
We will be sharing guidance shortly.
This issue should provide some insight: dotnet/install-scripts#558 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…liInstallerUrl
refs #2848
Description
The scripts have been updated due to dotnet/core#9671, but according to https://github.com/dotnet/sdk/blob/main/scripts/obtain/dotnet-install-readme the source for the scripts was changed from https://github.com/dotnet/sdk to https://github.com/dotnet/install-scripts some years ago, so it looks like FAKE was already using an old version of the scripts?