Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep an eye on https://github.com/dotnet/core/issues/9671 #2848

Closed
Numpsy opened this issue Dec 27, 2024 · 3 comments · Fixed by #2849
Closed

Keep an eye on https://github.com/dotnet/core/issues/9671 #2848

Numpsy opened this issue Dec 27, 2024 · 3 comments · Fixed by #2849

Comments

@Numpsy
Copy link
Contributor

Numpsy commented Dec 27, 2024

Description

I'm not sure how much of an issue this is, but for the record -

Microsoft announced at dotnet/core#9671 that some .NET resources are moving to new domains due to a CDN they use falling over.

As it stands, Fake.Runtime uses Microsoft.Deployment.DotNet.Releases to download information about .NET product releases - ref

let! productCollection = ProductCollection.GetAsync()

Looking at Microsoft.Deployment.DotNet.Releases I see dotnet/deployment-tools#419 was made to change the default domain used to download the product release list.

So - I wonder whether Fake.Runtime will need to be changed to either use the new URL, or be updated to a new Microsoft.Deployment.DotNet.Releases if one should be released

@richlander
Copy link
Contributor

PR: #2849

This line will fail some time in 2025. It will need to change to the new CDN.

let downloadPath = sprintf "https://dotnetcli.azureedge.net/dotnet/Sdk/%s/%s" sdkVersion archiveFileName

@Numpsy
Copy link
Contributor Author

Numpsy commented Jan 9, 2025

I think there might still be an issue here - the code at

sprintf "https://raw.githubusercontent.com/dotnet/cli/%s/scripts/obtain/%s" branch installerName
to download the dotnet-install scripts is looking at https://raw.githubusercontent.com/dotnet/cli and from the linked issue I think it should be using https://dot.net/v1/dotnet-install.sh instead?

Observed when looking at the build results from the latest CI build
https://github.com/fsprojects/FAKE/actions/runs/12687609590/job/35362392820#step:8:1294
https://github.com/fsprojects/FAKE/actions/runs/12687609590/job/35362392820#step:8:8893

where it got an error whilst trying to download the installer from the old azureedge URL

@Numpsy
Copy link
Contributor Author

Numpsy commented Jan 12, 2025

#2853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants