migrate flag experimental-compaction-batch-limit to use compaction-batch-limit #19196
Conversation
|
Hi @gangli113. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Gang Li <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 27 files with indirect coverage changes @@ Coverage Diff @@
## main #19196 +/- ##
==========================================
- Coverage 68.83% 68.80% -0.03%
==========================================
Files 420 420
Lines 35627 35632 +5
==========================================
- Hits 24523 24517 -6
- Misses 9683 9692 +9
- Partials 1421 1423 +2 Continue to review full report in Codecov by Sentry.
|
|
/ok-to-test |
|
/cc @serathius @ahrtr |
Signed-off-by: Gang Li <[email protected]>
| cfgFromCmdLine, errFromCmdLine, cfgFromFile, errFromFile := generateCfgsFromFileAndCmdLine(t, yc, cmdLineArgs) | ||
|
|
||
| if tc.expectErr { | ||
| if errFromCmdLine == nil || errFromFile == nil { |
There was a problem hiding this comment.
| if errFromCmdLine == nil || errFromFile == nil { | |
| if errFromCmdLine == nil && errFromFile == nil { |
There was a problem hiding this comment.
Hi @ahrtr, it should be better to keep ||. Because we want both errFromCmdLine and errFromFile to have values. If one err is nil, something is wrong and test case should catch it.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, gangli113, siyuanfoundation The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes one flag described in: #19141
The experimental flags are marked as deprecated and will be decommissioned in v3.7.