Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate non-boolean experimental flags in 3.6 #19141

Open
1 of 11 tasks
siyuanfoundation opened this issue Jan 7, 2025 · 4 comments · Fixed by #19156
Open
1 of 11 tasks

Migrate non-boolean experimental flags in 3.6 #19141

siyuanfoundation opened this issue Jan 7, 2025 · 4 comments · Fixed by #19156
Assignees

Comments

@siyuanfoundation
Copy link
Contributor

siyuanfoundation commented Jan 7, 2025

What would you like to be added?

For the 3.6 release, we would like to have the list of non-boolean --experimental flags migrated to flags without the --experimental prefix.

In 3.6, we would like to have both the flags with and without the --experimental prefix working. experimentalNonBoolFlagMigrationMap should be used to achieve that. #19156 is an example.

Why is this needed?

flag clean up for release 3.6

@siyuanfoundation
Copy link
Contributor Author

@ahrtr @serathius Please double check the flag list and see if any flag needs to remain --experimental or missing any.

@siyuanfoundation
Copy link
Contributor Author

/cc @gangli113

@gangli113
Copy link
Contributor

/assign

@siyuanfoundation
Copy link
Contributor Author

/reopen
because there are still other flags to migrate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants