-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add coinmarketcap plugin #1773
Merged
wtfsayo
merged 13 commits into
elizaOS:develop
from
Lukapetro:feature/add-coinmarketcap-plugin
Jan 8, 2025
Merged
Feature/add coinmarketcap plugin #1773
wtfsayo
merged 13 commits into
elizaOS:develop
from
Lukapetro:feature/add-coinmarketcap-plugin
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@odilitime @wtfsayo conflicts resolved, feel free to take a look and merge |
wtfsayo
approved these changes
Jan 8, 2025
@shakkernerd can't merge myself; lgtm |
Why have we merged that code with broken workflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoinMarketCap Plugin for Eliza
Risks
Low - This is an additive change that introduces a new plugin without modifying existing functionality. The main risks are:
Background
What does this PR do?
GET_PRICE
action that fetches current prices using the v1 APIWhat kind of change is this?
Features (non-breaking change which adds functionality):
Documentation changes needed?
My changes require a change to the project documentation:
Testing
Where should a reviewer start?
/plugin-coinmarketcap/src/
index.ts
service.ts
types.ts
template.ts
Detailed testing steps
Set up environment:
Run agent locally and test natural language queries:
Verify error handling:
Future Expansion
1. Extended CoinMarketCap Integration
2. Additional API Features
/cryptocurrency/map
- Add support for symbol/id mapping/cryptocurrency/info
- Include detailed crypto metadata/cryptocurrency/listings/latest
- Add market data sorting and filtering/cryptocurrency/categories
- Support category-based queries/global-metrics/quotes/latest
- Add global market metrics3. Enhanced Features
Discord username
0xspit