feat: add coin price plugin #1808
Open
+1,037
−711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to
#1773 & #1382
Risks
Low risk, minimal changes and a very simple plugin
Background
This does kind of replace both #1773 & #1382. I included 1773's commits but 1382 was too different and too many commits to include. This plugin adds 3 new price data APIs. It first looks for Coingecko API key, then CoinMarketCap & and if neither are present it falls back to CoinCap.io's free API.
What does this PR do?
Adds price retrieval via the GET_PRICE action.
What kind of change is this?
Features (non-breaking change which adds functionality)
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
Where should a reviewer start?
Review plugin files (they are short and simple)
Detailed testing steps
Add an API key if you have one (check .env.example), if not it will default to CoinCap.io API (which does have less coins but works well). CoinGecko API is recommended, CoinMarketCap also an option. All confirmed to be working.
Discord username
proteanx