[8.x] [Infra] Fix failing test by changing read role permission (#205707) #205747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5707) Closes elastic#203740 ## Summary This PR fixes failing test by changing read role permission to include `streams` and `apm`. As I mentioned in this [comment](elastic#203740 (comment)) I saw some 403 errors related to some `streams` and `apm` APIs requests so this should fix the test as it was meant to test if the dashboards tab behaves correctly based on the admin/read-only role. However, we should think about a solution to those errors in case we have this scenario (read-only user role without apm/streams access) and have a better error message/explanation of what is missing instead of only showing the error toasts - I saw that we reverted (elastic#202418) already a solution (elastic#200151) for APM because of other issues but now that we also include the `streams` (elastic#200060) (not sure if we need to do the request in infra but that's probably a different discussion) it's something we can revisit at one point to improve the user experience. (cherry picked from commit 6fc90d0)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation