Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[8.x] [Infra] Fix failing test by changing read role permission (#205707
) (#205747) # Backport This will backport the following commits from `main` to `8.x`: - [[Infra] Fix failing test by changing read role permission (#205707)](#205707) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-07T14:10:04Z","message":"[Infra] Fix failing test by changing read role permission (#205707)\n\nCloses #203740\r\n## Summary\r\n\r\nThis PR fixes failing test by changing read role permission to include\r\n`streams` and `apm`. As I mentioned in this\r\n[comment](https://github.com/elastic/kibana/issues/203740#issuecomment-2574907832)\r\nI saw some 403 errors related to some `streams` and `apm` APIs requests\r\nso this should fix the test as it was meant to test if the dashboards\r\ntab behaves correctly based on the admin/read-only role.\r\n\r\nHowever, we should think about a solution to those errors in case we\r\nhave this scenario (read-only user role without apm/streams access) and\r\nhave a better error message/explanation of what is missing instead of\r\nonly showing the error toasts - I saw that we reverted\r\n(#202418) already a solution\r\n(#200151) for APM because of\r\nother issues but now that we also include the `streams`\r\n(#200060) (not sure if we need to\r\ndo the request in infra but that's probably a different discussion) it's\r\nsomething we can revisit at one point to improve the user experience.","sha":"6fc90d0410445cdb79419d0f6132a442d595a4e7","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-infra_services"],"title":"[Infra] Fix failing test by changing read role permission ","number":205707,"url":"https://github.com/elastic/kibana/pull/205707","mergeCommit":{"message":"[Infra] Fix failing test by changing read role permission (#205707)\n\nCloses #203740\r\n## Summary\r\n\r\nThis PR fixes failing test by changing read role permission to include\r\n`streams` and `apm`. As I mentioned in this\r\n[comment](https://github.com/elastic/kibana/issues/203740#issuecomment-2574907832)\r\nI saw some 403 errors related to some `streams` and `apm` APIs requests\r\nso this should fix the test as it was meant to test if the dashboards\r\ntab behaves correctly based on the admin/read-only role.\r\n\r\nHowever, we should think about a solution to those errors in case we\r\nhave this scenario (read-only user role without apm/streams access) and\r\nhave a better error message/explanation of what is missing instead of\r\nonly showing the error toasts - I saw that we reverted\r\n(#202418) already a solution\r\n(#200151) for APM because of\r\nother issues but now that we also include the `streams`\r\n(#200060) (not sure if we need to\r\ndo the request in infra but that's probably a different discussion) it's\r\nsomething we can revisit at one point to improve the user experience.","sha":"6fc90d0410445cdb79419d0f6132a442d595a4e7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205707","number":205707,"mergeCommit":{"message":"[Infra] Fix failing test by changing read role permission (#205707)\n\nCloses #203740\r\n## Summary\r\n\r\nThis PR fixes failing test by changing read role permission to include\r\n`streams` and `apm`. As I mentioned in this\r\n[comment](https://github.com/elastic/kibana/issues/203740#issuecomment-2574907832)\r\nI saw some 403 errors related to some `streams` and `apm` APIs requests\r\nso this should fix the test as it was meant to test if the dashboards\r\ntab behaves correctly based on the admin/read-only role.\r\n\r\nHowever, we should think about a solution to those errors in case we\r\nhave this scenario (read-only user role without apm/streams access) and\r\nhave a better error message/explanation of what is missing instead of\r\nonly showing the error toasts - I saw that we reverted\r\n(#202418) already a solution\r\n(#200151) for APM because of\r\nother issues but now that we also include the `streams`\r\n(#200060) (not sure if we need to\r\ndo the request in infra but that's probably a different discussion) it's\r\nsomething we can revisit at one point to improve the user experience.","sha":"6fc90d0410445cdb79419d0f6132a442d595a4e7"}}]}] BACKPORT--> Co-authored-by: jennypavlova <[email protected]>
- Loading branch information