Make saved_objects_tagging plugin shared

.github/CODEOWNERS

@@ -854,7 +854,6 @@ x-pack/platform/plugins/private/remote_clusters @elastic/kibana-management
 x-pack/platform/plugins/private/reporting @elastic/appex-sharedux
 x-pack/platform/plugins/private/rollup @elastic/kibana-management
 x-pack/platform/plugins/private/runtime_fields @elastic/kibana-management
-x-pack/platform/plugins/private/saved_objects_tagging @elastic/appex-sharedux
 x-pack/platform/plugins/private/snapshot_restore @elastic/kibana-management
 x-pack/platform/plugins/private/telemetry_collection_xpack @elastic/kibana-core
 x-pack/platform/plugins/private/transform @elastic/ml-ui
@@ -894,6 +893,7 @@ x-pack/platform/plugins/shared/notifications @elastic/appex-sharedux
 x-pack/platform/plugins/shared/observability_solution/observability_ai_assistant @elastic/obs-ai-assistant
 x-pack/platform/plugins/shared/osquery @elastic/security-defend-workflows
 x-pack/platform/plugins/shared/rule_registry @elastic/response-ops @elastic/obs-ux-management-team
+x-pack/platform/plugins/shared/saved_objects_tagging @elastic/appex-sharedux
 x-pack/platform/plugins/shared/screenshotting @elastic/kibana-reporting-services
 x-pack/platform/plugins/shared/searchprofiler @elastic/kibana-management
 x-pack/platform/plugins/shared/security @elastic/kibana-security
@@ -3228,7 +3228,7 @@ x-pack/platform/plugins/private/remote_clusters @elastic/kibana-management
 x-pack/platform/plugins/private/reporting @elastic/appex-sharedux
 x-pack/platform/plugins/private/rollup @elastic/kibana-management
 x-pack/platform/plugins/private/runtime_fields @elastic/kibana-management
-x-pack/platform/plugins/private/saved_objects_tagging @elastic/appex-sharedux
+x-pack/platform/plugins/shared/saved_objects_tagging @elastic/appex-sharedux
 x-pack/platform/plugins/private/snapshot_restore @elastic/kibana-management
 x-pack/platform/plugins/private/telemetry_collection_xpack @elastic/kibana-core
 x-pack/platform/plugins/private/transform @elastic/ml-ui

docs/developer/plugin-list.asciidoc

@@ -808,7 +808,7 @@ Elastic.
 |Welcome to the home of the runtime field editor and everything related to runtime fields!
 
 
-|{kib-repo}blob/{branch}/x-pack/platform/plugins/private/saved_objects_tagging/README.md[savedObjectsTagging]
+|{kib-repo}blob/{branch}/x-pack/platform/plugins/shared/saved_objects_tagging/README.md[savedObjectsTagging]
 |Add tagging capability to saved objects
 
 

package.json

@@ -790,7 +790,7 @@
     "@kbn/saved-objects-plugin": "link:src/platform/plugins/shared/saved_objects",
     "@kbn/saved-objects-settings": "link:packages/kbn-saved-objects-settings",
     "@kbn/saved-objects-tagging-oss-plugin": "link:src/platform/plugins/shared/saved_objects_tagging_oss",
-    "@kbn/saved-objects-tagging-plugin": "link:x-pack/platform/plugins/private/saved_objects_tagging",
+    "@kbn/saved-objects-tagging-plugin": "link:x-pack/platform/plugins/shared/saved_objects_tagging",
     "@kbn/saved-search-component": "link:packages/kbn-saved-search-component",
     "@kbn/saved-search-plugin": "link:src/platform/plugins/shared/saved_search",
     "@kbn/screenshot-mode-example-plugin": "link:examples/screenshot_mode_example",

packages/kbn-relocate/utils/relocate.ts

@@ -92,12 +92,14 @@ export const calculateModuleTargetFolder = (module: Package): string => {
 };
 
 export const isInTargetFolder = (module: Package, log: ToolingLog): boolean => {
-  if (!module.group || module.group === 'common' || !module.visibility) {
+  const { group, visibility } = module.manifest;
+
+  if (!group || group === 'common' || !visibility) {
     log.warning(`The module '${module.id}' is missing the group/visibility information`);
     return false;
   }
 
-  const baseTargetFolders = TARGET_FOLDERS[`${module.group}:${module.visibility}`];
+  const baseTargetFolders = TARGET_FOLDERS[`${group}:${visibility}`];
   const baseTargetFolder = baseTargetFolders.find((candidate) => {
     return module.directory.includes(candidate);
   });

tsconfig.base.json

@@ -1550,8 +1550,8 @@
       "@kbn/saved-objects-settings/*": ["packages/kbn-saved-objects-settings/*"],
       "@kbn/saved-objects-tagging-oss-plugin": ["src/platform/plugins/shared/saved_objects_tagging_oss"],
       "@kbn/saved-objects-tagging-oss-plugin/*": ["src/platform/plugins/shared/saved_objects_tagging_oss/*"],
-      "@kbn/saved-objects-tagging-plugin": ["x-pack/platform/plugins/private/saved_objects_tagging"],
-      "@kbn/saved-objects-tagging-plugin/*": ["x-pack/platform/plugins/private/saved_objects_tagging/*"],
+      "@kbn/saved-objects-tagging-plugin": ["x-pack/platform/plugins/shared/saved_objects_tagging"],
+      "@kbn/saved-objects-tagging-plugin/*": ["x-pack/platform/plugins/shared/saved_objects_tagging/*"],
       "@kbn/saved-search-component": ["packages/kbn-saved-search-component"],
       "@kbn/saved-search-component/*": ["packages/kbn-saved-search-component/*"],
       "@kbn/saved-search-plugin": ["src/platform/plugins/shared/saved_search"],

x-pack/.i18nrc.json

@@ -159,7 +159,7 @@
     "xpack.snapshotRestore": "platform/plugins/private/snapshot_restore",
     "xpack.spaces": "platform/plugins/shared/spaces",
     "xpack.savedObjectsTagging": [
-      "platform/plugins/private/saved_objects_tagging"
+      "platform/plugins/shared/saved_objects_tagging"
     ],
     "xpack.taskManager": "legacy/platform/plugins/shared/task_manager",
     "xpack.threatIntelligence": "solutions/security/plugins/threat_intelligence",

x-pack/platform/plugins/private/saved_objects_tagging/README.md → x-pack/platform/plugins/shared/saved_objects_tagging/README.md

@@ -38,7 +38,7 @@ features.registerKibanaFeature({
 
 ### Update the SOT telemetry collector schema to add the new type
 
-The schema is located here: `x-pack/platform/plugins/private/saved_objects_tagging/server/usage/schema.ts`. You
+The schema is located here: `x-pack/platform/plugins/shared/saved_objects_tagging/server/usage/schema.ts`. You
 just need to add the name of the SO type you are adding.
 
 ```ts
@@ -54,5 +54,5 @@ export const tagUsageCollectorSchema: MakeSchemaFrom<TaggingUsageData> = {
 
 ### Update the `taggableTypes` constant to add your type
 
-Edit the `taggableTypes` list in `x-pack/platform/plugins/private/saved_objects_tagging/common/constants.ts` to add
+Edit the `taggableTypes` list in `x-pack/platform/plugins/shared/saved_objects_tagging/common/constants.ts` to add
 the name of the type you are adding.

x-pack/platform/plugins/private/saved_objects_tagging/jest.config.js → x-pack/platform/plugins/shared/saved_objects_tagging/jest.config.js

@@ -8,11 +8,11 @@
 module.exports = {
   preset: '@kbn/test',
   rootDir: '../../../../..',
-  roots: ['<rootDir>/x-pack/platform/plugins/private/saved_objects_tagging'],
+  roots: ['<rootDir>/x-pack/platform/plugins/shared/saved_objects_tagging'],
   coverageDirectory:
-    '<rootDir>/target/kibana-coverage/jest/x-pack/platform/plugins/private/saved_objects_tagging',
+    '<rootDir>/target/kibana-coverage/jest/x-pack/platform/plugins/shared/saved_objects_tagging',
   coverageReporters: ['text', 'html'],
   collectCoverageFrom: [
-    '<rootDir>/x-pack/platform/plugins/private/saved_objects_tagging/{common,public,server}/**/*.{ts,tsx}',
+    '<rootDir>/x-pack/platform/plugins/shared/saved_objects_tagging/{common,public,server}/**/*.{ts,tsx}',
   ],
 };

x-pack/platform/plugins/private/saved_objects_tagging/kibana.jsonc → x-pack/platform/plugins/shared/saved_objects_tagging/kibana.jsonc

@@ -5,7 +5,7 @@
     "@elastic/appex-sharedux"
   ],
   "group": "platform",
-  "visibility": "private",
+  "visibility": "shared",
   "plugin": {
     "id": "savedObjectsTagging",
     "browser": true,
@@ -25,4 +25,4 @@
     ],
     "requiredBundles": []
   }
-}
+}

yarn.lock

@@ -6953,7 +6953,7 @@
   version "0.0.0"
   uid ""
 
-"@kbn/saved-objects-tagging-plugin@link:x-pack/platform/plugins/private/saved_objects_tagging":
+"@kbn/saved-objects-tagging-plugin@link:x-pack/platform/plugins/shared/saved_objects_tagging":
   version "0.0.0"
   uid ""