Make saved_objects_tagging plugin shared
#205695
Merged
+19
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
gsoldevila
commented
Jan 7, 2025
| if (!module.group || module.group === 'common' || !module.visibility) { | ||
| const { group, visibility } = module.manifest; | ||
|
|
||
| if (!group || group === 'common' || !visibility) { |
There was a problem hiding this comment.
Fix a bug in the script: use group and visibility from the manifest, rather than those inferred from path.
gsoldevila
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
|
dokmic
approved these changes
Jan 7, 2025
ryankeairns
approved these changes
Jan 7, 2025
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kowalczyk-krzysztof
pushed a commit
to kowalczyk-krzysztof/kibana
that referenced
this pull request
Jan 7, 2025
## Summary So that it can be used from `streams_app` (o11y). See elastic#204309 Steps to relocate: 1. Fetch latest `main` 2. Update the `group` and/or `visibility` in the module's manifest. 3. Run `node scripts/relocate --moveOnly @kbn/saved-objects-tagging-plugin`
gsoldevila
added a commit
to gsoldevila/kibana
that referenced
this pull request
Jan 8, 2025
## Summary So that it can be used from `streams_app` (o11y). See elastic#204309 Steps to relocate: 1. Fetch latest `main` 2. Update the `group` and/or `visibility` in the module's manifest. 3. Run `node scripts/relocate --moveOnly @kbn/saved-objects-tagging-plugin` (cherry picked from commit a8579bb) # Conflicts: # .github/CODEOWNERS # packages/kbn-relocate/utils/relocate.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
So that it can be used from
streams_app(o11y).See #204309
Steps to relocate:
maingroupand/orvisibilityin the module's manifest.node scripts/relocate --moveOnly @kbn/saved-objects-tagging-plugin