Sustainable Kibana Architecture: Fix after-relocation issues #205613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dokmic
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
dokmic
force-pushed
the
bugfix/after-relocation-bugs
branch
from
935ca65 to
28e0f7c
Compare
jbudz
approved these changes
Jan 6, 2025
Bamieh
approved these changes
Jan 6, 2025
💚 Build Succeeded
Metrics [docs]
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 6, 2025
…#205613) After merging elastic#202748, elastic#204959, and elastic#201653, all of the properties in some telemetry schemas were moved completely, but `node scripts/telemetry_check --fix` didn't update the `properties` object correctly. Also, in elastic#202748 and elastic#201653, the relocation script changed some paths, confusing them with `@kbn/security-plugin` and `@kbn/cloud-plugin`. (cherry picked from commit 5409631)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 6, 2025
…205613) (#205641) # Backport This will backport the following commits from `main` to `8.x`: - [Sustainable Kibana Architecture: Fix after-relocation issues (#205613)](#205613) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Michael Dokolin","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-06T18:02:36Z","message":"Sustainable Kibana Architecture: Fix after-relocation issues (#205613)\n\nAfter merging #202748, #204959, and #201653, all of the properties in\nsome telemetry schemas were moved completely, but `node\nscripts/telemetry_check --fix` didn't update the `properties` object\ncorrectly.\n\nAlso, in #202748 and #201653, the relocation script changed some paths,\nconfusing them with `@kbn/security-plugin` and `@kbn/cloud-plugin`.","sha":"540963148dc671b02655ced8285dbbd817d9d5c9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:version","v8.18.0","plugin groups"],"title":"Sustainable Kibana Architecture: Fix after-relocation issues","number":205613,"url":"https://github.com/elastic/kibana/pull/205613","mergeCommit":{"message":"Sustainable Kibana Architecture: Fix after-relocation issues (#205613)\n\nAfter merging #202748, #204959, and #201653, all of the properties in\nsome telemetry schemas were moved completely, but `node\nscripts/telemetry_check --fix` didn't update the `properties` object\ncorrectly.\n\nAlso, in #202748 and #201653, the relocation script changed some paths,\nconfusing them with `@kbn/security-plugin` and `@kbn/cloud-plugin`.","sha":"540963148dc671b02655ced8285dbbd817d9d5c9"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205613","number":205613,"mergeCommit":{"message":"Sustainable Kibana Architecture: Fix after-relocation issues (#205613)\n\nAfter merging #202748, #204959, and #201653, all of the properties in\nsome telemetry schemas were moved completely, but `node\nscripts/telemetry_check --fix` didn't update the `properties` object\ncorrectly.\n\nAlso, in #202748 and #201653, the relocation script changed some paths,\nconfusing them with `@kbn/security-plugin` and `@kbn/cloud-plugin`.","sha":"540963148dc671b02655ced8285dbbd817d9d5c9"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Michael Dokolin <[email protected]>
dokmic
added a commit
that referenced
this pull request
Jan 7, 2025
Follow-up of #205613. Remove check blocking empty properties from writing.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 7, 2025
Follow-up of elastic#205613. Remove check blocking empty properties from writing. (cherry picked from commit aa8195c)
kibanamachine
added a commit
that referenced
this pull request
Jan 7, 2025
#205786) # Backport This will backport the following commits from `main` to `8.x`: - [Fix telemetry CLI to write empty properties collection (#205746)](#205746) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Michael Dokolin","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-07T16:46:43Z","message":"Fix telemetry CLI to write empty properties collection (#205746)\n\nFollow-up of #205613. Remove check blocking empty properties from\nwriting.","sha":"aa8195ced450bf97145fa27cadd3e6b8c922487f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:version","v8.18.0"],"title":"Fix telemetry CLI to write empty properties collection","number":205746,"url":"https://github.com/elastic/kibana/pull/205746","mergeCommit":{"message":"Fix telemetry CLI to write empty properties collection (#205746)\n\nFollow-up of #205613. Remove check blocking empty properties from\nwriting.","sha":"aa8195ced450bf97145fa27cadd3e6b8c922487f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205746","number":205746,"mergeCommit":{"message":"Fix telemetry CLI to write empty properties collection (#205746)\n\nFollow-up of #205613. Remove check blocking empty properties from\nwriting.","sha":"aa8195ced450bf97145fa27cadd3e6b8c922487f"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Michael Dokolin <[email protected]>
kowalczyk-krzysztof
pushed a commit
to kowalczyk-krzysztof/kibana
that referenced
this pull request
Jan 7, 2025
…#205613) After merging elastic#202748, elastic#204959, and elastic#201653, all of the properties in some telemetry schemas were moved completely, but `node scripts/telemetry_check --fix` didn't update the `properties` object correctly. Also, in elastic#202748 and elastic#201653, the relocation script changed some paths, confusing them with `@kbn/security-plugin` and `@kbn/cloud-plugin`.
kowalczyk-krzysztof
pushed a commit
to kowalczyk-krzysztof/kibana
that referenced
this pull request
Jan 7, 2025
Follow-up of elastic#205613. Remove check blocking empty properties from writing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After merging #202748, #204959, and #201653, all of the properties in some telemetry schemas were moved completely, but
node scripts/telemetry_check --fixdidn't update thepropertiesobject correctly.Also, in #202748 and #201653, the relocation script changed some paths, confusing them with
@kbn/security-pluginand@kbn/cloud-plugin.