Sustainable Kibana Architecture: Move content management related packages #205593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosant
changed the title
Dosant
added
release_note:skip
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
Dosant
commented
Jan 6, 2025
| @@ -9927,6 +9927,38 @@ | |||
| } | |||
| } | |||
| }, | |||
| "favorites": { | |||
There was a problem hiding this comment.
@elastic/kibana-core If this is added here, then should this be also deleted from somewhere? 🤔
There was a problem hiding this comment.
There is a bug in the telemetry_check script that didn't let it update completely removed properties.
I opened #205613 to resolve this. Please wait until it is merged and then merge upstream into this PR. Otherwise, there is a chance of getting a broken main.
There was a problem hiding this comment.
Awesome, thanks! will wait for that PR
There was a problem hiding this comment.
@dokmic, looks like nothing has changed after the merge. Should I remove it manually?
8 tasks
eokoneyo
approved these changes
Jan 6, 2025
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
dokmic
approved these changes
Jan 7, 2025
💚 Build Succeeded
Metrics [docs]
History
|
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kowalczyk-krzysztof
pushed a commit
to kowalczyk-krzysztof/kibana
that referenced
this pull request
Jan 7, 2025
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Jan 8, 2025
…ages (elastic#205593) (cherry picked from commit 72d3f7b) # Conflicts: # .github/CODEOWNERS
Dosant
added a commit
that referenced
this pull request
Jan 8, 2025
…d packages (#205593) (#205855) # Backport This will backport the following commits from `main` to `8.x`: - [Sustainable Kibana Architecture: Move content management related packages (#205593)](#205593) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-07T21:41:31Z","message":"Sustainable Kibana Architecture: Move content management related packages (#205593)","sha":"72d3f7b89c46231e70e8c992df133f653d9154a1","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","plugin groups"],"number":205593,"url":"https://github.com/elastic/kibana/pull/205593","mergeCommit":{"message":"Sustainable Kibana Architecture: Move content management related packages (#205593)","sha":"72d3f7b89c46231e70e8c992df133f653d9154a1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205593","number":205593,"mergeCommit":{"message":"Sustainable Kibana Architecture: Move content management related packages (#205593)","sha":"72d3f7b89c46231e70e8c992df133f653d9154a1"}}]}] BACKPORT-->
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.
Important
packages[\/\\]andplugins[\/\\]patterns in the source code (Babel and Eslint config files), and update them appropriately..buildkite/scripts/pipelines/pull_request/pipeline.tsto ensure that any CI pipeline customizations continue to be correctly applied after the changed path names.tsand.jsfiles listed in the sections below, as some of them contain relative paths that have been updated.Note
Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe here.
15 packages(s) are going to be relocated:
@kbn/content-management-content-editorsrc/platform/packages/shared/content-management/content_editor@kbn/content-management-content-insights-publicsrc/platform/packages/shared/content-management/content_insights/content_insights_public@kbn/content-management-content-insights-serversrc/platform/packages/shared/content-management/content_insights/content_insights_server@kbn/content-management-favorites-commonsrc/platform/packages/shared/content-management/favorites/favorites_common@kbn/content-management-favorites-publicsrc/platform/packages/shared/content-management/favorites/favorites_public@kbn/content-management-favorites-serversrc/platform/packages/shared/content-management/favorites/favorites_server@kbn/content-management-tabbed-table-list-viewsrc/platform/packages/shared/content-management/tabbed_table_list_view@kbn/content-management-table-list-viewsrc/platform/packages/shared/content-management/table_list_view@kbn/content-management-table-list-view-commonsrc/platform/packages/shared/content-management/table_list_view_common@kbn/content-management-table-list-view-tablesrc/platform/packages/shared/content-management/table_list_view_table@kbn/content-management-user-profilessrc/platform/packages/shared/content-management/user_profiles@kbn/object-versioningsrc/platform/packages/shared/kbn-object-versioning@kbn/object-versioning-utilssrc/platform/packages/shared/kbn-object-versioning-utils@kbn/recently-accessedsrc/platform/packages/shared/kbn-recently-accessed@kbn/ui-actions-browsersrc/platform/packages/shared/kbn-ui-actions-browserUpdated relative paths