Sustainable Kibana Architecture: Move packages under packages/shared-ux/
#205602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sant/kibana into kbn-team-1309-relocate-20250106110819
8 tasks
eokoneyo
reviewed
Jan 6, 2025
There was a problem hiding this comment.
Reviewing the migration for shared-ux packages, I found that for certain packages there were still some hanging references to what will be come the former location of these packages when this PR is merged, see below
-
kbn-shared-ux-utility(packages/kbn-shared-ux-utility)persisting references
- dev_docs/key_concepts/performance/case_studies/case_study_top_level_imports.mdx
-
no-data-types(packages/shared-ux/page/no_data/types)persisting references
- src/platform/packages/shared/shared-ux/page/kibana_template/impl/README.mdx
-
redirect_app(packages/shared-ux/link/redirect_app/impl)persisting references
- dev_docs/key_concepts/navigation.mdx
…elocate-20250106110819
|
@eokoneyo, thank you! I fixed those three places |
jbudz
approved these changes
Jan 6, 2025
eokoneyo
approved these changes
Jan 6, 2025
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
History
|
MichaelMarcialis
approved these changes
Jan 6, 2025
|
@elasticmachine merge upstream |
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Jan 7, 2025
…-ux/` (elastic#205602) (cherry picked from commit 175916e) # Conflicts: # .github/CODEOWNERS
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Dosant
added a commit
that referenced
this pull request
Jan 7, 2025
…shared-ux/` (#205602) (#205696) # Backport This will backport the following commits from `main` to `8.x`: - [Sustainable Kibana Architecture: Move packages under `packages/shared-ux/` (#205602)](#205602) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-07T09:46:25Z","message":"Sustainable Kibana Architecture: Move packages under `packages/shared-ux/` (#205602)","sha":"175916ef23a09938833966de51ec8d674be28c06","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","plugin groups"],"number":205602,"url":"https://github.com/elastic/kibana/pull/205602","mergeCommit":{"message":"Sustainable Kibana Architecture: Move packages under `packages/shared-ux/` (#205602)","sha":"175916ef23a09938833966de51ec8d674be28c06"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205602","number":205602,"mergeCommit":{"message":"Sustainable Kibana Architecture: Move packages under `packages/shared-ux/` (#205602)","sha":"175916ef23a09938833966de51ec8d674be28c06"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 7, 2025
## Summary Follow up to elastic#205602 (cherry picked from commit 1388cde)
kowalczyk-krzysztof
pushed a commit
to kowalczyk-krzysztof/kibana
that referenced
this pull request
Jan 7, 2025
kowalczyk-krzysztof
pushed a commit
to kowalczyk-krzysztof/kibana
that referenced
this pull request
Jan 7, 2025
## Summary Follow up to elastic#205602
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
Jan 8, 2025
## Summary Follow up to elastic#205602
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.
Important
packages[\/\\]andplugins[\/\\]patterns in the source code (Babel and Eslint config files), and update them appropriately..buildkite/scripts/pipelines/pull_request/pipeline.tsto ensure that any CI pipeline customizations continue to be correctly applied after the changed path names.tsand.jsfiles listed in the sections below, as some of them contain relative paths that have been updated.Note
Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe here.
50 packages(s) are going to be relocated:
@kbn/shared-ux-avatar-solutionsrc/platform/packages/shared/shared-ux/avatar/solution@kbn/shared-ux-button-exit-full-screensrc/platform/packages/shared/shared-ux/button/exit_full_screen@kbn/shared-ux-button-toolbarsrc/platform/packages/shared/shared-ux/button_toolbar@kbn/shared-ux-card-no-datasrc/platform/packages/shared/shared-ux/card/no_data/impl@kbn/shared-ux-card-no-data-mockssrc/platform/packages/shared/shared-ux/card/no_data/mocks@kbn/shared-ux-card-no-data-typessrc/platform/packages/shared/shared-ux/card/no_data/types@kbn/shared-ux-chrome-navigationsrc/platform/packages/shared/shared-ux/chrome/navigation@kbn/shared-ux-error-boundarysrc/platform/packages/shared/shared-ux/error_boundary@kbn/shared-ux-file-contextsrc/platform/packages/shared/shared-ux/file/context@kbn/shared-ux-file-imagesrc/platform/packages/shared/shared-ux/file/image/impl@kbn/shared-ux-file-image-mockssrc/platform/packages/shared/shared-ux/file/image/mocks@kbn/shared-ux-file-mockssrc/platform/packages/shared/shared-ux/file/mocks@kbn/shared-ux-file-pickersrc/platform/packages/shared/shared-ux/file/file_picker/impl@kbn/shared-ux-file-typessrc/platform/packages/shared/shared-ux/file/types@kbn/shared-ux-file-uploadsrc/platform/packages/shared/shared-ux/file/file_upload/impl@kbn/shared-ux-file-utilsrc/platform/packages/shared/shared-ux/file/util@kbn/shared-ux-link-redirect-appsrc/platform/packages/shared/shared-ux/link/redirect_app/impl@kbn/shared-ux-link-redirect-app-mockssrc/platform/packages/shared/shared-ux/link/redirect_app/mocks@kbn/shared-ux-link-redirect-app-typessrc/platform/packages/shared/shared-ux/link/redirect_app/types@kbn/shared-ux-markdownsrc/platform/packages/shared/shared-ux/markdown/impl@kbn/shared-ux-markdown-mockssrc/platform/packages/shared/shared-ux/markdown/mocks@kbn/shared-ux-markdown-typessrc/platform/packages/shared/shared-ux/markdown/types@kbn/shared-ux-page-analytics-no-datasrc/platform/packages/private/shared-ux/page/analytics_no_data/impl@kbn/shared-ux-page-analytics-no-data-mockssrc/platform/packages/private/shared-ux/page/analytics_no_data/mocks@kbn/shared-ux-page-analytics-no-data-typessrc/platform/packages/private/shared-ux/page/analytics_no_data/types@kbn/shared-ux-page-kibana-no-datasrc/platform/packages/private/shared-ux/page/kibana_no_data/impl@kbn/shared-ux-page-kibana-no-data-mockssrc/platform/packages/private/shared-ux/page/kibana_no_data/mocks@kbn/shared-ux-page-kibana-no-data-typessrc/platform/packages/private/shared-ux/page/kibana_no_data/types@kbn/shared-ux-page-kibana-templatesrc/platform/packages/shared/shared-ux/page/kibana_template/impl@kbn/shared-ux-page-kibana-template-mockssrc/platform/packages/shared/shared-ux/page/kibana_template/mocks@kbn/shared-ux-page-kibana-template-typessrc/platform/packages/shared/shared-ux/page/kibana_template/types@kbn/shared-ux-page-no-datasrc/platform/packages/shared/shared-ux/page/no_data/impl@kbn/shared-ux-page-no-data-configsrc/platform/packages/shared/shared-ux/page/no_data_config/impl@kbn/shared-ux-page-no-data-config-mockssrc/platform/packages/shared/shared-ux/page/no_data_config/mocks@kbn/shared-ux-page-no-data-config-typessrc/platform/packages/shared/shared-ux/page/no_data_config/types@kbn/shared-ux-page-no-data-mockssrc/platform/packages/shared/shared-ux/page/no_data/mocks@kbn/shared-ux-page-no-data-typessrc/platform/packages/shared/shared-ux/page/no_data/types@kbn/shared-ux-page-solution-navsrc/platform/packages/shared/shared-ux/page/solution_nav@kbn/shared-ux-prompt-no-data-viewssrc/platform/packages/shared/shared-ux/prompt/no_data_views/impl@kbn/shared-ux-prompt-no-data-views-mockssrc/platform/packages/shared/shared-ux/prompt/no_data_views/mocks@kbn/shared-ux-prompt-no-data-views-typessrc/platform/packages/shared/shared-ux/prompt/no_data_views/types@kbn/shared-ux-prompt-not-foundsrc/platform/packages/shared/shared-ux/prompt/not_found@kbn/shared-ux-routersrc/platform/packages/shared/shared-ux/router/impl@kbn/shared-ux-router-mockssrc/platform/packages/shared/shared-ux/router/mocks@kbn/shared-ux-router-typessrc/platform/packages/shared/shared-ux/router/types@kbn/shared-ux-storybook-configsrc/platform/packages/private/shared-ux/storybook/config@kbn/shared-ux-storybook-mocksrc/platform/packages/shared/shared-ux/storybook/mock@kbn/shared-ux-tabbed-modalsrc/platform/packages/shared/shared-ux/modal/tabbed@kbn/shared-ux-table-persistsrc/platform/packages/shared/shared-ux/table_persist@kbn/shared-ux-utilitysrc/platform/packages/shared/kbn-shared-ux-utilityUpdated relative paths