Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shared-ux storybook config #205728

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Jan 7, 2025

Summary

Follow up to #205602

@Dosant Dosant requested a review from a team as a code owner January 7, 2025 13:27
@Dosant Dosant added release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Jan 7, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

Copy link
Contributor

@eokoneyo eokoneyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, stories are loaded properly

@Dosant Dosant enabled auto-merge (squash) January 7, 2025 14:04
@Dosant Dosant merged commit 1388cde into elastic:main Jan 7, 2025
16 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12654111495

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #97 / Index Management app Index Management: data streams tab Data streams tab Modify data streams index mode allows to upgrade data stream from time series to logsdb index mode

Metrics [docs]

✅ unchanged

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 7, 2025
## Summary

Follow up to elastic#205602

(cherry picked from commit 1388cde)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 7, 2025
# Backport

This will backport the following commits from `main` to `8.x`:
- [Fix shared-ux storybook config
(#205728)](#205728)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Anton
Dosov","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-07T15:21:31Z","message":"Fix
shared-ux storybook config (#205728)\n\n## Summary\r\n\r\nFollow up to
https://github.com/elastic/kibana/pull/205602","sha":"1388cdebb98d2e10adceb80ea05db18235424797","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor"],"title":"Fix
shared-ux storybook
config","number":205728,"url":"https://github.com/elastic/kibana/pull/205728","mergeCommit":{"message":"Fix
shared-ux storybook config (#205728)\n\n## Summary\r\n\r\nFollow up to
https://github.com/elastic/kibana/pull/205602","sha":"1388cdebb98d2e10adceb80ea05db18235424797"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205728","number":205728,"mergeCommit":{"message":"Fix
shared-ux storybook config (#205728)\n\n## Summary\r\n\r\nFollow up to
https://github.com/elastic/kibana/pull/205602","sha":"1388cdebb98d2e10adceb80ea05db18235424797"}}]}]
BACKPORT-->

Co-authored-by: Anton Dosov <[email protected]>
kowalczyk-krzysztof pushed a commit to kowalczyk-krzysztof/kibana that referenced this pull request Jan 7, 2025
crespocarlos pushed a commit to crespocarlos/kibana that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants