Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-security
#202748
+747
−404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
gsoldevila
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
|
Pinging @elastic/kibana-security (Team:Security) |
Ikuni17
approved these changes
Dec 3, 2024
gsoldevila
added
backport:skip
pmuellr
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
ResponseOps changes LGTM. Was just 5 files, and the only changes were in comments. Which looked ok to me.
I'm slightly awed we were able to move a bunch of these plugins we use within ResponseOps without any other changes! That change to reference other plugins via @kbn/XXX-plugin was a huge win, for changes like this!
gsoldevila
force-pushed
the
kbn-team-1309-move-kibana-security
branch
from
1eb4b47 to
33582ae
Compare
TinaHeiligers
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Core code changes LGTM.
FYI the failed jest test is a known issue, skipped in main, then re-enabled again (#202289), only to be flaky once more.
Merged
PhilippeOberti
approved these changes
Dec 13, 2024
jeramysoucy
requested changes
Dec 16, 2024
There was a problem hiding this comment.
@gsoldevila I noticed some links to specific commits that shouldn't be changed. I will push a commit to revert those.
The only other thing I noticed were discrepancies with some of the jest.config.js files. It looks like git may have gotten confused about which of these files were moved and where. However, the end result appears to be accurate, and I don't necessarily think it is an issue to have a strange file history on these particular files, but I wanted to bring it up.
legacy_rfcs/text/0016_ols_phase_1.md
Outdated
| @@ -103,7 +103,7 @@ export interface SavedObject<T = unknown> { | |||
|
|
|||
| ### 3.1.3 Saved Objects Client: Security wrapper | |||
|
|
|||
| The [security wrapper](https://github.com/elastic/kibana/blob/701697cc4a34d07c0508c3bdf01dca6f9d40a636/x-pack/plugins/security/server/saved_objects/secure_saved_objects_client_wrapper.ts) authorizes and audits operations against saved objects. | |||
| The [security wrapper](https://github.com/elastic/kibana/blob/701697cc4a34d07c0508c3bdf01dca6f9d40a636/x-pack/platform/plugins/shared/security/server/saved_objects/secure_saved_objects_client_wrapper.ts) authorizes and audits operations against saved objects. | |||
There was a problem hiding this comment.
The SO wrapper no longer exists (was replaced with the extension a long while back), and IMO we don't need to update any of these legacy RFC docs.
| @@ -19,7 +19,7 @@ export interface SavedObjectTypeIdTuple { | |||
| type: string; | |||
| } | |||
|
|
|||
| // NOTE: moved from x-pack/plugins/spaces/common/types.ts for use by SO security ext | |||
| // NOTE: moved from x-pack/platform/plugins/shared/spaces/common/types.ts for use by SO security ext | |||
There was a problem hiding this comment.
I think we can just delete this comment now. It was useful 2 years ago, but is no longer relevant.
Suggested change
| // NOTE: moved from x-pack/platform/plugins/shared/spaces/common/types.ts for use by SO security ext |
There was a problem hiding this comment.
Something is off here - the source and destination do not match. There is a jest.config.js file in the new x-pack/platform/packages/private/security/role_management_model folder, which looks like a new added file. It should have been moved and adjusted from the old location.
There was a problem hiding this comment.
For some reason this file got mixed up with role_management_model/jest.config.js. They both should have been moved accordingly, but instead this one was deleted, the origin of role_management_model/jest.config.js was moved erroneously, and x-pack/platform/packages/private/security/role_management_model/jest.config.js was created new.
| @@ -345,7 +345,7 @@ functions and will be impacted: | |||
| 6. [code](https://github.com/elastic/kibana/blob/5049b460b47d4ae3432e1d9219263bb4be441392/x-pack/legacy/plugins/code/server/plugin.ts#L129-L149) | |||
| 7. [spaces](https://github.com/elastic/kibana/blob/096c7ee51136327f778845c636d7c4f1188e5db2/x-pack/legacy/plugins/spaces/server/new_platform/plugin.ts#L95) | |||
| 8. [licensing](https://github.com/elastic/kibana/blob/4667c46caef26f8f47714504879197708debae32/x-pack/plugins/licensing/server/plugin.ts) | |||
| 9. [security](https://github.com/elastic/kibana/blob/0f2324e44566ce2cf083d89082841e57d2db6ef6/x-pack/plugins/security/server/plugin.ts#L96) | |||
There was a problem hiding this comment.
I don't think we need to update these old legacy RFCs
| @@ -343,7 +343,7 @@ functions and will be impacted: | |||
| 3. [vis_type_table](https://github.com/elastic/kibana/blob/6039709929caf0090a4130b8235f3a53bd04ed84/src/legacy/core_plugins/vis_type_table/public/plugin.ts#L61) | |||
| 4. [vis_type_vega](https://github.com/elastic/kibana/blob/6039709929caf0090a4130b8235f3a53bd04ed84/src/legacy/core_plugins/vis_type_vega/public/plugin.ts#L59) | |||
| 6. [code](https://github.com/elastic/kibana/blob/5049b460b47d4ae3432e1d9219263bb4be441392/x-pack/legacy/plugins/code/server/plugin.ts#L129-L149) | |||
| 7. [spaces](https://github.com/elastic/kibana/blob/096c7ee51136327f778845c636d7c4f1188e5db2/x-pack/legacy/plugins/spaces/server/new_platform/plugin.ts#L95) | |||
| 7. [spaces](https://github.com/elastic/kibana/blob/096c7ee51136327f778845c636d7c4f1188e5db2/x-pack/legacy/platform/plugins/shared/spaces/server/new_platform/plugin.ts#L95) | |||
There was a problem hiding this comment.
Nit: No need to update the legacy RFCs
There was a problem hiding this comment.
A few of the jest.config.js files are in this state, where they show up as having been moved from one domain to another (security/ui_components to spaces), and corrected. I don't think this is really consequential if the end result is correct.
| @@ -51,7 +51,7 @@ export const getWarningHeader = ( | |||
|
|
|||
| /** | |||
| * Taken from | |||
| * https://github.com/elastic/kibana/blob/ec30f2aeeb10fb64b507935e558832d3ef5abfaa/x-pack/plugins/spaces/server/usage_stats/usage_stats_client.ts#L113-L118 | |||
| * https://github.com/elastic/kibana/blob/ec30f2aeeb10fb64b507935e558832d3ef5abfaa/x-pack/platform/plugins/shared/spaces/server/usage_stats/usage_stats_client.ts#L113-L118 | |||
There was a problem hiding this comment.
This link should remain as it was, since it points to a specific commit.
Suggested change
| * https://github.com/elastic/kibana/blob/ec30f2aeeb10fb64b507935e558832d3ef5abfaa/x-pack/platform/plugins/shared/spaces/server/usage_stats/usage_stats_client.ts#L113-L118 | |
| * https://github.com/elastic/kibana/blob/ec30f2aeeb10fb64b507935e558832d3ef5abfaa/x-pack/plugins/spaces/server/usage_stats/usage_stats_client.ts#L113-L118 |
| @@ -8,7 +8,7 @@ import type { Headers } from '@kbn/core/server'; | |||
|
|
|||
| /** | |||
| * Taken from | |||
| * https://github.com/elastic/kibana/blob/ec30f2aeeb10fb64b507935e558832d3ef5abfaa/x-pack/plugins/spaces/server/usage_stats/usage_stats_client.ts#L113-L118 | |||
| * https://github.com/elastic/kibana/blob/ec30f2aeeb10fb64b507935e558832d3ef5abfaa/x-pack/platform/plugins/shared/spaces/server/usage_stats/usage_stats_client.ts#L113-L118 | |||
There was a problem hiding this comment.
Original link should remain, as it references a specific commit.
Suggested change
| * https://github.com/elastic/kibana/blob/ec30f2aeeb10fb64b507935e558832d3ef5abfaa/x-pack/platform/plugins/shared/spaces/server/usage_stats/usage_stats_client.ts#L113-L118 | |
| * https://github.com/elastic/kibana/blob/ec30f2aeeb10fb64b507935e558832d3ef5abfaa/x-pack/plugins/spaces/server/usage_stats/usage_stats_client.ts#L113-L118 |
jasonrhodes
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
@gsoldevila I'm not exactly sure why @elastic/obs-ux-management-team is being requested on this review as I don't see it touching any files that belong to us, but because we're listed here, I'll add a cursory approval (I've not looked at this PR at all beyond checking the "File filter" in the files tab to see if any files belong to our team, and none do)
dokmic
force-pushed
the
kbn-team-1309-move-kibana-security
branch
from
342b8eb to
6f32332
Compare
💚 Build Succeeded
Metrics [docs]
History
|
dokmic
added
v8.18.0
backport:version
|
Starting backport for target branches: 8.x |
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 similar comment
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dokmic
pushed a commit
to dokmic/kibana
that referenced
this pull request
Jan 5, 2025
…na-security` (elastic#202748) This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). | Id | Target folder | | -- | ------------- | | `@kbn/encrypted-saved-objects-plugin` | `x-pack/platform/plugins/shared/encrypted_saved_objects` | | `@kbn/interactive-setup-plugin` | `src/platform/plugins/private/interactive_setup` | | `@kbn/security-plugin` | `x-pack/platform/plugins/shared/security` | | `@kbn/spaces-plugin` | `x-pack/platform/plugins/shared/spaces` | | Id | Target folder | | -- | ------------- | | `@kbn/crypto` | `src/platform/packages/shared/kbn-crypto` | | `@kbn/handlebars` | `src/platform/packages/private/kbn-handlebars` | | `@kbn/safer-lodash-set` | `src/platform/packages/shared/kbn-safer-lodash-set` | | `@kbn/security-api-key-management` | `x-pack/platform/packages/shared/security/api_key_management` | | `@kbn/security-authorization-core` | `x-pack/platform/packages/private/security/authorization_core` | | `@kbn/security-authorization-core-common` | `x-pack/platform/packages/private/security/authorization_core_common` | | `@kbn/security-form-components` | `x-pack/platform/packages/shared/security/form_components` | | `@kbn/security-hardening` | `src/platform/packages/shared/kbn-security-hardening` | | `@kbn/security-plugin-types-common` | `x-pack/platform/packages/shared/security/plugin_types_common` | | `@kbn/security-plugin-types-public` | `x-pack/platform/packages/shared/security/plugin_types_public` | | `@kbn/security-plugin-types-server` | `x-pack/platform/packages/shared/security/plugin_types_server` | | `@kbn/security-role-management-model` | `x-pack/platform/packages/private/security/role_management_model` | | `@kbn/security-ui-components` | `x-pack/platform/packages/private/security/ui_components` | | `@kbn/user-profile-components` | `src/platform/packages/shared/kbn-user-profile-components` | <details open> <summary>Script errors</summary> ``` Cannot replace multiple occurrences of "../.." in the same line, please fix manually: /Users/dokmic/work/elastic/kibana/src/platform/packages/shared/kbn-safer-lodash-set/package.json:6 ``` </details><details > <summary>Updated references</summary> ``` ./.buildkite/scripts/steps/test/kbn_handlebars.sh ./.eslintrc.js ./.i18nrc.json ./docs/developer/advanced/sharing-saved-objects.asciidoc ./docs/developer/plugin-list.asciidoc ./legacy_rfcs/text/0007_lifecycle_unblocked.md ./legacy_rfcs/text/0016_ols_phase_1.md ./package.json ./packages/kbn-dependency-usage/src/dependency_graph/providers/cruiser.test.ts ./packages/kbn-ts-projects/config-paths.json ./packages/kbn-user-profile-components/src/user_profile.ts ./src/core/packages/saved-objects/common/src/types.ts ./src/core/packages/security/server/src/audit_logging/audit_logger.ts ./src/core/packages/user-profile/common/src/user_profile.ts ./src/dev/precommit_hook/casing_check_config.js ./src/platform/packages/private/kbn-handlebars/README.md ./src/platform/packages/private/kbn-handlebars/index.test.ts ./src/platform/packages/private/kbn-handlebars/index.ts ./src/platform/packages/private/kbn-handlebars/jest.config.js ./src/platform/packages/private/kbn-handlebars/scripts/check_for_upstream_updates.sh ./src/platform/packages/private/kbn-handlebars/scripts/print_ast.js ./src/platform/packages/private/kbn-handlebars/scripts/update_upstream_git_hash.sh ./src/platform/packages/private/kbn-handlebars/src/__jest__/test_bench.ts ./src/platform/packages/private/kbn-handlebars/src/handlebars.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.basic.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.blocks.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.builtins.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.compiler.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.data.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.helpers.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.partials.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.security.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.strict.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.subexpressions.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.utils.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.whitespace_control.test.ts ./src/platform/packages/private/kbn-handlebars/src/symbols.ts ./src/platform/packages/private/kbn-handlebars/src/types.ts ./src/platform/packages/private/kbn-handlebars/src/utils.ts ./src/platform/packages/private/kbn-handlebars/src/visitor.ts ./src/platform/packages/private/kbn-repo-packages/package-map.json ./src/platform/packages/private/kbn-ui-shared-deps-src/BUILD.bazel ./src/platform/packages/shared/kbn-crypto/jest.config.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/assoc.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/assoc.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/assocPath.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/assocPath.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/index.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/index.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/set.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/set.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/setWith.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/setWith.js ./src/platform/packages/shared/kbn-safer-lodash-set/index.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/index.js ./src/platform/packages/shared/kbn-safer-lodash-set/lodash/_baseSet.js ./src/platform/packages/shared/kbn-safer-lodash-set/lodash/set.js ./src/platform/packages/shared/kbn-safer-lodash-set/lodash/setWith.js ./src/platform/packages/shared/kbn-safer-lodash-set/package.json ./src/platform/packages/shared/kbn-safer-lodash-set/scripts/_get_lodash.sh ./src/platform/packages/shared/kbn-safer-lodash-set/scripts/license-header.txt ./src/platform/packages/shared/kbn-safer-lodash-set/scripts/save_state.sh ./src/platform/packages/shared/kbn-safer-lodash-set/scripts/update.sh ./src/platform/packages/shared/kbn-safer-lodash-set/set.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/set.js ./src/platform/packages/shared/kbn-safer-lodash-set/setWith.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/setWith.js ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_assoc.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_assocPath.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_patch_test.js ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_set.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_setWith.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/index.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/patch_test.js ./src/platform/packages/shared/kbn-safer-lodash-set/test/set.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/setWith.ts ./src/platform/packages/shared/kbn-user-profile-components/jest.config.js ./src/platform/plugins/private/interactive_setup/jest.config.js ./tsconfig.base.json ./x-pack/.i18nrc.json ./x-pack/platform/packages/private/security/authorization_core/jest.config.js ./x-pack/platform/packages/private/security/authorization_core_common/jest.config.js ./x-pack/platform/packages/private/security/role_management_model/jest.config.js ./x-pack/platform/packages/private/security/ui_components/jest.config.js ./x-pack/platform/packages/shared/security/api_key_management/jest.config.js ./x-pack/platform/packages/shared/security/form_components/jest.config.js ./x-pack/platform/plugins/shared/cases/server/authorization/index.ts ./x-pack/platform/plugins/shared/cases/server/authorization/types.ts ./x-pack/platform/plugins/shared/cases/server/connectors/cases/utils.ts ./x-pack/platform/plugins/shared/cases/server/routes/api/utils.ts ./x-pack/platform/plugins/shared/encrypted_saved_objects/README.md ./x-pack/platform/plugins/shared/encrypted_saved_objects/jest.config.js ./x-pack/platform/plugins/shared/fleet/common/http_authorization_header.ts ./x-pack/platform/plugins/shared/rule_registry/server/lib/get_is_kibana_request.ts ./x-pack/platform/plugins/shared/security/jest.config.js ./x-pack/platform/plugins/shared/spaces/jest.config.js ./x-pack/solutions/security/plugins/security_solution/server/lib/timeline/routes/notes/get_notes.ts ./yarn.lock .github/CODEOWNERS ``` </details><details > <summary>Updated relative paths</summary> ``` src/platform/packages/private/kbn-handlebars/jest.config.js:8 src/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts:276 src/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts:277 src/platform/packages/private/kbn-handlebars/tsconfig.json:2 src/platform/packages/shared/kbn-crypto/jest.config.js:12 src/platform/packages/shared/kbn-crypto/tsconfig.json:2 src/platform/packages/shared/kbn-safer-lodash-set/package.json:6 src/platform/packages/shared/kbn-safer-lodash-set/package.json:7 src/platform/packages/shared/kbn-safer-lodash-set/package.json:8 src/platform/packages/shared/kbn-safer-lodash-set/tsconfig.json:2 src/platform/packages/shared/kbn-security-hardening/tsconfig.json:2 src/platform/packages/shared/kbn-user-profile-components/jest.config.js:12 src/platform/packages/shared/kbn-user-profile-components/tsconfig.json:2 src/platform/plugins/private/interactive_setup/jest.config.js:12 src/platform/plugins/private/interactive_setup/tsconfig.json:2 x-pack/platform/packages/private/security/authorization_core/jest.config.js:13 x-pack/platform/packages/private/security/authorization_core/tsconfig.json:2 x-pack/platform/packages/private/security/authorization_core_common/jest.config.js:15 x-pack/platform/packages/private/security/authorization_core_common/tsconfig.json:2 x-pack/platform/packages/private/security/role_management_model/jest.config.js:14 x-pack/platform/packages/private/security/role_management_model/tsconfig.json:2 x-pack/platform/packages/private/security/ui_components/jest.config.js:13 x-pack/platform/packages/private/security/ui_components/tsconfig.json:2 x-pack/platform/packages/shared/security/api_key_management/jest.config.js:14 x-pack/platform/packages/shared/security/api_key_management/tsconfig.json:2 x-pack/platform/packages/shared/security/form_components/jest.config.js:14 x-pack/platform/packages/shared/security/form_components/tsconfig.json:2 x-pack/platform/packages/shared/security/plugin_types_common/tsconfig.json:2 x-pack/platform/packages/shared/security/plugin_types_public/tsconfig.json:2 x-pack/platform/packages/shared/security/plugin_types_server/tsconfig.json:2 x-pack/platform/plugins/shared/encrypted_saved_objects/README.md:8 x-pack/platform/plugins/shared/encrypted_saved_objects/jest.config.js:10 x-pack/platform/plugins/shared/encrypted_saved_objects/tsconfig.json:2 x-pack/platform/plugins/shared/security/jest.config.js:10 x-pack/platform/plugins/shared/security/tsconfig.json:2 x-pack/platform/plugins/shared/spaces/jest.config.js:10 x-pack/platform/plugins/shared/spaces/tsconfig.json:2 ``` </details> --------- Co-authored-by: Michael Dokolin <[email protected]> Co-authored-by: “jeramysoucy” <[email protected]> Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit ca5a08d)
dokmic
pushed a commit
to dokmic/kibana
that referenced
this pull request
Jan 5, 2025
…na-security` (elastic#202748) ## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). #### 4 plugin(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/encrypted-saved-objects-plugin` | `x-pack/platform/plugins/shared/encrypted_saved_objects` | | `@kbn/interactive-setup-plugin` | `src/platform/plugins/private/interactive_setup` | | `@kbn/security-plugin` | `x-pack/platform/plugins/shared/security` | | `@kbn/spaces-plugin` | `x-pack/platform/plugins/shared/spaces` | #### 14 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/crypto` | `src/platform/packages/shared/kbn-crypto` | | `@kbn/handlebars` | `src/platform/packages/private/kbn-handlebars` | | `@kbn/safer-lodash-set` | `src/platform/packages/shared/kbn-safer-lodash-set` | | `@kbn/security-api-key-management` | `x-pack/platform/packages/shared/security/api_key_management` | | `@kbn/security-authorization-core` | `x-pack/platform/packages/private/security/authorization_core` | | `@kbn/security-authorization-core-common` | `x-pack/platform/packages/private/security/authorization_core_common` | | `@kbn/security-form-components` | `x-pack/platform/packages/shared/security/form_components` | | `@kbn/security-hardening` | `src/platform/packages/shared/kbn-security-hardening` | | `@kbn/security-plugin-types-common` | `x-pack/platform/packages/shared/security/plugin_types_common` | | `@kbn/security-plugin-types-public` | `x-pack/platform/packages/shared/security/plugin_types_public` | | `@kbn/security-plugin-types-server` | `x-pack/platform/packages/shared/security/plugin_types_server` | | `@kbn/security-role-management-model` | `x-pack/platform/packages/private/security/role_management_model` | | `@kbn/security-ui-components` | `x-pack/platform/packages/private/security/ui_components` | | `@kbn/user-profile-components` | `src/platform/packages/shared/kbn-user-profile-components` | <details open> <summary>Script errors</summary> ``` Cannot replace multiple occurrences of "../.." in the same line, please fix manually: /Users/dokmic/work/elastic/kibana/src/platform/packages/shared/kbn-safer-lodash-set/package.json:6 ``` </details><details > <summary>Updated references</summary> ``` ./.buildkite/scripts/steps/test/kbn_handlebars.sh ./.eslintrc.js ./.i18nrc.json ./docs/developer/advanced/sharing-saved-objects.asciidoc ./docs/developer/plugin-list.asciidoc ./legacy_rfcs/text/0007_lifecycle_unblocked.md ./legacy_rfcs/text/0016_ols_phase_1.md ./package.json ./packages/kbn-dependency-usage/src/dependency_graph/providers/cruiser.test.ts ./packages/kbn-ts-projects/config-paths.json ./packages/kbn-user-profile-components/src/user_profile.ts ./src/core/packages/saved-objects/common/src/types.ts ./src/core/packages/security/server/src/audit_logging/audit_logger.ts ./src/core/packages/user-profile/common/src/user_profile.ts ./src/dev/precommit_hook/casing_check_config.js ./src/platform/packages/private/kbn-handlebars/README.md ./src/platform/packages/private/kbn-handlebars/index.test.ts ./src/platform/packages/private/kbn-handlebars/index.ts ./src/platform/packages/private/kbn-handlebars/jest.config.js ./src/platform/packages/private/kbn-handlebars/scripts/check_for_upstream_updates.sh ./src/platform/packages/private/kbn-handlebars/scripts/print_ast.js ./src/platform/packages/private/kbn-handlebars/scripts/update_upstream_git_hash.sh ./src/platform/packages/private/kbn-handlebars/src/__jest__/test_bench.ts ./src/platform/packages/private/kbn-handlebars/src/handlebars.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.basic.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.blocks.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.builtins.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.compiler.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.data.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.helpers.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.partials.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.security.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.strict.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.subexpressions.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.utils.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.whitespace_control.test.ts ./src/platform/packages/private/kbn-handlebars/src/symbols.ts ./src/platform/packages/private/kbn-handlebars/src/types.ts ./src/platform/packages/private/kbn-handlebars/src/utils.ts ./src/platform/packages/private/kbn-handlebars/src/visitor.ts ./src/platform/packages/private/kbn-repo-packages/package-map.json ./src/platform/packages/private/kbn-ui-shared-deps-src/BUILD.bazel ./src/platform/packages/shared/kbn-crypto/jest.config.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/assoc.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/assoc.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/assocPath.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/assocPath.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/index.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/index.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/set.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/set.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/setWith.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/setWith.js ./src/platform/packages/shared/kbn-safer-lodash-set/index.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/index.js ./src/platform/packages/shared/kbn-safer-lodash-set/lodash/_baseSet.js ./src/platform/packages/shared/kbn-safer-lodash-set/lodash/set.js ./src/platform/packages/shared/kbn-safer-lodash-set/lodash/setWith.js ./src/platform/packages/shared/kbn-safer-lodash-set/package.json ./src/platform/packages/shared/kbn-safer-lodash-set/scripts/_get_lodash.sh ./src/platform/packages/shared/kbn-safer-lodash-set/scripts/license-header.txt ./src/platform/packages/shared/kbn-safer-lodash-set/scripts/save_state.sh ./src/platform/packages/shared/kbn-safer-lodash-set/scripts/update.sh ./src/platform/packages/shared/kbn-safer-lodash-set/set.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/set.js ./src/platform/packages/shared/kbn-safer-lodash-set/setWith.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/setWith.js ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_assoc.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_assocPath.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_patch_test.js ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_set.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_setWith.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/index.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/patch_test.js ./src/platform/packages/shared/kbn-safer-lodash-set/test/set.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/setWith.ts ./src/platform/packages/shared/kbn-user-profile-components/jest.config.js ./src/platform/plugins/private/interactive_setup/jest.config.js ./tsconfig.base.json ./x-pack/.i18nrc.json ./x-pack/platform/packages/private/security/authorization_core/jest.config.js ./x-pack/platform/packages/private/security/authorization_core_common/jest.config.js ./x-pack/platform/packages/private/security/role_management_model/jest.config.js ./x-pack/platform/packages/private/security/ui_components/jest.config.js ./x-pack/platform/packages/shared/security/api_key_management/jest.config.js ./x-pack/platform/packages/shared/security/form_components/jest.config.js ./x-pack/platform/plugins/shared/cases/server/authorization/index.ts ./x-pack/platform/plugins/shared/cases/server/authorization/types.ts ./x-pack/platform/plugins/shared/cases/server/connectors/cases/utils.ts ./x-pack/platform/plugins/shared/cases/server/routes/api/utils.ts ./x-pack/platform/plugins/shared/encrypted_saved_objects/README.md ./x-pack/platform/plugins/shared/encrypted_saved_objects/jest.config.js ./x-pack/platform/plugins/shared/fleet/common/http_authorization_header.ts ./x-pack/platform/plugins/shared/rule_registry/server/lib/get_is_kibana_request.ts ./x-pack/platform/plugins/shared/security/jest.config.js ./x-pack/platform/plugins/shared/spaces/jest.config.js ./x-pack/solutions/security/plugins/security_solution/server/lib/timeline/routes/notes/get_notes.ts ./yarn.lock .github/CODEOWNERS ``` </details><details > <summary>Updated relative paths</summary> ``` src/platform/packages/private/kbn-handlebars/jest.config.js:8 src/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts:276 src/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts:277 src/platform/packages/private/kbn-handlebars/tsconfig.json:2 src/platform/packages/shared/kbn-crypto/jest.config.js:12 src/platform/packages/shared/kbn-crypto/tsconfig.json:2 src/platform/packages/shared/kbn-safer-lodash-set/package.json:6 src/platform/packages/shared/kbn-safer-lodash-set/package.json:7 src/platform/packages/shared/kbn-safer-lodash-set/package.json:8 src/platform/packages/shared/kbn-safer-lodash-set/tsconfig.json:2 src/platform/packages/shared/kbn-security-hardening/tsconfig.json:2 src/platform/packages/shared/kbn-user-profile-components/jest.config.js:12 src/platform/packages/shared/kbn-user-profile-components/tsconfig.json:2 src/platform/plugins/private/interactive_setup/jest.config.js:12 src/platform/plugins/private/interactive_setup/tsconfig.json:2 x-pack/platform/packages/private/security/authorization_core/jest.config.js:13 x-pack/platform/packages/private/security/authorization_core/tsconfig.json:2 x-pack/platform/packages/private/security/authorization_core_common/jest.config.js:15 x-pack/platform/packages/private/security/authorization_core_common/tsconfig.json:2 x-pack/platform/packages/private/security/role_management_model/jest.config.js:14 x-pack/platform/packages/private/security/role_management_model/tsconfig.json:2 x-pack/platform/packages/private/security/ui_components/jest.config.js:13 x-pack/platform/packages/private/security/ui_components/tsconfig.json:2 x-pack/platform/packages/shared/security/api_key_management/jest.config.js:14 x-pack/platform/packages/shared/security/api_key_management/tsconfig.json:2 x-pack/platform/packages/shared/security/form_components/jest.config.js:14 x-pack/platform/packages/shared/security/form_components/tsconfig.json:2 x-pack/platform/packages/shared/security/plugin_types_common/tsconfig.json:2 x-pack/platform/packages/shared/security/plugin_types_public/tsconfig.json:2 x-pack/platform/packages/shared/security/plugin_types_server/tsconfig.json:2 x-pack/platform/plugins/shared/encrypted_saved_objects/README.md:8 x-pack/platform/plugins/shared/encrypted_saved_objects/jest.config.js:10 x-pack/platform/plugins/shared/encrypted_saved_objects/tsconfig.json:2 x-pack/platform/plugins/shared/security/jest.config.js:10 x-pack/platform/plugins/shared/security/tsconfig.json:2 x-pack/platform/plugins/shared/spaces/jest.config.js:10 x-pack/platform/plugins/shared/spaces/tsconfig.json:2 ``` </details> --------- Co-authored-by: Michael Dokolin <[email protected]> Co-authored-by: “jeramysoucy” <[email protected]> Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit ca5a08d) # Conflicts: # .github/CODEOWNERS # x-pack/.i18nrc.json
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dokmic
pushed a commit
to dokmic/kibana
that referenced
this pull request
Jan 5, 2025
…na-security` (elastic#202748) This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). | Id | Target folder | | -- | ------------- | | `@kbn/encrypted-saved-objects-plugin` | `x-pack/platform/plugins/shared/encrypted_saved_objects` | | `@kbn/interactive-setup-plugin` | `src/platform/plugins/private/interactive_setup` | | `@kbn/security-plugin` | `x-pack/platform/plugins/shared/security` | | `@kbn/spaces-plugin` | `x-pack/platform/plugins/shared/spaces` | | Id | Target folder | | -- | ------------- | | `@kbn/crypto` | `src/platform/packages/shared/kbn-crypto` | | `@kbn/handlebars` | `src/platform/packages/private/kbn-handlebars` | | `@kbn/safer-lodash-set` | `src/platform/packages/shared/kbn-safer-lodash-set` | | `@kbn/security-api-key-management` | `x-pack/platform/packages/shared/security/api_key_management` | | `@kbn/security-authorization-core` | `x-pack/platform/packages/private/security/authorization_core` | | `@kbn/security-authorization-core-common` | `x-pack/platform/packages/private/security/authorization_core_common` | | `@kbn/security-form-components` | `x-pack/platform/packages/shared/security/form_components` | | `@kbn/security-hardening` | `src/platform/packages/shared/kbn-security-hardening` | | `@kbn/security-plugin-types-common` | `x-pack/platform/packages/shared/security/plugin_types_common` | | `@kbn/security-plugin-types-public` | `x-pack/platform/packages/shared/security/plugin_types_public` | | `@kbn/security-plugin-types-server` | `x-pack/platform/packages/shared/security/plugin_types_server` | | `@kbn/security-role-management-model` | `x-pack/platform/packages/private/security/role_management_model` | | `@kbn/security-ui-components` | `x-pack/platform/packages/private/security/ui_components` | | `@kbn/user-profile-components` | `src/platform/packages/shared/kbn-user-profile-components` | <details open> <summary>Script errors</summary> ``` Cannot replace multiple occurrences of "../.." in the same line, please fix manually: /Users/dokmic/work/elastic/kibana/src/platform/packages/shared/kbn-safer-lodash-set/package.json:6 ``` </details><details > <summary>Updated references</summary> ``` ./.buildkite/scripts/steps/test/kbn_handlebars.sh ./.eslintrc.js ./.i18nrc.json ./docs/developer/advanced/sharing-saved-objects.asciidoc ./docs/developer/plugin-list.asciidoc ./legacy_rfcs/text/0007_lifecycle_unblocked.md ./legacy_rfcs/text/0016_ols_phase_1.md ./package.json ./packages/kbn-dependency-usage/src/dependency_graph/providers/cruiser.test.ts ./packages/kbn-ts-projects/config-paths.json ./packages/kbn-user-profile-components/src/user_profile.ts ./src/core/packages/saved-objects/common/src/types.ts ./src/core/packages/security/server/src/audit_logging/audit_logger.ts ./src/core/packages/user-profile/common/src/user_profile.ts ./src/dev/precommit_hook/casing_check_config.js ./src/platform/packages/private/kbn-handlebars/README.md ./src/platform/packages/private/kbn-handlebars/index.test.ts ./src/platform/packages/private/kbn-handlebars/index.ts ./src/platform/packages/private/kbn-handlebars/jest.config.js ./src/platform/packages/private/kbn-handlebars/scripts/check_for_upstream_updates.sh ./src/platform/packages/private/kbn-handlebars/scripts/print_ast.js ./src/platform/packages/private/kbn-handlebars/scripts/update_upstream_git_hash.sh ./src/platform/packages/private/kbn-handlebars/src/__jest__/test_bench.ts ./src/platform/packages/private/kbn-handlebars/src/handlebars.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.basic.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.blocks.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.builtins.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.compiler.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.data.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.helpers.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.partials.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.security.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.strict.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.subexpressions.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.utils.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.whitespace_control.test.ts ./src/platform/packages/private/kbn-handlebars/src/symbols.ts ./src/platform/packages/private/kbn-handlebars/src/types.ts ./src/platform/packages/private/kbn-handlebars/src/utils.ts ./src/platform/packages/private/kbn-handlebars/src/visitor.ts ./src/platform/packages/private/kbn-repo-packages/package-map.json ./src/platform/packages/private/kbn-ui-shared-deps-src/BUILD.bazel ./src/platform/packages/shared/kbn-crypto/jest.config.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/assoc.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/assoc.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/assocPath.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/assocPath.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/index.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/index.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/set.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/set.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/setWith.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/setWith.js ./src/platform/packages/shared/kbn-safer-lodash-set/index.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/index.js ./src/platform/packages/shared/kbn-safer-lodash-set/lodash/_baseSet.js ./src/platform/packages/shared/kbn-safer-lodash-set/lodash/set.js ./src/platform/packages/shared/kbn-safer-lodash-set/lodash/setWith.js ./src/platform/packages/shared/kbn-safer-lodash-set/package.json ./src/platform/packages/shared/kbn-safer-lodash-set/scripts/_get_lodash.sh ./src/platform/packages/shared/kbn-safer-lodash-set/scripts/license-header.txt ./src/platform/packages/shared/kbn-safer-lodash-set/scripts/save_state.sh ./src/platform/packages/shared/kbn-safer-lodash-set/scripts/update.sh ./src/platform/packages/shared/kbn-safer-lodash-set/set.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/set.js ./src/platform/packages/shared/kbn-safer-lodash-set/setWith.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/setWith.js ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_assoc.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_assocPath.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_patch_test.js ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_set.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_setWith.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/index.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/patch_test.js ./src/platform/packages/shared/kbn-safer-lodash-set/test/set.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/setWith.ts ./src/platform/packages/shared/kbn-user-profile-components/jest.config.js ./src/platform/plugins/private/interactive_setup/jest.config.js ./tsconfig.base.json ./x-pack/.i18nrc.json ./x-pack/platform/packages/private/security/authorization_core/jest.config.js ./x-pack/platform/packages/private/security/authorization_core_common/jest.config.js ./x-pack/platform/packages/private/security/role_management_model/jest.config.js ./x-pack/platform/packages/private/security/ui_components/jest.config.js ./x-pack/platform/packages/shared/security/api_key_management/jest.config.js ./x-pack/platform/packages/shared/security/form_components/jest.config.js ./x-pack/platform/plugins/shared/cases/server/authorization/index.ts ./x-pack/platform/plugins/shared/cases/server/authorization/types.ts ./x-pack/platform/plugins/shared/cases/server/connectors/cases/utils.ts ./x-pack/platform/plugins/shared/cases/server/routes/api/utils.ts ./x-pack/platform/plugins/shared/encrypted_saved_objects/README.md ./x-pack/platform/plugins/shared/encrypted_saved_objects/jest.config.js ./x-pack/platform/plugins/shared/fleet/common/http_authorization_header.ts ./x-pack/platform/plugins/shared/rule_registry/server/lib/get_is_kibana_request.ts ./x-pack/platform/plugins/shared/security/jest.config.js ./x-pack/platform/plugins/shared/spaces/jest.config.js ./x-pack/solutions/security/plugins/security_solution/server/lib/timeline/routes/notes/get_notes.ts ./yarn.lock .github/CODEOWNERS ``` </details><details > <summary>Updated relative paths</summary> ``` src/platform/packages/private/kbn-handlebars/jest.config.js:8 src/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts:276 src/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts:277 src/platform/packages/private/kbn-handlebars/tsconfig.json:2 src/platform/packages/shared/kbn-crypto/jest.config.js:12 src/platform/packages/shared/kbn-crypto/tsconfig.json:2 src/platform/packages/shared/kbn-safer-lodash-set/package.json:6 src/platform/packages/shared/kbn-safer-lodash-set/package.json:7 src/platform/packages/shared/kbn-safer-lodash-set/package.json:8 src/platform/packages/shared/kbn-safer-lodash-set/tsconfig.json:2 src/platform/packages/shared/kbn-security-hardening/tsconfig.json:2 src/platform/packages/shared/kbn-user-profile-components/jest.config.js:12 src/platform/packages/shared/kbn-user-profile-components/tsconfig.json:2 src/platform/plugins/private/interactive_setup/jest.config.js:12 src/platform/plugins/private/interactive_setup/tsconfig.json:2 x-pack/platform/packages/private/security/authorization_core/jest.config.js:13 x-pack/platform/packages/private/security/authorization_core/tsconfig.json:2 x-pack/platform/packages/private/security/authorization_core_common/jest.config.js:15 x-pack/platform/packages/private/security/authorization_core_common/tsconfig.json:2 x-pack/platform/packages/private/security/role_management_model/jest.config.js:14 x-pack/platform/packages/private/security/role_management_model/tsconfig.json:2 x-pack/platform/packages/private/security/ui_components/jest.config.js:13 x-pack/platform/packages/private/security/ui_components/tsconfig.json:2 x-pack/platform/packages/shared/security/api_key_management/jest.config.js:14 x-pack/platform/packages/shared/security/api_key_management/tsconfig.json:2 x-pack/platform/packages/shared/security/form_components/jest.config.js:14 x-pack/platform/packages/shared/security/form_components/tsconfig.json:2 x-pack/platform/packages/shared/security/plugin_types_common/tsconfig.json:2 x-pack/platform/packages/shared/security/plugin_types_public/tsconfig.json:2 x-pack/platform/packages/shared/security/plugin_types_server/tsconfig.json:2 x-pack/platform/plugins/shared/encrypted_saved_objects/README.md:8 x-pack/platform/plugins/shared/encrypted_saved_objects/jest.config.js:10 x-pack/platform/plugins/shared/encrypted_saved_objects/tsconfig.json:2 x-pack/platform/plugins/shared/security/jest.config.js:10 x-pack/platform/plugins/shared/security/tsconfig.json:2 x-pack/platform/plugins/shared/spaces/jest.config.js:10 x-pack/platform/plugins/shared/spaces/tsconfig.json:2 ``` </details> --------- Co-authored-by: Michael Dokolin <[email protected]> Co-authored-by: “jeramysoucy” <[email protected]> Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit ca5a08d)
dokmic
pushed a commit
to dokmic/kibana
that referenced
this pull request
Jan 6, 2025
…na-security` (elastic#202748) This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). | Id | Target folder | | -- | ------------- | | `@kbn/encrypted-saved-objects-plugin` | `x-pack/platform/plugins/shared/encrypted_saved_objects` | | `@kbn/interactive-setup-plugin` | `src/platform/plugins/private/interactive_setup` | | `@kbn/security-plugin` | `x-pack/platform/plugins/shared/security` | | `@kbn/spaces-plugin` | `x-pack/platform/plugins/shared/spaces` | | Id | Target folder | | -- | ------------- | | `@kbn/crypto` | `src/platform/packages/shared/kbn-crypto` | | `@kbn/handlebars` | `src/platform/packages/private/kbn-handlebars` | | `@kbn/safer-lodash-set` | `src/platform/packages/shared/kbn-safer-lodash-set` | | `@kbn/security-api-key-management` | `x-pack/platform/packages/shared/security/api_key_management` | | `@kbn/security-authorization-core` | `x-pack/platform/packages/private/security/authorization_core` | | `@kbn/security-authorization-core-common` | `x-pack/platform/packages/private/security/authorization_core_common` | | `@kbn/security-form-components` | `x-pack/platform/packages/shared/security/form_components` | | `@kbn/security-hardening` | `src/platform/packages/shared/kbn-security-hardening` | | `@kbn/security-plugin-types-common` | `x-pack/platform/packages/shared/security/plugin_types_common` | | `@kbn/security-plugin-types-public` | `x-pack/platform/packages/shared/security/plugin_types_public` | | `@kbn/security-plugin-types-server` | `x-pack/platform/packages/shared/security/plugin_types_server` | | `@kbn/security-role-management-model` | `x-pack/platform/packages/private/security/role_management_model` | | `@kbn/security-ui-components` | `x-pack/platform/packages/private/security/ui_components` | | `@kbn/user-profile-components` | `src/platform/packages/shared/kbn-user-profile-components` | <details open> <summary>Script errors</summary> ``` Cannot replace multiple occurrences of "../.." in the same line, please fix manually: /Users/dokmic/work/elastic/kibana/src/platform/packages/shared/kbn-safer-lodash-set/package.json:6 ``` </details><details > <summary>Updated references</summary> ``` ./.buildkite/scripts/steps/test/kbn_handlebars.sh ./.eslintrc.js ./.i18nrc.json ./docs/developer/advanced/sharing-saved-objects.asciidoc ./docs/developer/plugin-list.asciidoc ./legacy_rfcs/text/0007_lifecycle_unblocked.md ./legacy_rfcs/text/0016_ols_phase_1.md ./package.json ./packages/kbn-dependency-usage/src/dependency_graph/providers/cruiser.test.ts ./packages/kbn-ts-projects/config-paths.json ./packages/kbn-user-profile-components/src/user_profile.ts ./src/core/packages/saved-objects/common/src/types.ts ./src/core/packages/security/server/src/audit_logging/audit_logger.ts ./src/core/packages/user-profile/common/src/user_profile.ts ./src/dev/precommit_hook/casing_check_config.js ./src/platform/packages/private/kbn-handlebars/README.md ./src/platform/packages/private/kbn-handlebars/index.test.ts ./src/platform/packages/private/kbn-handlebars/index.ts ./src/platform/packages/private/kbn-handlebars/jest.config.js ./src/platform/packages/private/kbn-handlebars/scripts/check_for_upstream_updates.sh ./src/platform/packages/private/kbn-handlebars/scripts/print_ast.js ./src/platform/packages/private/kbn-handlebars/scripts/update_upstream_git_hash.sh ./src/platform/packages/private/kbn-handlebars/src/__jest__/test_bench.ts ./src/platform/packages/private/kbn-handlebars/src/handlebars.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.basic.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.blocks.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.builtins.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.compiler.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.data.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.helpers.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.partials.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.security.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.strict.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.subexpressions.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.utils.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.whitespace_control.test.ts ./src/platform/packages/private/kbn-handlebars/src/symbols.ts ./src/platform/packages/private/kbn-handlebars/src/types.ts ./src/platform/packages/private/kbn-handlebars/src/utils.ts ./src/platform/packages/private/kbn-handlebars/src/visitor.ts ./src/platform/packages/private/kbn-repo-packages/package-map.json ./src/platform/packages/private/kbn-ui-shared-deps-src/BUILD.bazel ./src/platform/packages/shared/kbn-crypto/jest.config.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/assoc.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/assoc.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/assocPath.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/assocPath.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/index.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/index.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/set.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/set.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/setWith.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/setWith.js ./src/platform/packages/shared/kbn-safer-lodash-set/index.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/index.js ./src/platform/packages/shared/kbn-safer-lodash-set/lodash/_baseSet.js ./src/platform/packages/shared/kbn-safer-lodash-set/lodash/set.js ./src/platform/packages/shared/kbn-safer-lodash-set/lodash/setWith.js ./src/platform/packages/shared/kbn-safer-lodash-set/package.json ./src/platform/packages/shared/kbn-safer-lodash-set/scripts/_get_lodash.sh ./src/platform/packages/shared/kbn-safer-lodash-set/scripts/license-header.txt ./src/platform/packages/shared/kbn-safer-lodash-set/scripts/save_state.sh ./src/platform/packages/shared/kbn-safer-lodash-set/scripts/update.sh ./src/platform/packages/shared/kbn-safer-lodash-set/set.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/set.js ./src/platform/packages/shared/kbn-safer-lodash-set/setWith.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/setWith.js ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_assoc.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_assocPath.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_patch_test.js ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_set.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_setWith.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/index.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/patch_test.js ./src/platform/packages/shared/kbn-safer-lodash-set/test/set.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/setWith.ts ./src/platform/packages/shared/kbn-user-profile-components/jest.config.js ./src/platform/plugins/private/interactive_setup/jest.config.js ./tsconfig.base.json ./x-pack/.i18nrc.json ./x-pack/platform/packages/private/security/authorization_core/jest.config.js ./x-pack/platform/packages/private/security/authorization_core_common/jest.config.js ./x-pack/platform/packages/private/security/role_management_model/jest.config.js ./x-pack/platform/packages/private/security/ui_components/jest.config.js ./x-pack/platform/packages/shared/security/api_key_management/jest.config.js ./x-pack/platform/packages/shared/security/form_components/jest.config.js ./x-pack/platform/plugins/shared/cases/server/authorization/index.ts ./x-pack/platform/plugins/shared/cases/server/authorization/types.ts ./x-pack/platform/plugins/shared/cases/server/connectors/cases/utils.ts ./x-pack/platform/plugins/shared/cases/server/routes/api/utils.ts ./x-pack/platform/plugins/shared/encrypted_saved_objects/README.md ./x-pack/platform/plugins/shared/encrypted_saved_objects/jest.config.js ./x-pack/platform/plugins/shared/fleet/common/http_authorization_header.ts ./x-pack/platform/plugins/shared/rule_registry/server/lib/get_is_kibana_request.ts ./x-pack/platform/plugins/shared/security/jest.config.js ./x-pack/platform/plugins/shared/spaces/jest.config.js ./x-pack/solutions/security/plugins/security_solution/server/lib/timeline/routes/notes/get_notes.ts ./yarn.lock .github/CODEOWNERS ``` </details><details > <summary>Updated relative paths</summary> ``` src/platform/packages/private/kbn-handlebars/jest.config.js:8 src/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts:276 src/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts:277 src/platform/packages/private/kbn-handlebars/tsconfig.json:2 src/platform/packages/shared/kbn-crypto/jest.config.js:12 src/platform/packages/shared/kbn-crypto/tsconfig.json:2 src/platform/packages/shared/kbn-safer-lodash-set/package.json:6 src/platform/packages/shared/kbn-safer-lodash-set/package.json:7 src/platform/packages/shared/kbn-safer-lodash-set/package.json:8 src/platform/packages/shared/kbn-safer-lodash-set/tsconfig.json:2 src/platform/packages/shared/kbn-security-hardening/tsconfig.json:2 src/platform/packages/shared/kbn-user-profile-components/jest.config.js:12 src/platform/packages/shared/kbn-user-profile-components/tsconfig.json:2 src/platform/plugins/private/interactive_setup/jest.config.js:12 src/platform/plugins/private/interactive_setup/tsconfig.json:2 x-pack/platform/packages/private/security/authorization_core/jest.config.js:13 x-pack/platform/packages/private/security/authorization_core/tsconfig.json:2 x-pack/platform/packages/private/security/authorization_core_common/jest.config.js:15 x-pack/platform/packages/private/security/authorization_core_common/tsconfig.json:2 x-pack/platform/packages/private/security/role_management_model/jest.config.js:14 x-pack/platform/packages/private/security/role_management_model/tsconfig.json:2 x-pack/platform/packages/private/security/ui_components/jest.config.js:13 x-pack/platform/packages/private/security/ui_components/tsconfig.json:2 x-pack/platform/packages/shared/security/api_key_management/jest.config.js:14 x-pack/platform/packages/shared/security/api_key_management/tsconfig.json:2 x-pack/platform/packages/shared/security/form_components/jest.config.js:14 x-pack/platform/packages/shared/security/form_components/tsconfig.json:2 x-pack/platform/packages/shared/security/plugin_types_common/tsconfig.json:2 x-pack/platform/packages/shared/security/plugin_types_public/tsconfig.json:2 x-pack/platform/packages/shared/security/plugin_types_server/tsconfig.json:2 x-pack/platform/plugins/shared/encrypted_saved_objects/README.md:8 x-pack/platform/plugins/shared/encrypted_saved_objects/jest.config.js:10 x-pack/platform/plugins/shared/encrypted_saved_objects/tsconfig.json:2 x-pack/platform/plugins/shared/security/jest.config.js:10 x-pack/platform/plugins/shared/security/tsconfig.json:2 x-pack/platform/plugins/shared/spaces/jest.config.js:10 x-pack/platform/plugins/shared/spaces/tsconfig.json:2 ``` </details> --------- Co-authored-by: Michael Dokolin <[email protected]> Co-authored-by: “jeramysoucy” <[email protected]> Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit ca5a08d)
dokmic
added a commit
that referenced
this pull request
Jan 6, 2025
…c/kibana-security` (#202748) (#205569) # Backport This will backport the following commits from `main` to `8.x`: - [Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-security` (#202748)](#202748) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-05T11:57:01Z","message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-security` (#202748)\n\n## Summary\n\nThis PR aims at relocating some of the Kibana modules (plugins and\npackages) into a new folder structure, according to the _Sustainable\nKibana Architecture_ initiative.\n\n> [!IMPORTANT]\n> * We kindly ask you to:\n> * Manually fix the errors in the error section below (if there are\nany).\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\nsource code (Babel and Eslint config files), and update them\nappropriately.\n> * Manually review\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\nany CI pipeline customizations continue to be correctly applied after\nthe changed path names\n> * Review all of the updated files, specially the `.ts` and `.js` files\nlisted in the sections below, as some of them contain relative paths\nthat have been updated.\n> * Think of potential impact of the move, including tooling and\nconfiguration files that can be pointing to the relocated modules. E.g.:\n> * customised eslint rules\n> * docs pointing to source code\n\n> [!NOTE]\n> * This PR has been auto-generated.\n> * Any manual contributions will be lost if the 'relocate' script is\nre-run.\n> * Try to obtain the missing reviews / approvals before applying manual\nfixes, and/or keep your changes in a .patch / git stash.\n> * Please use\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\nSlack channel for feedback.\n\nAre you trying to rebase this PR to solve merge conflicts? Please follow\nthe steps describe\n[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).\n\n#### 4 plugin(s) are going to be relocated:\n\n| Id | Target folder |\n| -- | ------------- |\n| `@kbn/encrypted-saved-objects-plugin` |\n`x-pack/platform/plugins/shared/encrypted_saved_objects` |\n| `@kbn/interactive-setup-plugin` |\n`src/platform/plugins/private/interactive_setup` |\n| `@kbn/security-plugin` | `x-pack/platform/plugins/shared/security` |\n| `@kbn/spaces-plugin` | `x-pack/platform/plugins/shared/spaces` |\n\n\n\n\n#### 14 packages(s) are going to be relocated:\n\n| Id | Target folder |\n| -- | ------------- |\n| `@kbn/crypto` | `src/platform/packages/shared/kbn-crypto` |\n| `@kbn/handlebars` | `src/platform/packages/private/kbn-handlebars` |\n| `@kbn/safer-lodash-set` |\n`src/platform/packages/shared/kbn-safer-lodash-set` |\n| `@kbn/security-api-key-management` |\n`x-pack/platform/packages/shared/security/api_key_management` |\n| `@kbn/security-authorization-core` |\n`x-pack/platform/packages/private/security/authorization_core` |\n| `@kbn/security-authorization-core-common` |\n`x-pack/platform/packages/private/security/authorization_core_common` |\n| `@kbn/security-form-components` |\n`x-pack/platform/packages/shared/security/form_components` |\n| `@kbn/security-hardening` |\n`src/platform/packages/shared/kbn-security-hardening` |\n| `@kbn/security-plugin-types-common` |\n`x-pack/platform/packages/shared/security/plugin_types_common` |\n| `@kbn/security-plugin-types-public` |\n`x-pack/platform/packages/shared/security/plugin_types_public` |\n| `@kbn/security-plugin-types-server` |\n`x-pack/platform/packages/shared/security/plugin_types_server` |\n| `@kbn/security-role-management-model` |\n`x-pack/platform/packages/private/security/role_management_model` |\n| `@kbn/security-ui-components` |\n`x-pack/platform/packages/private/security/ui_components` |\n| `@kbn/user-profile-components` |\n`src/platform/packages/shared/kbn-user-profile-components` |\n\n\n<details open>\n<summary>Script errors</summary>\n\n```\nCannot replace multiple occurrences of \"../..\" in the same line, please fix manually:\t/Users/dokmic/work/elastic/kibana/src/platform/packages/shared/kbn-safer-lodash-set/package.json:6\n```\n\n</details><details >\n<summary>Updated references</summary>\n\n```\n./.buildkite/scripts/steps/test/kbn_handlebars.sh\n./.eslintrc.js\n./.i18nrc.json\n./docs/developer/advanced/sharing-saved-objects.asciidoc\n./docs/developer/plugin-list.asciidoc\n./legacy_rfcs/text/0007_lifecycle_unblocked.md\n./legacy_rfcs/text/0016_ols_phase_1.md\n./package.json\n./packages/kbn-dependency-usage/src/dependency_graph/providers/cruiser.test.ts\n./packages/kbn-ts-projects/config-paths.json\n./packages/kbn-user-profile-components/src/user_profile.ts\n./src/core/packages/saved-objects/common/src/types.ts\n./src/core/packages/security/server/src/audit_logging/audit_logger.ts\n./src/core/packages/user-profile/common/src/user_profile.ts\n./src/dev/precommit_hook/casing_check_config.js\n./src/platform/packages/private/kbn-handlebars/README.md\n./src/platform/packages/private/kbn-handlebars/index.test.ts\n./src/platform/packages/private/kbn-handlebars/index.ts\n./src/platform/packages/private/kbn-handlebars/jest.config.js\n./src/platform/packages/private/kbn-handlebars/scripts/check_for_upstream_updates.sh\n./src/platform/packages/private/kbn-handlebars/scripts/print_ast.js\n./src/platform/packages/private/kbn-handlebars/scripts/update_upstream_git_hash.sh\n./src/platform/packages/private/kbn-handlebars/src/__jest__/test_bench.ts\n./src/platform/packages/private/kbn-handlebars/src/handlebars.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.basic.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.blocks.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.builtins.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.compiler.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.data.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.helpers.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.partials.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.security.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.strict.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.subexpressions.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.utils.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.whitespace_control.test.ts\n./src/platform/packages/private/kbn-handlebars/src/symbols.ts\n./src/platform/packages/private/kbn-handlebars/src/types.ts\n./src/platform/packages/private/kbn-handlebars/src/utils.ts\n./src/platform/packages/private/kbn-handlebars/src/visitor.ts\n./src/platform/packages/private/kbn-repo-packages/package-map.json\n./src/platform/packages/private/kbn-ui-shared-deps-src/BUILD.bazel\n./src/platform/packages/shared/kbn-crypto/jest.config.js\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/assoc.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/assoc.js\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/assocPath.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/assocPath.js\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/index.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/index.js\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/set.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/set.js\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/setWith.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/setWith.js\n./src/platform/packages/shared/kbn-safer-lodash-set/index.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/index.js\n./src/platform/packages/shared/kbn-safer-lodash-set/lodash/_baseSet.js\n./src/platform/packages/shared/kbn-safer-lodash-set/lodash/set.js\n./src/platform/packages/shared/kbn-safer-lodash-set/lodash/setWith.js\n./src/platform/packages/shared/kbn-safer-lodash-set/package.json\n./src/platform/packages/shared/kbn-safer-lodash-set/scripts/_get_lodash.sh\n./src/platform/packages/shared/kbn-safer-lodash-set/scripts/license-header.txt\n./src/platform/packages/shared/kbn-safer-lodash-set/scripts/save_state.sh\n./src/platform/packages/shared/kbn-safer-lodash-set/scripts/update.sh\n./src/platform/packages/shared/kbn-safer-lodash-set/set.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/set.js\n./src/platform/packages/shared/kbn-safer-lodash-set/setWith.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/setWith.js\n./src/platform/packages/shared/kbn-safer-lodash-set/test/fp.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_assoc.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_assocPath.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_patch_test.js\n./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_set.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_setWith.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/test/index.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/test/patch_test.js\n./src/platform/packages/shared/kbn-safer-lodash-set/test/set.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/test/setWith.ts\n./src/platform/packages/shared/kbn-user-profile-components/jest.config.js\n./src/platform/plugins/private/interactive_setup/jest.config.js\n./tsconfig.base.json\n./x-pack/.i18nrc.json\n./x-pack/platform/packages/private/security/authorization_core/jest.config.js\n./x-pack/platform/packages/private/security/authorization_core_common/jest.config.js\n./x-pack/platform/packages/private/security/role_management_model/jest.config.js\n./x-pack/platform/packages/private/security/ui_components/jest.config.js\n./x-pack/platform/packages/shared/security/api_key_management/jest.config.js\n./x-pack/platform/packages/shared/security/form_components/jest.config.js\n./x-pack/platform/plugins/shared/cases/server/authorization/index.ts\n./x-pack/platform/plugins/shared/cases/server/authorization/types.ts\n./x-pack/platform/plugins/shared/cases/server/connectors/cases/utils.ts\n./x-pack/platform/plugins/shared/cases/server/routes/api/utils.ts\n./x-pack/platform/plugins/shared/encrypted_saved_objects/README.md\n./x-pack/platform/plugins/shared/encrypted_saved_objects/jest.config.js\n./x-pack/platform/plugins/shared/fleet/common/http_authorization_header.ts\n./x-pack/platform/plugins/shared/rule_registry/server/lib/get_is_kibana_request.ts\n./x-pack/platform/plugins/shared/security/jest.config.js\n./x-pack/platform/plugins/shared/spaces/jest.config.js\n./x-pack/solutions/security/plugins/security_solution/server/lib/timeline/routes/notes/get_notes.ts\n./yarn.lock\n.github/CODEOWNERS\n```\n\n</details><details >\n<summary>Updated relative paths</summary>\n\n```\nsrc/platform/packages/private/kbn-handlebars/jest.config.js:8\nsrc/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts:276\nsrc/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts:277\nsrc/platform/packages/private/kbn-handlebars/tsconfig.json:2\nsrc/platform/packages/shared/kbn-crypto/jest.config.js:12\nsrc/platform/packages/shared/kbn-crypto/tsconfig.json:2\nsrc/platform/packages/shared/kbn-safer-lodash-set/package.json:6\nsrc/platform/packages/shared/kbn-safer-lodash-set/package.json:7\nsrc/platform/packages/shared/kbn-safer-lodash-set/package.json:8\nsrc/platform/packages/shared/kbn-safer-lodash-set/tsconfig.json:2\nsrc/platform/packages/shared/kbn-security-hardening/tsconfig.json:2\nsrc/platform/packages/shared/kbn-user-profile-components/jest.config.js:12\nsrc/platform/packages/shared/kbn-user-profile-components/tsconfig.json:2\nsrc/platform/plugins/private/interactive_setup/jest.config.js:12\nsrc/platform/plugins/private/interactive_setup/tsconfig.json:2\nx-pack/platform/packages/private/security/authorization_core/jest.config.js:13\nx-pack/platform/packages/private/security/authorization_core/tsconfig.json:2\nx-pack/platform/packages/private/security/authorization_core_common/jest.config.js:15\nx-pack/platform/packages/private/security/authorization_core_common/tsconfig.json:2\nx-pack/platform/packages/private/security/role_management_model/jest.config.js:14\nx-pack/platform/packages/private/security/role_management_model/tsconfig.json:2\nx-pack/platform/packages/private/security/ui_components/jest.config.js:13\nx-pack/platform/packages/private/security/ui_components/tsconfig.json:2\nx-pack/platform/packages/shared/security/api_key_management/jest.config.js:14\nx-pack/platform/packages/shared/security/api_key_management/tsconfig.json:2\nx-pack/platform/packages/shared/security/form_components/jest.config.js:14\nx-pack/platform/packages/shared/security/form_components/tsconfig.json:2\nx-pack/platform/packages/shared/security/plugin_types_common/tsconfig.json:2\nx-pack/platform/packages/shared/security/plugin_types_public/tsconfig.json:2\nx-pack/platform/packages/shared/security/plugin_types_server/tsconfig.json:2\nx-pack/platform/plugins/shared/encrypted_saved_objects/README.md:8\nx-pack/platform/plugins/shared/encrypted_saved_objects/jest.config.js:10\nx-pack/platform/plugins/shared/encrypted_saved_objects/tsconfig.json:2\nx-pack/platform/plugins/shared/security/jest.config.js:10\nx-pack/platform/plugins/shared/security/tsconfig.json:2\nx-pack/platform/plugins/shared/spaces/jest.config.js:10\nx-pack/platform/plugins/shared/spaces/tsconfig.json:2\n```\n\n</details>\n\n---------\n\nCo-authored-by: Michael Dokolin <[email protected]>\nCo-authored-by: “jeramysoucy” <[email protected]>\nCo-authored-by: kibanamachine <[email protected]>","sha":"ca5a08db0029d5b9e2cd5139b23a05c5ae09ddad","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","Team:Security","release_note:skip","v9.0.0","backport:version","v8.18.0","plugin groups"],"number":202748,"url":"https://github.com/elastic/kibana/pull/202748","mergeCommit":{"message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-security` (#202748)\n\n## Summary\n\nThis PR aims at relocating some of the Kibana modules (plugins and\npackages) into a new folder structure, according to the _Sustainable\nKibana Architecture_ initiative.\n\n> [!IMPORTANT]\n> * We kindly ask you to:\n> * Manually fix the errors in the error section below (if there are\nany).\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\nsource code (Babel and Eslint config files), and update them\nappropriately.\n> * Manually review\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\nany CI pipeline customizations continue to be correctly applied after\nthe changed path names\n> * Review all of the updated files, specially the `.ts` and `.js` files\nlisted in the sections below, as some of them contain relative paths\nthat have been updated.\n> * Think of potential impact of the move, including tooling and\nconfiguration files that can be pointing to the relocated modules. E.g.:\n> * customised eslint rules\n> * docs pointing to source code\n\n> [!NOTE]\n> * This PR has been auto-generated.\n> * Any manual contributions will be lost if the 'relocate' script is\nre-run.\n> * Try to obtain the missing reviews / approvals before applying manual\nfixes, and/or keep your changes in a .patch / git stash.\n> * Please use\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\nSlack channel for feedback.\n\nAre you trying to rebase this PR to solve merge conflicts? Please follow\nthe steps describe\n[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).\n\n#### 4 plugin(s) are going to be relocated:\n\n| Id | Target folder |\n| -- | ------------- |\n| `@kbn/encrypted-saved-objects-plugin` |\n`x-pack/platform/plugins/shared/encrypted_saved_objects` |\n| `@kbn/interactive-setup-plugin` |\n`src/platform/plugins/private/interactive_setup` |\n| `@kbn/security-plugin` | `x-pack/platform/plugins/shared/security` |\n| `@kbn/spaces-plugin` | `x-pack/platform/plugins/shared/spaces` |\n\n\n\n\n#### 14 packages(s) are going to be relocated:\n\n| Id | Target folder |\n| -- | ------------- |\n| `@kbn/crypto` | `src/platform/packages/shared/kbn-crypto` |\n| `@kbn/handlebars` | `src/platform/packages/private/kbn-handlebars` |\n| `@kbn/safer-lodash-set` |\n`src/platform/packages/shared/kbn-safer-lodash-set` |\n| `@kbn/security-api-key-management` |\n`x-pack/platform/packages/shared/security/api_key_management` |\n| `@kbn/security-authorization-core` |\n`x-pack/platform/packages/private/security/authorization_core` |\n| `@kbn/security-authorization-core-common` |\n`x-pack/platform/packages/private/security/authorization_core_common` |\n| `@kbn/security-form-components` |\n`x-pack/platform/packages/shared/security/form_components` |\n| `@kbn/security-hardening` |\n`src/platform/packages/shared/kbn-security-hardening` |\n| `@kbn/security-plugin-types-common` |\n`x-pack/platform/packages/shared/security/plugin_types_common` |\n| `@kbn/security-plugin-types-public` |\n`x-pack/platform/packages/shared/security/plugin_types_public` |\n| `@kbn/security-plugin-types-server` |\n`x-pack/platform/packages/shared/security/plugin_types_server` |\n| `@kbn/security-role-management-model` |\n`x-pack/platform/packages/private/security/role_management_model` |\n| `@kbn/security-ui-components` |\n`x-pack/platform/packages/private/security/ui_components` |\n| `@kbn/user-profile-components` |\n`src/platform/packages/shared/kbn-user-profile-components` |\n\n\n<details open>\n<summary>Script errors</summary>\n\n```\nCannot replace multiple occurrences of \"../..\" in the same line, please fix manually:\t/Users/dokmic/work/elastic/kibana/src/platform/packages/shared/kbn-safer-lodash-set/package.json:6\n```\n\n</details><details >\n<summary>Updated references</summary>\n\n```\n./.buildkite/scripts/steps/test/kbn_handlebars.sh\n./.eslintrc.js\n./.i18nrc.json\n./docs/developer/advanced/sharing-saved-objects.asciidoc\n./docs/developer/plugin-list.asciidoc\n./legacy_rfcs/text/0007_lifecycle_unblocked.md\n./legacy_rfcs/text/0016_ols_phase_1.md\n./package.json\n./packages/kbn-dependency-usage/src/dependency_graph/providers/cruiser.test.ts\n./packages/kbn-ts-projects/config-paths.json\n./packages/kbn-user-profile-components/src/user_profile.ts\n./src/core/packages/saved-objects/common/src/types.ts\n./src/core/packages/security/server/src/audit_logging/audit_logger.ts\n./src/core/packages/user-profile/common/src/user_profile.ts\n./src/dev/precommit_hook/casing_check_config.js\n./src/platform/packages/private/kbn-handlebars/README.md\n./src/platform/packages/private/kbn-handlebars/index.test.ts\n./src/platform/packages/private/kbn-handlebars/index.ts\n./src/platform/packages/private/kbn-handlebars/jest.config.js\n./src/platform/packages/private/kbn-handlebars/scripts/check_for_upstream_updates.sh\n./src/platform/packages/private/kbn-handlebars/scripts/print_ast.js\n./src/platform/packages/private/kbn-handlebars/scripts/update_upstream_git_hash.sh\n./src/platform/packages/private/kbn-handlebars/src/__jest__/test_bench.ts\n./src/platform/packages/private/kbn-handlebars/src/handlebars.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.basic.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.blocks.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.builtins.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.compiler.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.data.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.helpers.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.partials.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.security.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.strict.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.subexpressions.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.utils.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.whitespace_control.test.ts\n./src/platform/packages/private/kbn-handlebars/src/symbols.ts\n./src/platform/packages/private/kbn-handlebars/src/types.ts\n./src/platform/packages/private/kbn-handlebars/src/utils.ts\n./src/platform/packages/private/kbn-handlebars/src/visitor.ts\n./src/platform/packages/private/kbn-repo-packages/package-map.json\n./src/platform/packages/private/kbn-ui-shared-deps-src/BUILD.bazel\n./src/platform/packages/shared/kbn-crypto/jest.config.js\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/assoc.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/assoc.js\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/assocPath.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/assocPath.js\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/index.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/index.js\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/set.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/set.js\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/setWith.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/setWith.js\n./src/platform/packages/shared/kbn-safer-lodash-set/index.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/index.js\n./src/platform/packages/shared/kbn-safer-lodash-set/lodash/_baseSet.js\n./src/platform/packages/shared/kbn-safer-lodash-set/lodash/set.js\n./src/platform/packages/shared/kbn-safer-lodash-set/lodash/setWith.js\n./src/platform/packages/shared/kbn-safer-lodash-set/package.json\n./src/platform/packages/shared/kbn-safer-lodash-set/scripts/_get_lodash.sh\n./src/platform/packages/shared/kbn-safer-lodash-set/scripts/license-header.txt\n./src/platform/packages/shared/kbn-safer-lodash-set/scripts/save_state.sh\n./src/platform/packages/shared/kbn-safer-lodash-set/scripts/update.sh\n./src/platform/packages/shared/kbn-safer-lodash-set/set.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/set.js\n./src/platform/packages/shared/kbn-safer-lodash-set/setWith.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/setWith.js\n./src/platform/packages/shared/kbn-safer-lodash-set/test/fp.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_assoc.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_assocPath.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_patch_test.js\n./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_set.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_setWith.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/test/index.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/test/patch_test.js\n./src/platform/packages/shared/kbn-safer-lodash-set/test/set.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/test/setWith.ts\n./src/platform/packages/shared/kbn-user-profile-components/jest.config.js\n./src/platform/plugins/private/interactive_setup/jest.config.js\n./tsconfig.base.json\n./x-pack/.i18nrc.json\n./x-pack/platform/packages/private/security/authorization_core/jest.config.js\n./x-pack/platform/packages/private/security/authorization_core_common/jest.config.js\n./x-pack/platform/packages/private/security/role_management_model/jest.config.js\n./x-pack/platform/packages/private/security/ui_components/jest.config.js\n./x-pack/platform/packages/shared/security/api_key_management/jest.config.js\n./x-pack/platform/packages/shared/security/form_components/jest.config.js\n./x-pack/platform/plugins/shared/cases/server/authorization/index.ts\n./x-pack/platform/plugins/shared/cases/server/authorization/types.ts\n./x-pack/platform/plugins/shared/cases/server/connectors/cases/utils.ts\n./x-pack/platform/plugins/shared/cases/server/routes/api/utils.ts\n./x-pack/platform/plugins/shared/encrypted_saved_objects/README.md\n./x-pack/platform/plugins/shared/encrypted_saved_objects/jest.config.js\n./x-pack/platform/plugins/shared/fleet/common/http_authorization_header.ts\n./x-pack/platform/plugins/shared/rule_registry/server/lib/get_is_kibana_request.ts\n./x-pack/platform/plugins/shared/security/jest.config.js\n./x-pack/platform/plugins/shared/spaces/jest.config.js\n./x-pack/solutions/security/plugins/security_solution/server/lib/timeline/routes/notes/get_notes.ts\n./yarn.lock\n.github/CODEOWNERS\n```\n\n</details><details >\n<summary>Updated relative paths</summary>\n\n```\nsrc/platform/packages/private/kbn-handlebars/jest.config.js:8\nsrc/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts:276\nsrc/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts:277\nsrc/platform/packages/private/kbn-handlebars/tsconfig.json:2\nsrc/platform/packages/shared/kbn-crypto/jest.config.js:12\nsrc/platform/packages/shared/kbn-crypto/tsconfig.json:2\nsrc/platform/packages/shared/kbn-safer-lodash-set/package.json:6\nsrc/platform/packages/shared/kbn-safer-lodash-set/package.json:7\nsrc/platform/packages/shared/kbn-safer-lodash-set/package.json:8\nsrc/platform/packages/shared/kbn-safer-lodash-set/tsconfig.json:2\nsrc/platform/packages/shared/kbn-security-hardening/tsconfig.json:2\nsrc/platform/packages/shared/kbn-user-profile-components/jest.config.js:12\nsrc/platform/packages/shared/kbn-user-profile-components/tsconfig.json:2\nsrc/platform/plugins/private/interactive_setup/jest.config.js:12\nsrc/platform/plugins/private/interactive_setup/tsconfig.json:2\nx-pack/platform/packages/private/security/authorization_core/jest.config.js:13\nx-pack/platform/packages/private/security/authorization_core/tsconfig.json:2\nx-pack/platform/packages/private/security/authorization_core_common/jest.config.js:15\nx-pack/platform/packages/private/security/authorization_core_common/tsconfig.json:2\nx-pack/platform/packages/private/security/role_management_model/jest.config.js:14\nx-pack/platform/packages/private/security/role_management_model/tsconfig.json:2\nx-pack/platform/packages/private/security/ui_components/jest.config.js:13\nx-pack/platform/packages/private/security/ui_components/tsconfig.json:2\nx-pack/platform/packages/shared/security/api_key_management/jest.config.js:14\nx-pack/platform/packages/shared/security/api_key_management/tsconfig.json:2\nx-pack/platform/packages/shared/security/form_components/jest.config.js:14\nx-pack/platform/packages/shared/security/form_components/tsconfig.json:2\nx-pack/platform/packages/shared/security/plugin_types_common/tsconfig.json:2\nx-pack/platform/packages/shared/security/plugin_types_public/tsconfig.json:2\nx-pack/platform/packages/shared/security/plugin_types_server/tsconfig.json:2\nx-pack/platform/plugins/shared/encrypted_saved_objects/README.md:8\nx-pack/platform/plugins/shared/encrypted_saved_objects/jest.config.js:10\nx-pack/platform/plugins/shared/encrypted_saved_objects/tsconfig.json:2\nx-pack/platform/plugins/shared/security/jest.config.js:10\nx-pack/platform/plugins/shared/security/tsconfig.json:2\nx-pack/platform/plugins/shared/spaces/jest.config.js:10\nx-pack/platform/plugins/shared/spaces/tsconfig.json:2\n```\n\n</details>\n\n---------\n\nCo-authored-by: Michael Dokolin <[email protected]>\nCo-authored-by: “jeramysoucy” <[email protected]>\nCo-authored-by: kibanamachine <[email protected]>","sha":"ca5a08db0029d5b9e2cd5139b23a05c5ae09ddad"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202748","number":202748,"mergeCommit":{"message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-security` (#202748)\n\n## Summary\n\nThis PR aims at relocating some of the Kibana modules (plugins and\npackages) into a new folder structure, according to the _Sustainable\nKibana Architecture_ initiative.\n\n> [!IMPORTANT]\n> * We kindly ask you to:\n> * Manually fix the errors in the error section below (if there are\nany).\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\nsource code (Babel and Eslint config files), and update them\nappropriately.\n> * Manually review\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\nany CI pipeline customizations continue to be correctly applied after\nthe changed path names\n> * Review all of the updated files, specially the `.ts` and `.js` files\nlisted in the sections below, as some of them contain relative paths\nthat have been updated.\n> * Think of potential impact of the move, including tooling and\nconfiguration files that can be pointing to the relocated modules. E.g.:\n> * customised eslint rules\n> * docs pointing to source code\n\n> [!NOTE]\n> * This PR has been auto-generated.\n> * Any manual contributions will be lost if the 'relocate' script is\nre-run.\n> * Try to obtain the missing reviews / approvals before applying manual\nfixes, and/or keep your changes in a .patch / git stash.\n> * Please use\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\nSlack channel for feedback.\n\nAre you trying to rebase this PR to solve merge conflicts? Please follow\nthe steps describe\n[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).\n\n#### 4 plugin(s) are going to be relocated:\n\n| Id | Target folder |\n| -- | ------------- |\n| `@kbn/encrypted-saved-objects-plugin` |\n`x-pack/platform/plugins/shared/encrypted_saved_objects` |\n| `@kbn/interactive-setup-plugin` |\n`src/platform/plugins/private/interactive_setup` |\n| `@kbn/security-plugin` | `x-pack/platform/plugins/shared/security` |\n| `@kbn/spaces-plugin` | `x-pack/platform/plugins/shared/spaces` |\n\n\n\n\n#### 14 packages(s) are going to be relocated:\n\n| Id | Target folder |\n| -- | ------------- |\n| `@kbn/crypto` | `src/platform/packages/shared/kbn-crypto` |\n| `@kbn/handlebars` | `src/platform/packages/private/kbn-handlebars` |\n| `@kbn/safer-lodash-set` |\n`src/platform/packages/shared/kbn-safer-lodash-set` |\n| `@kbn/security-api-key-management` |\n`x-pack/platform/packages/shared/security/api_key_management` |\n| `@kbn/security-authorization-core` |\n`x-pack/platform/packages/private/security/authorization_core` |\n| `@kbn/security-authorization-core-common` |\n`x-pack/platform/packages/private/security/authorization_core_common` |\n| `@kbn/security-form-components` |\n`x-pack/platform/packages/shared/security/form_components` |\n| `@kbn/security-hardening` |\n`src/platform/packages/shared/kbn-security-hardening` |\n| `@kbn/security-plugin-types-common` |\n`x-pack/platform/packages/shared/security/plugin_types_common` |\n| `@kbn/security-plugin-types-public` |\n`x-pack/platform/packages/shared/security/plugin_types_public` |\n| `@kbn/security-plugin-types-server` |\n`x-pack/platform/packages/shared/security/plugin_types_server` |\n| `@kbn/security-role-management-model` |\n`x-pack/platform/packages/private/security/role_management_model` |\n| `@kbn/security-ui-components` |\n`x-pack/platform/packages/private/security/ui_components` |\n| `@kbn/user-profile-components` |\n`src/platform/packages/shared/kbn-user-profile-components` |\n\n\n<details open>\n<summary>Script errors</summary>\n\n```\nCannot replace multiple occurrences of \"../..\" in the same line, please fix manually:\t/Users/dokmic/work/elastic/kibana/src/platform/packages/shared/kbn-safer-lodash-set/package.json:6\n```\n\n</details><details >\n<summary>Updated references</summary>\n\n```\n./.buildkite/scripts/steps/test/kbn_handlebars.sh\n./.eslintrc.js\n./.i18nrc.json\n./docs/developer/advanced/sharing-saved-objects.asciidoc\n./docs/developer/plugin-list.asciidoc\n./legacy_rfcs/text/0007_lifecycle_unblocked.md\n./legacy_rfcs/text/0016_ols_phase_1.md\n./package.json\n./packages/kbn-dependency-usage/src/dependency_graph/providers/cruiser.test.ts\n./packages/kbn-ts-projects/config-paths.json\n./packages/kbn-user-profile-components/src/user_profile.ts\n./src/core/packages/saved-objects/common/src/types.ts\n./src/core/packages/security/server/src/audit_logging/audit_logger.ts\n./src/core/packages/user-profile/common/src/user_profile.ts\n./src/dev/precommit_hook/casing_check_config.js\n./src/platform/packages/private/kbn-handlebars/README.md\n./src/platform/packages/private/kbn-handlebars/index.test.ts\n./src/platform/packages/private/kbn-handlebars/index.ts\n./src/platform/packages/private/kbn-handlebars/jest.config.js\n./src/platform/packages/private/kbn-handlebars/scripts/check_for_upstream_updates.sh\n./src/platform/packages/private/kbn-handlebars/scripts/print_ast.js\n./src/platform/packages/private/kbn-handlebars/scripts/update_upstream_git_hash.sh\n./src/platform/packages/private/kbn-handlebars/src/__jest__/test_bench.ts\n./src/platform/packages/private/kbn-handlebars/src/handlebars.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.basic.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.blocks.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.builtins.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.compiler.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.data.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.helpers.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.partials.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.security.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.strict.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.subexpressions.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.utils.test.ts\n./src/platform/packages/private/kbn-handlebars/src/spec/index.whitespace_control.test.ts\n./src/platform/packages/private/kbn-handlebars/src/symbols.ts\n./src/platform/packages/private/kbn-handlebars/src/types.ts\n./src/platform/packages/private/kbn-handlebars/src/utils.ts\n./src/platform/packages/private/kbn-handlebars/src/visitor.ts\n./src/platform/packages/private/kbn-repo-packages/package-map.json\n./src/platform/packages/private/kbn-ui-shared-deps-src/BUILD.bazel\n./src/platform/packages/shared/kbn-crypto/jest.config.js\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/assoc.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/assoc.js\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/assocPath.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/assocPath.js\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/index.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/index.js\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/set.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/set.js\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/setWith.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/fp/setWith.js\n./src/platform/packages/shared/kbn-safer-lodash-set/index.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/index.js\n./src/platform/packages/shared/kbn-safer-lodash-set/lodash/_baseSet.js\n./src/platform/packages/shared/kbn-safer-lodash-set/lodash/set.js\n./src/platform/packages/shared/kbn-safer-lodash-set/lodash/setWith.js\n./src/platform/packages/shared/kbn-safer-lodash-set/package.json\n./src/platform/packages/shared/kbn-safer-lodash-set/scripts/_get_lodash.sh\n./src/platform/packages/shared/kbn-safer-lodash-set/scripts/license-header.txt\n./src/platform/packages/shared/kbn-safer-lodash-set/scripts/save_state.sh\n./src/platform/packages/shared/kbn-safer-lodash-set/scripts/update.sh\n./src/platform/packages/shared/kbn-safer-lodash-set/set.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/set.js\n./src/platform/packages/shared/kbn-safer-lodash-set/setWith.d.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/setWith.js\n./src/platform/packages/shared/kbn-safer-lodash-set/test/fp.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_assoc.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_assocPath.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_patch_test.js\n./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_set.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_setWith.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/test/index.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/test/patch_test.js\n./src/platform/packages/shared/kbn-safer-lodash-set/test/set.ts\n./src/platform/packages/shared/kbn-safer-lodash-set/test/setWith.ts\n./src/platform/packages/shared/kbn-user-profile-components/jest.config.js\n./src/platform/plugins/private/interactive_setup/jest.config.js\n./tsconfig.base.json\n./x-pack/.i18nrc.json\n./x-pack/platform/packages/private/security/authorization_core/jest.config.js\n./x-pack/platform/packages/private/security/authorization_core_common/jest.config.js\n./x-pack/platform/packages/private/security/role_management_model/jest.config.js\n./x-pack/platform/packages/private/security/ui_components/jest.config.js\n./x-pack/platform/packages/shared/security/api_key_management/jest.config.js\n./x-pack/platform/packages/shared/security/form_components/jest.config.js\n./x-pack/platform/plugins/shared/cases/server/authorization/index.ts\n./x-pack/platform/plugins/shared/cases/server/authorization/types.ts\n./x-pack/platform/plugins/shared/cases/server/connectors/cases/utils.ts\n./x-pack/platform/plugins/shared/cases/server/routes/api/utils.ts\n./x-pack/platform/plugins/shared/encrypted_saved_objects/README.md\n./x-pack/platform/plugins/shared/encrypted_saved_objects/jest.config.js\n./x-pack/platform/plugins/shared/fleet/common/http_authorization_header.ts\n./x-pack/platform/plugins/shared/rule_registry/server/lib/get_is_kibana_request.ts\n./x-pack/platform/plugins/shared/security/jest.config.js\n./x-pack/platform/plugins/shared/spaces/jest.config.js\n./x-pack/solutions/security/plugins/security_solution/server/lib/timeline/routes/notes/get_notes.ts\n./yarn.lock\n.github/CODEOWNERS\n```\n\n</details><details >\n<summary>Updated relative paths</summary>\n\n```\nsrc/platform/packages/private/kbn-handlebars/jest.config.js:8\nsrc/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts:276\nsrc/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts:277\nsrc/platform/packages/private/kbn-handlebars/tsconfig.json:2\nsrc/platform/packages/shared/kbn-crypto/jest.config.js:12\nsrc/platform/packages/shared/kbn-crypto/tsconfig.json:2\nsrc/platform/packages/shared/kbn-safer-lodash-set/package.json:6\nsrc/platform/packages/shared/kbn-safer-lodash-set/package.json:7\nsrc/platform/packages/shared/kbn-safer-lodash-set/package.json:8\nsrc/platform/packages/shared/kbn-safer-lodash-set/tsconfig.json:2\nsrc/platform/packages/shared/kbn-security-hardening/tsconfig.json:2\nsrc/platform/packages/shared/kbn-user-profile-components/jest.config.js:12\nsrc/platform/packages/shared/kbn-user-profile-components/tsconfig.json:2\nsrc/platform/plugins/private/interactive_setup/jest.config.js:12\nsrc/platform/plugins/private/interactive_setup/tsconfig.json:2\nx-pack/platform/packages/private/security/authorization_core/jest.config.js:13\nx-pack/platform/packages/private/security/authorization_core/tsconfig.json:2\nx-pack/platform/packages/private/security/authorization_core_common/jest.config.js:15\nx-pack/platform/packages/private/security/authorization_core_common/tsconfig.json:2\nx-pack/platform/packages/private/security/role_management_model/jest.config.js:14\nx-pack/platform/packages/private/security/role_management_model/tsconfig.json:2\nx-pack/platform/packages/private/security/ui_components/jest.config.js:13\nx-pack/platform/packages/private/security/ui_components/tsconfig.json:2\nx-pack/platform/packages/shared/security/api_key_management/jest.config.js:14\nx-pack/platform/packages/shared/security/api_key_management/tsconfig.json:2\nx-pack/platform/packages/shared/security/form_components/jest.config.js:14\nx-pack/platform/packages/shared/security/form_components/tsconfig.json:2\nx-pack/platform/packages/shared/security/plugin_types_common/tsconfig.json:2\nx-pack/platform/packages/shared/security/plugin_types_public/tsconfig.json:2\nx-pack/platform/packages/shared/security/plugin_types_server/tsconfig.json:2\nx-pack/platform/plugins/shared/encrypted_saved_objects/README.md:8\nx-pack/platform/plugins/shared/encrypted_saved_objects/jest.config.js:10\nx-pack/platform/plugins/shared/encrypted_saved_objects/tsconfig.json:2\nx-pack/platform/plugins/shared/security/jest.config.js:10\nx-pack/platform/plugins/shared/security/tsconfig.json:2\nx-pack/platform/plugins/shared/spaces/jest.config.js:10\nx-pack/platform/plugins/shared/spaces/tsconfig.json:2\n```\n\n</details>\n\n---------\n\nCo-authored-by: Michael Dokolin <[email protected]>\nCo-authored-by: “jeramysoucy” <[email protected]>\nCo-authored-by: kibanamachine <[email protected]>","sha":"ca5a08db0029d5b9e2cd5139b23a05c5ae09ddad"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Gerard Soldevila <[email protected]>
dokmic
added a commit
that referenced
this pull request
Jan 6, 2025
After merging #202748, #204959, and #201653, all of the properties in some telemetry schemas were moved completely, but `node scripts/telemetry_check --fix` didn't update the `properties` object correctly. Also, in #202748 and #201653, the relocation script changed some paths, confusing them with `@kbn/security-plugin` and `@kbn/cloud-plugin`.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 6, 2025
…#205613) After merging elastic#202748, elastic#204959, and elastic#201653, all of the properties in some telemetry schemas were moved completely, but `node scripts/telemetry_check --fix` didn't update the `properties` object correctly. Also, in elastic#202748 and elastic#201653, the relocation script changed some paths, confusing them with `@kbn/security-plugin` and `@kbn/cloud-plugin`. (cherry picked from commit 5409631)
kibanamachine
added a commit
that referenced
this pull request
Jan 6, 2025
…205613) (#205641) # Backport This will backport the following commits from `main` to `8.x`: - [Sustainable Kibana Architecture: Fix after-relocation issues (#205613)](#205613) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Michael Dokolin","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-06T18:02:36Z","message":"Sustainable Kibana Architecture: Fix after-relocation issues (#205613)\n\nAfter merging #202748, #204959, and #201653, all of the properties in\nsome telemetry schemas were moved completely, but `node\nscripts/telemetry_check --fix` didn't update the `properties` object\ncorrectly.\n\nAlso, in #202748 and #201653, the relocation script changed some paths,\nconfusing them with `@kbn/security-plugin` and `@kbn/cloud-plugin`.","sha":"540963148dc671b02655ced8285dbbd817d9d5c9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:version","v8.18.0","plugin groups"],"title":"Sustainable Kibana Architecture: Fix after-relocation issues","number":205613,"url":"https://github.com/elastic/kibana/pull/205613","mergeCommit":{"message":"Sustainable Kibana Architecture: Fix after-relocation issues (#205613)\n\nAfter merging #202748, #204959, and #201653, all of the properties in\nsome telemetry schemas were moved completely, but `node\nscripts/telemetry_check --fix` didn't update the `properties` object\ncorrectly.\n\nAlso, in #202748 and #201653, the relocation script changed some paths,\nconfusing them with `@kbn/security-plugin` and `@kbn/cloud-plugin`.","sha":"540963148dc671b02655ced8285dbbd817d9d5c9"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205613","number":205613,"mergeCommit":{"message":"Sustainable Kibana Architecture: Fix after-relocation issues (#205613)\n\nAfter merging #202748, #204959, and #201653, all of the properties in\nsome telemetry schemas were moved completely, but `node\nscripts/telemetry_check --fix` didn't update the `properties` object\ncorrectly.\n\nAlso, in #202748 and #201653, the relocation script changed some paths,\nconfusing them with `@kbn/security-plugin` and `@kbn/cloud-plugin`.","sha":"540963148dc671b02655ced8285dbbd817d9d5c9"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Michael Dokolin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.
Important
packages[\/\\]andplugins[\/\\]patterns in the source code (Babel and Eslint config files), and update them appropriately..buildkite/scripts/pipelines/pull_request/pipeline.tsto ensure that any CI pipeline customizations continue to be correctly applied after the changed path names.tsand.jsfiles listed in the sections below, as some of them contain relative paths that have been updated.Note
Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe here.
4 plugin(s) are going to be relocated:
@kbn/encrypted-saved-objects-pluginx-pack/platform/plugins/shared/encrypted_saved_objects@kbn/interactive-setup-pluginsrc/platform/plugins/private/interactive_setup@kbn/security-pluginx-pack/platform/plugins/shared/security@kbn/spaces-pluginx-pack/platform/plugins/shared/spaces14 packages(s) are going to be relocated:
@kbn/cryptosrc/platform/packages/shared/kbn-crypto@kbn/handlebarssrc/platform/packages/private/kbn-handlebars@kbn/safer-lodash-setsrc/platform/packages/shared/kbn-safer-lodash-set@kbn/security-api-key-managementx-pack/platform/packages/shared/security/api_key_management@kbn/security-authorization-corex-pack/platform/packages/private/security/authorization_core@kbn/security-authorization-core-commonx-pack/platform/packages/private/security/authorization_core_common@kbn/security-form-componentsx-pack/platform/packages/shared/security/form_components@kbn/security-hardeningsrc/platform/packages/shared/kbn-security-hardening@kbn/security-plugin-types-commonx-pack/platform/packages/shared/security/plugin_types_common@kbn/security-plugin-types-publicx-pack/platform/packages/shared/security/plugin_types_public@kbn/security-plugin-types-serverx-pack/platform/packages/shared/security/plugin_types_server@kbn/security-role-management-modelx-pack/platform/packages/private/security/role_management_model@kbn/security-ui-componentsx-pack/platform/packages/private/security/ui_components@kbn/user-profile-componentssrc/platform/packages/shared/kbn-user-profile-componentsScript errors
Updated references
Updated relative paths