Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky tests #202289

Merged
merged 3 commits into from
Dec 2, 2024
Merged

fix flaky tests #202289

merged 3 commits into from
Dec 2, 2024

Conversation

juliaElastic
Copy link
Contributor

@juliaElastic juliaElastic commented Nov 29, 2024

Summary

Changes in #201443 with some tweaks

Closes #201210
Closes #200786
Closes #191804
Closes #199204

@juliaElastic juliaElastic marked this pull request as ready for review November 29, 2024 14:20
@juliaElastic juliaElastic requested a review from a team as a code owner November 29, 2024 14:20
@juliaElastic juliaElastic added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 29, 2024
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@juliaElastic juliaElastic enabled auto-merge (squash) December 2, 2024 08:41
@juliaElastic
Copy link
Contributor Author

it seems the flakyness happened again


FAIL  x-pack/plugins/fleet/public/components/package_policy_delete_provider.test.tsx (12.375 s)
--
  | ● PackagePolicyDeleteProvider › Should show delete integrations action and cancel modal
  |  
  | thrown: "Exceeded timeout of 5000 ms for a test.
  | Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
  |  
  | 136 \|
  | 137 \| describe('PackagePolicyDeleteProvider', () => {
  | > 138 \|   it('Should show delete integrations action and cancel modal', async () => {
  | \|   ^
  | 139 \|     useMultipleAgentPoliciesMock.mockReturnValue({ canUseMultipleAgentPolicies: false });
  | 140 \|     sendGetAgentsMock.mockResolvedValue({
  | 141 \|       data: {
  |  
  | at it (x-pack/plugins/fleet/public/components/package_policy_delete_provider.test.tsx:138:3)
  | at Object.describe (x-pack/plugins/fleet/public/components/package_policy_delete_provider.test.tsx:137:1)


@juliaElastic juliaElastic merged commit 16f2d7a into elastic:main Dec 2, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12119147540

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 202289

Questions ?

Please refer to the Backport tool documentation

@juliaElastic juliaElastic added backport:skip This commit does not require backporting and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 2, 2024
@TinaHeiligers
Copy link
Contributor

@juliaElastic the MultipleAgentPolicySummaryLine test failed again. Can you suggest a fix for it in #202748 please?

CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
## Summary

Changes in elastic#201443 with some
tweaks

Closes elastic#201210
Closes elastic#200786
Closes elastic#191804
Closes elastic#199204
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
## Summary

Changes in elastic#201443 with some
tweaks

Closes elastic#201210
Closes elastic#200786
Closes elastic#191804
Closes elastic#199204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment