Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @Mentions #49

Closed
wants to merge 4 commits into from

review comments

1ca285b
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Closed

Add @Mentions #49

review comments
1ca285b
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Oct 26, 2023 in 0s

clippy

11 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 11
Note 0
Help 0

Versions

  • rustc 1.64.0 (a55dd71d5 2022-09-19)
  • cargo 1.64.0 (387270bc7 2022-09-16)
  • clippy 0.1.64 (a55dd71 2022-09-19)

Annotations

Check warning on line 191 in src/parser/link_url.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `char::is_digit` with literal radix of 16 

warning: use of `char::is_digit` with literal radix of 16
   --> src/parser/link_url.rs:191:5
    |
191 |     c.is_digit(16)
    |     ^^^^^^^^^^^^^^ help: try: `c.is_ascii_hexdigit()`
    |
    = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix

Check warning on line 170 in src/parser/link_url.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you are deriving `PartialEq` and can implement `Eq` 

warning: you are deriving `PartialEq` and can implement `Eq`
   --> src/parser/link_url.rs:170:17
    |
170 | #[derive(Debug, PartialEq)]
    |                 ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

Check warning on line 72 in src/parser/parse_from_text/markdown_elements.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using long and hard to read `.bytes().count()` 

warning: using long and hard to read `.bytes().count()`
  --> src/parser/parse_from_text/markdown_elements.rs:72:25
   |
72 |                 .get(0..content.bytes().count().saturating_sub(offset))
   |                         ^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling `.len()` instead: `content.len()`
   |
   = note: `#[warn(clippy::bytes_count_to_len)]` on by default
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_count_to_len

Check warning on line 191 in src/parser/link_url.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `char::is_digit` with literal radix of 16 

warning: use of `char::is_digit` with literal radix of 16
   --> src/parser/link_url.rs:191:5
    |
191 |     c.is_digit(16)
    |     ^^^^^^^^^^^^^^ help: try: `c.is_ascii_hexdigit()`
    |
    = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix

Check warning on line 170 in src/parser/link_url.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you are deriving `PartialEq` and can implement `Eq` 

warning: you are deriving `PartialEq` and can implement `Eq`
   --> src/parser/link_url.rs:170:17
    |
170 | #[derive(Debug, PartialEq)]
    |                 ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

Check warning on line 11 in src/parser/parse_from_text/base_parsers.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you are deriving `PartialEq` and can implement `Eq` 

warning: you are deriving `PartialEq` and can implement `Eq`
  --> src/parser/parse_from_text/base_parsers.rs:11:17
   |
11 | #[derive(Debug, PartialEq)]
   |                 ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
   |
   = note: `#[warn(clippy::derive_partial_eq_without_eq)]` on by default
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

Check warning on line 72 in src/parser/parse_from_text/markdown_elements.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using long and hard to read `.bytes().count()` 

warning: using long and hard to read `.bytes().count()`
  --> src/parser/parse_from_text/markdown_elements.rs:72:25
   |
72 |                 .get(0..content.bytes().count().saturating_sub(offset))
   |                         ^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling `.len()` instead: `content.len()`
   |
   = note: `#[warn(clippy::bytes_count_to_len)]` on by default
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_count_to_len

Check warning on line 11 in src/parser/parse_from_text/base_parsers.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you are deriving `PartialEq` and can implement `Eq` 

warning: you are deriving `PartialEq` and can implement `Eq`
  --> src/parser/parse_from_text/base_parsers.rs:11:17
   |
11 | #[derive(Debug, PartialEq)]
   |                 ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
   |
   = note: `#[warn(clippy::derive_partial_eq_without_eq)]` on by default
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

Check warning on line 191 in src/parser/link_url.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `char::is_digit` with literal radix of 16 

warning: use of `char::is_digit` with literal radix of 16
   --> src/parser/link_url.rs:191:5
    |
191 |     c.is_digit(16)
    |     ^^^^^^^^^^^^^^ help: try: `c.is_ascii_hexdigit()`
    |
    = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix

Check warning on line 170 in src/parser/link_url.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you are deriving `PartialEq` and can implement `Eq` 

warning: you are deriving `PartialEq` and can implement `Eq`
   --> src/parser/link_url.rs:170:17
    |
170 | #[derive(Debug, PartialEq)]
    |                 ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

Check warning on line 11 in src/parser/parse_from_text/base_parsers.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you are deriving `PartialEq` and can implement `Eq` 

warning: you are deriving `PartialEq` and can implement `Eq`
  --> src/parser/parse_from_text/base_parsers.rs:11:17
   |
11 | #[derive(Debug, PartialEq)]
   |                 ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
   |
   = note: `#[warn(clippy::derive_partial_eq_without_eq)]` on by default
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq
View more details on GitHub Actions