Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @Mentions #49

Closed
wants to merge 4 commits into from
Closed

Add @Mentions #49

wants to merge 4 commits into from

Conversation

Simon-Laux
Copy link
Member

@Simon-Laux Simon-Laux commented Oct 14, 2023 •
edited
Loading

start with mentions

Bildschirmfoto 2023-10-14 um 05 26 27
  • add @mentions
    • new Element::Mention{ address: &str }
    • new api extract_mention_addresses to extract

@Simon-Laux Simon-Laux changed the title simon/mentions Add @Mentions Oct 14, 2023
iequidoo
iequidoo reviewed Oct 15, 2023
View reviewed changes
spec.md Show resolved Hide resolved
iequidoo
iequidoo reviewed Oct 25, 2023
View reviewed changes
spec.md Outdated Show resolved Hide resolved
src/parser/parse_from_text/mod.rs Outdated Show resolved Hide resolved
tests/text_to_ast/text_only.rs Outdated Show resolved Hide resolved
@Simon-Laux
Copy link
Member Author

Simon-Laux commented Oct 26, 2023 •
edited
Loading

I think before we merge we need to have a concrete plan to bring this to the UIs soon

@Simon-Laux Simon-Laux mentioned this pull request Jan 3, 2025
Closed
@Simon-Laux
Copy link
Member Author

let's put this to project resurrection until we know more. for now we don't parse it, neither as email address, nor fediverse address, nor mention: #84

@Simon-Laux Simon-Laux closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iequidoo iequidoo iequidoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Project Resurrection
Status: Closed PRs and Issues
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Simon-Laux @iequidoo