Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update constants.ts for SP2025 #919

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Update constants.ts for SP2025 #919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
642a5ca
Set current semester to SP25 with start date 1/15 and end date 5/18
NIDHI2023 Jan 20, 2025
9adc43c
commented out wrapped for safety
NIDHI2023 Jan 20, 2025
b95f247
fix lint warnings
NIDHI2023 Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/components/pages/SplitView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ import smsNotif from "../../media/smsNotif.svg";
import { addBanner } from "../../redux/actions/announcements";
import Banner from "../includes/Banner";
import FeedbackPrompt from "../includes/FeedbackPrompt";
import Wrapped from "../includes/Wrapped";
import WrappedCountdown from "../includes/WrappedCountdown";
import { WRAPPED_START_DATE, WRAPPED_LAUNCH_DATE } from "../../constants";
// import Wrapped from "../includes/Wrapped";
// import WrappedCountdown from "../includes/WrappedCountdown";
// import { WRAPPED_START_DATE, WRAPPED_LAUNCH_DATE } from "../../constants";

// Also update in the main LESS file
const MOBILE_BREAKPOINT = 920;
Expand Down Expand Up @@ -86,8 +86,8 @@ const SplitView = ({

const [removeQuestionId, setRemoveQuestionId] = useState<string | undefined>(undefined);
const [displayFeedbackPrompt, setDisplayFeedbackPrompt] = useState<boolean>(false);
const [displayWrapped, setDisplayWrapped] = useState<boolean>(false);
const [countdownZero, setCountdownZero] = useState<boolean>(false);
// const [displayWrapped, setDisplayWrapped] = useState<boolean>(false);
// const [countdownZero, setCountdownZero] = useState<boolean>(false);
const [removedQuestionId, setRemovedQuestionId] = useState<string | undefined>(undefined);
const [showCalendarModal, setShowCalendarModal] = useState<boolean>(false);
const [isDayExport, setIsDayExport] = useState<boolean>(false);
Expand Down Expand Up @@ -189,8 +189,8 @@ const SplitView = ({
}
}, [addBanner, user]);

const start = new Date(WRAPPED_START_DATE);
const launch = new Date(WRAPPED_LAUNCH_DATE);
// const start = new Date(WRAPPED_START_DATE);
// const launch = new Date(WRAPPED_LAUNCH_DATE);

return (
<>
Expand All @@ -200,8 +200,8 @@ const SplitView = ({
context="student"
courseId={match.params.courseId}
course={course}
countdownZero={countdownZero}
setDisplayWrapped={setDisplayWrapped}
// countdownZero={countdownZero}
// setDisplayWrapped={setDisplayWrapped}
/>
{banners.map((banner, index) => (
<Banner
Expand Down Expand Up @@ -270,21 +270,21 @@ const SplitView = ({
<Loader active={true} content="Loading" />
))}
<ProductUpdates />
{user && user.wrapped ? (
{/* {user && user.wrapped ? (
<WrappedCountdown
setDisplayWrapped={setDisplayWrapped}
setCountdownZero={setCountdownZero}
wrappedDate={{ launchDate: launch, startDate: start }}
/>
) : null}
) : null} */}
{displayFeedbackPrompt ? (
<FeedbackPrompt
onClose={submitFeedback(removedQuestionId, course, session.sessionId)}
closeFeedbackPrompt={() => setDisplayFeedbackPrompt(false)}
/>
) : null}

{displayWrapped ? <Wrapped user={user} onClose={() => setDisplayWrapped(false)} /> : null}
{/* {displayWrapped ? <Wrapped user={user} onClose={() => setDisplayWrapped(false)} /> : null} */}
</>
);
};
Expand Down
12 changes: 6 additions & 6 deletions src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
export const CURRENT_SEMESTER = 'FA24';
export const CURRENT_SEMESTER = 'SP25';
export const ALL_SEMESTERS = ['SP20', 'FA20', 'SP21', 'FA21', 'SP22', 'FA22',
'SP23', 'FA23', 'SP24', 'FA24']
'SP23', 'FA23', 'SP24', 'FA24', 'SP25']

export const START_DATE = '2024-08-19'
export const END_DATE = '2024-12-20'
export const START_DATE = '2025-01-15'
export const END_DATE = '2025-05-18'

// These are the start date and launch date for QMI Wrap for the current semester
export const WRAPPED_START_DATE = "2024-11-12T00:00:00";
export const WRAPPED_LAUNCH_DATE = "2024-11-22T00:00:00";
export const WRAPPED_START_DATE = "2025-11-12T00:00:00";
export const WRAPPED_LAUNCH_DATE = "2025-11-22T00:00:00";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure this is the most maintainable way to hide wrapped – i feel like we could very easily forget about this and have it auto appear or smtg 11/2025

Loading