Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update constants.ts for SP2025 #919

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Update constants.ts for SP2025 #919

merged 3 commits into from
Jan 20, 2025

Conversation

NIDHI2023
Copy link
Contributor

Summary

Set current semester to SP25 with start date 1/15 and end date 5/18. Also changed wrapped start/end date to remove visibility on home page

Test Plan

  • Wrapped not visible
  • Only sp 25 classes available to select

Notes

Breaking Changes

None

  • I have updated the documentation accordingly.
  • My PR adds a @ts-ignore

- also changed wrapped start/end date to remove visibility
@NIDHI2023 NIDHI2023 requested a review from a team as a code owner January 20, 2025 02:50
@dti-github-bot
Copy link
Member

dti-github-bot commented Jan 20, 2025

[diff-counting] Significant lines: 36.


// These are the start date and launch date for QMI Wrap for the current semester
export const WRAPPED_START_DATE = "2024-11-12T00:00:00";
export const WRAPPED_LAUNCH_DATE = "2024-11-22T00:00:00";
export const WRAPPED_START_DATE = "2025-11-12T00:00:00";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure this is the most maintainable way to hide wrapped – i feel like we could very easily forget about this and have it auto appear or smtg 11/2025

@NIDHI2023 NIDHI2023 merged commit fe8f8d0 into master Jan 20, 2025
4 checks passed
@NIDHI2023 NIDHI2023 deleted the sp25-setup branch January 20, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants