fix for setting options for InAppBrowser instance #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olawalle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This fix helps users set the options they want for the in-app-browser instance.
I found this default object to be sufficient for users:
let options: InAppBrowserOptions = {
location: 'yes',
hideurlbar: 'yes',
lefttoright: 'no',
hidenavigationbuttons: 'yes',
},
also the rave.render method will be updated to take an extra parameter(options) which is the inappbrpwseroptions object created.
It hides the url bar while keeping the close button in case clients want to close the browser.
This can be added to the documentation as a guide for users.
Thanks.