tests: remove NTP service on Xenial #14905
Open
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The auto-refresh tests and the degraded test were all failing. The former happened because chrony sometimes failed to run and the latter because ntp.service conflicted with chrony. Removing ntp and leaving chrony fixes both issues. Signed-off-by: Miguel Pires <[email protected]>
miguelpires
force-pushed
the
fix-ntp-sync
branch
from
324956b to
d66a330
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14905 +/- ##
==========================================
+ Coverage 78.20% 78.24% +0.04%
==========================================
Files 1151 1150 -1
Lines 151396 152777 +1381
==========================================
+ Hits 118402 119547 +1145
- Misses 25662 25851 +189
- Partials 7332 7379 +47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bboozzoo
approved these changes
Jan 8, 2025
Signed-off-by: Miguel Pires <[email protected]>
ernestl
approved these changes
Jan 8, 2025
maykathm
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auto-refresh tests and the degraded test were failing due to conflicts between chrony.service and ntp.service. The former happened because chrony sometimes failed to run and the latter because ntp.service conflicted with chrony and the unit would be marked as failed. Removing ntp and leaving chrony fixes both issues.
If merged this replaces #14888
Fixes: