tests: ensure chrony syncs time before tests #14888
Closed
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14888 +/- ##
==========================================
+ Coverage 78.20% 78.30% +0.10%
==========================================
Files 1151 1153 +2
Lines 151396 152626 +1230
==========================================
+ Hits 118402 119517 +1115
- Misses 25662 25743 +81
- Partials 7332 7366 +34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This fixes tests running on 16.04 that rely on forcing auto-refreshes. These were failing because 16.04 uses chrony which wasn't being run. Since the auto-refresh manager waits for an NTP sync (times out after a while but too late for testing purposes), the auto-refreshes were never triggered and the tests failed. ``` - google:ubuntu-16.04-64:tests/main/auto-refresh-backoff - google:ubuntu-16.04-64:tests/main/auto-refresh-gating-from-snap - google:ubuntu-16.04-64:tests/main/auto-refresh-pre-download:close - google:ubuntu-16.04-64:tests/main/auto-refresh-pre-download:close_mid_restart - google:ubuntu-16.04-64:tests/main/auto-refresh-pre-download:ignore - google:ubuntu-16.04-64:tests/main/auto-refresh-retry - google:ubuntu-16.04-64:tests/main/auto-refresh:regular - google:ubuntu-16.04-64:tests/main/snap-refresh-hold - google:ubuntu-16.04-64:tests/main/snapd-state ``` Signed-off-by: Miguel Pires <[email protected]>
miguelpires
force-pushed
the
fix-autorefresh-tests
branch
from
35f2de7 to
4222189
Compare
|
While investigating a different spread failure, I got some for information about the root cause of this issue. This might be replaced by another PR that fixes other tests as well, marking as Blocked for now |
|
replaced by #14905 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes tests running on 16.04 that rely on forcing auto-refreshes. These were failing because on Xenial chrony would sometimes exit without synchronizing time (unsure why at the moment). Since the auto-refresh manager waits for an NTP sync (times out after a while but too late for testing purposes), the auto-refreshes were never triggered and the tests failed.