-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(24.10): Add SDF for libavcodec61
and dependencies
#442
Open
HadrienPatte
wants to merge
4
commits into
canonical:ubuntu-24.10
Choose a base branch
from
HadrienPatte:24.10/libavcodec61
base: ubuntu-24.10
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(24.10): Add SDF for libavcodec61
and dependencies
#442
HadrienPatte
wants to merge
4
commits into
canonical:ubuntu-24.10
from
HadrienPatte:24.10/libavcodec61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Diff of dependencies: slices/libavcodec61.yaml@@ -11,7 +11,6 @@
libmp3lame0
libopenjp2-7
libopus0
-librav1e0.7
librsvg2-2
libshine3
libsnappy1v5
@@ -23,7 +22,6 @@
libva2
libvorbis0a
libvorbisenc2
-libvpl2
libvpx9
libwebp7
libwebpmux3 slices/libavutil59.yaml@@ -1,11 +1,8 @@
libc6
libdrm2
-libopencl-1.2-1
-libopencl1
libva-drm2
libva-x11-2
libva2
libvdpau1
-libvpl2
libx11-6
ocl-icd-libopencl1 slices/libvdpau1.yaml@@ -1,3 +1,4 @@
libc6
+libgcc-s1
libx11-6
libxext6 |
HadrienPatte
commented
Dec 25, 2024
HadrienPatte
force-pushed
the
24.10/libavcodec61
branch
3 times, most recently
from
December 25, 2024 21:09
b4f1838
to
625ce5d
Compare
HadrienPatte
force-pushed
the
24.10/libavcodec61
branch
from
December 25, 2024 21:48
625ce5d
to
d999073
Compare
cjdcordeiro
reviewed
Jan 6, 2025
cjdcordeiro
requested changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
It's looking good. I think we could just use a couple of tests.
cjdcordeiro
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the missing tests. LGTM ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add SDF for
libavcodec61
and dependencies.See canonical/chisel#93 (comment) for the dependencies diff.
Related issues/PRs
24.04 PR: #441
Forward porting
Checklist
Additional Context