Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(24.04): Add SDF for libavcodec60 and dependencies #441

Open
wants to merge 3 commits into
base: ubuntu-24.04
Choose a base branch
from

Conversation

HadrienPatte
Copy link
Contributor

@HadrienPatte HadrienPatte commented Dec 25, 2024

Proposed changes

Add SDF for libavcodec60 and dependencies.

See canonical/chisel#93 (comment) for the dependencies diff.

Related issues/PRs

Forward porting

24.10 PR: #442

Checklist

Additional Context

Copy link

github-actions bot commented Dec 25, 2024

Diff of dependencies:

slices/libavcodec60.yaml
@@ -11,7 +11,6 @@
 libmp3lame0
 libopenjp2-7
 libopus0
-librav1e0
 librsvg2-2
 libshine3
 libsnappy1v5
@@ -23,7 +22,6 @@
 libva2
 libvorbis0a
 libvorbisenc2
-libvpl2
 libvpx9
 libwebp7
 libwebpmux3
slices/libavutil58.yaml
@@ -1,11 +1,8 @@
 libc6
 libdrm2
-libopencl-1.2-1
-libopencl1
 libva-drm2
 libva-x11-2
 libva2
 libvdpau1
-libvpl2
 libx11-6
 ocl-icd-libopencl1
slices/libvdpau1.yaml
@@ -1,3 +1,4 @@
 libc6
+libgcc-s1
 libx11-6
 libxext6

Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Tyvm!

@cjdcordeiro cjdcordeiro requested a review from a team January 6, 2025 10:56
Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slices are quite nice, thank you!

I left a few simple comments below.

Comment on lines +22 to +24
# The librav1e0_libs dependency is currently ommited, it can be added again
# once chisel supports per-arch package dependencies,
# see https://github.com/canonical/chisel/issues/93
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice comment, thank you. Would you kindly also include which architecture(s) requires the slice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 07333dc

Comment on lines +36 to +38
# The libvpl2_libs dependency is currently ommited, it can be added again
# once chisel supports per-arch package dependencies,
# see https://github.com/canonical/chisel/issues/93
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Same as above)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 07333dc

Comment on lines +15 to +17
# The libvpl2_libs dependency is currently ommited, it can be added again
# once chisel supports per-arch package dependencies,
# see https://github.com/canonical/chisel/issues/93
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Same as above)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 07333dc

slices/libavutil58.yaml Show resolved Hide resolved
libs:
essential:
- libc6_libs
- libgcc-s1_libs # armhf only
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- libgcc-s1_libs # armhf only
- libgcc-s1_libs # needed for armhf only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants