-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(24.04): Add SDF for libavcodec60
and dependencies
#441
base: ubuntu-24.04
Are you sure you want to change the base?
feat(24.04): Add SDF for libavcodec60
and dependencies
#441
Conversation
Diff of dependencies: slices/libavcodec60.yaml@@ -11,7 +11,6 @@
libmp3lame0
libopenjp2-7
libopus0
-librav1e0
librsvg2-2
libshine3
libsnappy1v5
@@ -23,7 +22,6 @@
libva2
libvorbis0a
libvorbisenc2
-libvpl2
libvpx9
libwebp7
libwebpmux3 slices/libavutil58.yaml@@ -1,11 +1,8 @@
libc6
libdrm2
-libopencl-1.2-1
-libopencl1
libva-drm2
libva-x11-2
libva2
libvdpau1
-libvpl2
libx11-6
ocl-icd-libopencl1 slices/libvdpau1.yaml@@ -1,3 +1,4 @@
libc6
+libgcc-s1
libx11-6
libxext6 |
bc89ce4
to
45ce60d
Compare
45ce60d
to
e0b01ce
Compare
e0b01ce
to
59b0cd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Tyvm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slices are quite nice, thank you!
I left a few simple comments below.
# The librav1e0_libs dependency is currently ommited, it can be added again | ||
# once chisel supports per-arch package dependencies, | ||
# see https://github.com/canonical/chisel/issues/93 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice comment, thank you. Would you kindly also include which architecture(s) requires the slice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in 07333dc
# The libvpl2_libs dependency is currently ommited, it can be added again | ||
# once chisel supports per-arch package dependencies, | ||
# see https://github.com/canonical/chisel/issues/93 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Same as above)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in 07333dc
# The libvpl2_libs dependency is currently ommited, it can be added again | ||
# once chisel supports per-arch package dependencies, | ||
# see https://github.com/canonical/chisel/issues/93 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Same as above)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in 07333dc
slices/libvdpau1.yaml
Outdated
libs: | ||
essential: | ||
- libc6_libs | ||
- libgcc-s1_libs # armhf only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- libgcc-s1_libs # armhf only | |
- libgcc-s1_libs # needed for armhf only |
Proposed changes
Add SDF for
libavcodec60
and dependencies.See canonical/chisel#93 (comment) for the dependencies diff.
Related issues/PRs
Forward porting
24.10 PR: #442
Checklist
Additional Context