-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(22.04): add LXD backend to Spread #316
test(22.04): add LXD backend to Spread #316
Conversation
Diff of dependencies: |
The test there seems to fail on ARM64. And logs are expired probably. Could you please re-trigger it? |
Yes, cause that's my fork. arm runners aren't available to non-enterprise accounts. Added a note in the description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look alright to me. Holding approval until #317 is merged and the tests are passing properly here.
2f2426f
to
350ba6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you. The diffs to the merged 24.04 changes are concise.
Diff with merged 24.04 changes
diff --git a/spread.yaml b/spread.yaml
index b2bb3b9..bdc21c6 100644
--- a/spread.yaml
+++ b/spread.yaml
@@ -38,9 +38,11 @@ backends:
ADDRESS `lxc list --format=json $SPREAD_SYSTEM | jq -r '.[0].state.network.eth0.addresses[] | select(.family=="inet") | .address'`
discard: lxc stop $SPREAD_SYSTEM || true
systems:
- - ubuntu-noble:
+ - ubuntu-jammy:
password: ubuntu
-
+
+ # The Docker backend is recommended for comprehensive multi-arch tests, but
+ # not ideal for tests that need to perform privileged operations (like "mount").
docker:
type: adhoc
allocate: |
@@ -68,17 +70,17 @@ backends:
ADDRESS `docker inspect $SPREAD_SYSTEM --format '{{.NetworkSettings.Networks.bridge.IPAddress}}'`
discard: docker rm -f $SPREAD_SYSTEM
systems:
- - ubuntu-24.04-amd64:
+ - ubuntu-22.04-amd64:
password: ubuntu
- - ubuntu-24.04-arm64v8:
+ - ubuntu-22.04-arm64v8:
password: ubuntu
- - ubuntu-24.04-arm32v7:
+ - ubuntu-22.04-arm32v7:
password: ubuntu
- - ubuntu-24.04-ppc64le:
+ - ubuntu-22.04-ppc64le:
password: ubuntu
- - ubuntu-24.04-s390x:
+ - ubuntu-22.04-s390x:
password: ubuntu
- - ubuntu-24.04-riscv64:
+ - ubuntu-22.04-riscv64:
password: ubuntu
prepare: |
Co-authored-by: Rafid Bin Mostofa <[email protected]>
--------- Co-authored-by: Rafid Bin Mostofa <[email protected]>
Proposed changes
Used LXD as a Spread backend instead of docker. This is to cope with tests that need to perform privileged operations (like
mount
).Related issues/PRs
#274 #222
Checklist
Additional Context
See a test here: https://github.com/cjdcordeiro/chisel-releases/actions/runs/10492345808/job/29063655589?pr=17 (note, the ARM64 tests fail cause this is my fork, under my account, which doesn't have access to arm64 runners)
Needs #317 for the CI to pass