-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(24.04): add LXD backend to Spread #318
test(24.04): add LXD backend to Spread #318
Conversation
Diff of dependencies: |
@Meulengracht can you please check if this fixes your privileged tests? (use |
lxd fails to come up, it's stuck doing |
@Meulengracht but can you even launch an lxd instance outside spread? If you do |
Yea it works just fine - I use lxd for multiple purposes |
And when you say it's stuck, does it timeout? Note that LXD will first pull/refresh the image, which could take a while depending on your connection. If you do the |
Isn't that because this PR needs #317? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sorry for the incredibly slow reply here - So I looked a bit more into this, it seems that
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a suggestion for improvement. That fixed it for me
Co-authored-by: Philip Meulengracht <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Hope it works! 🤞
(same as #316 , for 24.04)