Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(24.04): add LXD backend to Spread #318

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

cjdcordeiro
Copy link
Collaborator

(same as #316 , for 24.04)

@cjdcordeiro cjdcordeiro requested review from rebornplusplus and a team August 22, 2024 06:52
Copy link

Diff of dependencies:
None found.


@cjdcordeiro
Copy link
Collaborator Author

@Meulengracht can you please check if this fixes your privileged tests? (use spread lxd)

@cjdcordeiro cjdcordeiro added the Blocked Waiting for something external label Aug 22, 2024
@cjdcordeiro cjdcordeiro changed the title test: add LXD backend to Spread test(24.04): add LXD backend to Spread Aug 22, 2024
@Meulengracht
Copy link
Member

@Meulengracht can you please check if this fixes your privileged tests? (use spread lxd)

lxd fails to come up, it's stuck doing lxc exec ubuntu-noble -- pgrep sshd

@cjdcordeiro
Copy link
Collaborator Author

@Meulengracht but can you even launch an lxd instance outside spread? If you do lxd launch ubuntu:24.04 u1, will it come up?

@Meulengracht
Copy link
Member

@Meulengracht but can you even launch an lxd instance outside spread? If you do lxd launch ubuntu:24.04 u1, will it come up?

Yea it works just fine - I use lxd for multiple purposes

@cjdcordeiro
Copy link
Collaborator Author

And when you say it's stuck, does it timeout? Note that LXD will first pull/refresh the image, which could take a while depending on your connection.

If you do the lxc launch... I mentioned above and then spread lxd, will it still get stuck?

@linostar
Copy link

And when you say it's stuck, does it timeout? Note that LXD will first pull/refresh the image, which could take a while depending on your connection.

If you do the lxc launch... I mentioned above and then spread lxd, will it still get stuck?

Isn't that because this PR needs #317?

Copy link

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Meulengracht
Copy link
Member

Meulengracht commented Aug 27, 2024

And when you say it's stuck, does it timeout? Note that LXD will first pull/refresh the image, which could take a while depending on your connection.

If you do the lxc launch... I mentioned above and then spread lxd, will it still get stuck?

Sorry for the incredibly slow reply here - So I looked a bit more into this, it seems that sshd does not come up, it tells me the service unit does not exist. The container is running fine, and I can shell into it.

root@ubuntu-noble:~# systemctl status sshd
Unit sshd.service could not be found.

Copy link
Member

@Meulengracht Meulengracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion for improvement. That fixed it for me

spread.yaml Outdated Show resolved Hide resolved
@cjdcordeiro cjdcordeiro added Priority Look at me first and removed Blocked Waiting for something external labels Aug 28, 2024
Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Hope it works! 🤞

@cjdcordeiro cjdcordeiro self-assigned this Aug 28, 2024
@cjdcordeiro cjdcordeiro merged commit b80a9c4 into canonical:ubuntu-24.04 Aug 28, 2024
14 checks passed
@cjdcordeiro cjdcordeiro deleted the spread-lxd-noble branch August 28, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority Look at me first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants