Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react updates #885

Merged
merged 11 commits into from
Jan 10, 2025
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { useState } from "react"
import reactLogo from "./assets/react.svg"
import viteLogo from "./assets/vite.svg"
import "./App.css"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -solution folders are meant to be the state of the app after completing the exercise, so at this point, this import still exists and should be left in.


function App() {
const [count, setCount] = useState(0)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { useState } from "react"
import reactLogo from "./assets/react.svg"
import viteLogo from "./assets/vite.svg"
import "./App.css"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, this should be left in.


function App() {
const [count, setCount] = useState(0)
Expand Down
2 changes: 0 additions & 2 deletions exercises/react-vite/03-intro-to-jsx/01-problem/src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import "./App.css"

function App() {
return (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a disparity between the previous solution:

And this function App() line. I wonder which we’re meant to have? cc @rjspencer

<>
Expand Down
2 changes: 0 additions & 2 deletions exercises/react-vite/03-intro-to-jsx/01-solution/src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import "./App.css"

function App() {
return (
<>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import CheeseThumbnail from "place-my-order-assets/images/2-thumbnail.jpg"
import PoutineThumbnail from "place-my-order-assets/images/4-thumbnail.jpg"
import "./App.css"

function App() {
const restaurants = {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import CheeseThumbnail from "place-my-order-assets/images/2-thumbnail.jpg"
import PoutineThumbnail from "place-my-order-assets/images/4-thumbnail.jpg"
import "./App.css"

function App() {
const restaurants = {
Expand Down
1 change: 0 additions & 1 deletion exercises/react-vite/04-components/01-problem/src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import CheeseThumbnail from "place-my-order-assets/images/2-thumbnail.jpg"
import PoutineThumbnail from "place-my-order-assets/images/4-thumbnail.jpg"
import RestaurantList from "./pages/RestaurantList"
import "./App.css"

function App() {
const restaurants = {
Expand Down
1 change: 0 additions & 1 deletion exercises/react-vite/06-routing/01-problem/src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { Outlet } from "react-router-dom"
import RestaurantList from "./pages/RestaurantList"
import "./App.css"

function App() {
return (
Expand Down
1 change: 0 additions & 1 deletion exercises/react-vite/06-routing/01-solution/src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Outlet } from "react-router-dom"
import "./App.css"

function App() {
return (
Expand Down
1 change: 0 additions & 1 deletion exercises/react-vite/06-routing/02-problem/src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
return (
Expand Down
1 change: 0 additions & 1 deletion exercises/react-vite/06-routing/02-solution/src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"version": "0.0.0",
"type": "module",
"scripts": {
"api":"./node_modules/.bin/place-my-order-api -p 7070",
"typecheck": "tsc",
"eslint": "eslint vite.config.ts src",
"prettier": "prettier --check vite.config.ts src",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"version": "0.0.0",
"type": "module",
"scripts": {
"api":"./node_modules/.bin/place-my-order-api -p 7070",
"typecheck": "tsc",
"eslint": "eslint vite.config.ts src",
"prettier": "prettier --check vite.config.ts src",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"version": "0.0.0",
"type": "module",
"scripts": {
"api":"./node_modules/.bin/place-my-order-api -p 7070",
"typecheck": "tsc",
"eslint": "eslint vite.config.ts src",
"prettier": "prettier --check vite.config.ts src",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"version": "0.0.0",
"type": "module",
"scripts": {
"api":"./node_modules/.bin/place-my-order-api -p 7070",
"typecheck": "tsc",
"eslint": "eslint vite.config.ts src",
"prettier": "prettier --check vite.config.ts src",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"version": "0.0.0",
"type": "module",
"scripts": {
"api":"./node_modules/.bin/place-my-order-api -p 7070",
"typecheck": "tsc",
"eslint": "eslint vite.config.ts src",
"prettier": "prettier --check vite.config.ts src",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"version": "0.0.0",
"type": "module",
"scripts": {
"api":"./node_modules/.bin/place-my-order-api -p 7070",
"typecheck": "tsc",
"eslint": "eslint vite.config.ts src",
"prettier": "prettier --check vite.config.ts src",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"version": "0.0.0",
"type": "module",
"scripts": {
"api":"./node_modules/.bin/place-my-order-api -p 7070",
"typecheck": "tsc",
"eslint": "eslint vite.config.ts src",
"prettier": "prettier --check vite.config.ts src",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"version": "0.0.0",
"type": "module",
"scripts": {
"api":"./node_modules/.bin/place-my-order-api -p 7070",
"typecheck": "tsc",
"eslint": "eslint vite.config.ts src",
"prettier": "prettier --check vite.config.ts src",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"version": "0.0.0",
"type": "module",
"scripts": {
"api":"./node_modules/.bin/place-my-order-api -p 7070",
"typecheck": "tsc",
"eslint": "eslint vite.config.ts src",
"prettier": "prettier --check vite.config.ts src",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"version": "0.0.0",
"type": "module",
"scripts": {
"api":"./node_modules/.bin/place-my-order-api -p 7070",
"typecheck": "tsc",
"eslint": "eslint vite.config.ts src",
"prettier": "prettier --check vite.config.ts src",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"version": "0.0.0",
"type": "module",
"scripts": {
"api":"./node_modules/.bin/place-my-order-api -p 7070",
"typecheck": "tsc",
"eslint": "eslint vite.config.ts src",
"prettier": "prettier --check vite.config.ts src",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"version": "0.0.0",
"type": "module",
"scripts": {
"api":"./node_modules/.bin/place-my-order-api -p 7070",
"typecheck": "tsc",
"eslint": "eslint vite.config.ts src",
"prettier": "prettier --check vite.config.ts src",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"version": "0.0.0",
"type": "module",
"scripts": {
"api":"./node_modules/.bin/place-my-order-api -p 7070",
"typecheck": "tsc",
"eslint": "eslint vite.config.ts src",
"prettier": "prettier --check vite.config.ts src",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"version": "0.0.0",
"type": "module",
"scripts": {
"api":"./node_modules/.bin/place-my-order-api -p 7070",
"typecheck": "tsc",
"eslint": "eslint vite.config.ts src",
"prettier": "prettier --check vite.config.ts src",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"version": "0.0.0",
"type": "module",
"scripts": {
"api":"./node_modules/.bin/place-my-order-api -p 7070",
"typecheck": "tsc",
"eslint": "eslint vite.config.ts src",
"prettier": "prettier --check vite.config.ts src",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
1 change: 1 addition & 0 deletions exercises/react-vite/12-testing/01-problem/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"version": "0.0.0",
"type": "module",
"scripts": {
"api":"./node_modules/.bin/place-my-order-api -p 7070",
"typecheck": "tsc",
"eslint": "eslint vite.config.ts src",
"prettier": "prettier --check vite.config.ts src",
Expand Down
1 change: 0 additions & 1 deletion exercises/react-vite/12-testing/01-problem/src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
1 change: 1 addition & 0 deletions exercises/react-vite/12-testing/01-solution/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"version": "0.0.0",
"type": "module",
"scripts": {
"api":"./node_modules/.bin/place-my-order-api -p 7070",
"typecheck": "tsc",
"eslint": "eslint vite.config.ts src",
"prettier": "prettier --check vite.config.ts src",
Expand Down
1 change: 0 additions & 1 deletion exercises/react-vite/12-testing/01-solution/src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
1 change: 1 addition & 0 deletions exercises/react-vite/12-testing/02-problem/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"version": "0.0.0",
"type": "module",
"scripts": {
"api":"./node_modules/.bin/place-my-order-api -p 7070",
"typecheck": "tsc",
"eslint": "eslint vite.config.ts src",
"prettier": "prettier --check vite.config.ts src",
Expand Down
1 change: 0 additions & 1 deletion exercises/react-vite/12-testing/02-problem/src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Link, Outlet, useMatch } from "react-router-dom"
import "./App.css"

function App() {
const homeMatch = useMatch("/")
Expand Down
Loading
Loading