-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react updates #885
react updates #885
Changes from 10 commits
a400a2f
e8536ea
8c5104c
4f8140a
19a84af
ee58339
7b7bf48
ca3451a
d681dd5
9c2daa2
bfdd421
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,6 @@ | ||
import { useState } from "react" | ||
import reactLogo from "./assets/react.svg" | ||
import viteLogo from "./assets/vite.svg" | ||
import "./App.css" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here, this should be left in. |
||
|
||
function App() { | ||
const [count, setCount] = useState(0) | ||
|
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
@@ -1,5 +1,3 @@ | ||||
import "./App.css" | ||||
|
||||
function App() { | ||||
return ( | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have a disparity between the previous solution: academy/exercises/react-vite/02-setting-up-your-environment/04-solution/src/App.tsx Line 1 in 272cfb0
And this |
||||
<> | ||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
import "./App.css" | ||
|
||
function App() { | ||
return ( | ||
<> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
import { Outlet } from "react-router-dom" | ||
import "./App.css" | ||
|
||
function App() { | ||
return ( | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
import { Link, Outlet, useMatch } from "react-router-dom" | ||
import "./App.css" | ||
|
||
function App() { | ||
return ( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
-solution
folders are meant to be the state of the app after completing the exercise, so at this point, this import still exists and should be left in.