react updates #885
react updates #885
Conversation
src/react-vite/02-setting-up-your-environment/setting-up-your-environment.md
Outdated
Show resolved
Hide resolved
src/react-vite/02-setting-up-your-environment/setting-up-your-environment.md
Outdated
Show resolved
Hide resolved
src/react-vite/02-setting-up-your-environment/setting-up-your-environment.md
Outdated
Show resolved
Hide resolved
| @@ -191,7 +198,7 @@ Remove these generated files that we won’t need. Some projects do need them, b | |||
| - `src/assets` | |||
| - `src/App.css` | |||
| - `tsconfig.node.json` | |||
| - `.eslintrc.cjs` | |||
| - `.eslintrc.cjs` or `eslint.config.js` | |||
|
|
|||
| ✏️ Uninstall unneeded packages and Install our eslint config and prettier: | |||
There was a problem hiding this comment.
In the future, we should split this into two commands so it’s more clear and easier to copy/paste.
| @@ -165,9 +165,9 @@ Before we begin requesting data from our API, we need to install the `place-my-o | |||
| npm install place-my-order-api@1 | |||
| ``` | |||
|
|
|||
| ✏️ Next add an API script to your `package.json` | |||
| ✏️ Next add an API script to your `package.json`. NOTE: if on windows, change `/` to `\\`. | |||
There was a problem hiding this comment.
Two nits:
Next add->Next, addwindows->Windows
And actually, do we need the ./node_modules/.bin/ in the command? Then we wouldn’t need the extra instructions for Windows.
| @@ -1,7 +1,6 @@ | |||
| import { useState } from "react" | |||
| import reactLogo from "./assets/react.svg" | |||
| import viteLogo from "./assets/vite.svg" | |||
| import "./App.css" | |||
There was a problem hiding this comment.
The -solution folders are meant to be the state of the app after completing the exercise, so at this point, this import still exists and should be left in.
| @@ -1,7 +1,6 @@ | |||
| import { useState } from "react" | |||
| import reactLogo from "./assets/react.svg" | |||
| import viteLogo from "./assets/vite.svg" | |||
| import "./App.css" | |||
There was a problem hiding this comment.
Same here, this should be left in.
| @@ -1,5 +1,3 @@ | |||
| import "./App.css" | |||
|
|
|||
| function App() { | |||
There was a problem hiding this comment.
We have a disparity between the previous solution:
And this function App() line. I wonder which we’re meant to have? cc @rjspencer
| @@ -4,6 +4,7 @@ | |||
| "version": "0.0.0", | |||
| "type": "module", | |||
| "scripts": { | |||
| "api":"./node_modules/.bin/place-my-order-api -p 7070", | |||
There was a problem hiding this comment.
"api":" -> "api": " (here and everywhere else)
No description provided.