library: debug log parsed queries (and convert to f-strings) #4962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampsyo
approved these changes
Oct 21, 2023
There was a problem hiding this comment.
Very good idea! This also helps with the other "direction" I sometimes run into: I can remember the text query syntax, but I can't remember how to construct that query programmatically. With beet -vv ls whatever, now I can get a reminder.
Looks right to me, modulo one linter hint about a long line.
|
(Oh, and I also meant to say thanks for the |
wisp3rwind
force-pushed
the
log_parsed_query
branch
2 times, most recently
from
d828f99 to
1b65eca
Compare
to help with debugging queries that behave unexpectedly
wisp3rwind
force-pushed
the
log_parsed_query
branch
from
1b65eca to
979e71d
Compare
This was referenced Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help with debugging queries that behave unexpectedly. Not sure whether this is really going to be helpful, but while looking at #4955 I realized I would like to know exactly what the queries parse to, because to be honest, I never remember the details our query syntax.