Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix formatting_check CI config #4970

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Conversation

wisp3rwind
Copy link
Member

cf. #4654, the formatting_check.yml is invalid and never runs, immediately aborting on parsing this configuration file.

@wisp3rwind
Copy link
Member Author

@Serene-Arc do we actually need the pox GH action? In our main CI config, as far as I can tell, we just directly execute tox. pox also seems to be essentially unmaintained (although that might not be a problem in principle; maybe this is really just done and doesn't require much maintenance). However, it does trigger some deprecation warnings, cf. https://github.com/beetbox/beets/actions/runs/6602808494

@wisp3rwind wisp3rwind merged commit 8733ea9 into beetbox:master Oct 22, 2023
13 checks passed
@wisp3rwind wisp3rwind deleted the fix_ci_config branch October 22, 2023 09:14
@Serene-Arc
Copy link
Contributor

@wisp3rwind probably not? I didn't realise the action was broken, sorry for that. I tried to keep it as close to the existing one as possible. It's likely that no, we don't need it.

@wisp3rwind
Copy link
Member Author

@wisp3rwind probably not? I didn't realise the action was broken, sorry for that. I tried to keep it as close to the existing one as possible. It's likely that no, we don't need it.

No problem; I was just a little confused about the CI failures I got for #4962 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants