feat: WiP support for python 3.12 #31759
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
github-actions
bot
added
the
github_actions
mistercrunch
force-pushed
the
python312
branch
2 times, most recently
from
fea3210 to
d3654cb
Compare
mistercrunch
changed the title
|
In our app, to upgrade Pandas to 2.2.3 and still work with SQLAlchemy 1.4.x, we had to change the way we called e.g. So, the likes of this call: superset/superset/models/helpers.py Line 1381 in aae8fda Would change to read: Worth a try in the places it fails 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gave supporting
3.12a shot while deprecating3.9, made some progress but hit some blockers. Keeping this PR open to keep tabs on what's blocking at this time.pandas==2.0.3does not support py3.12, so bumped to latest, hit some issues, found some worrisome changes apparently inpandas>=2.2.0related to them no supportingdtypearg of typesqlalchemyindf.to_sql(), so reverter to the highest under 2.2, and seems there are issues there. Pandas folks not respecting semver it seems but given the API surface pandas have, gonna be have to evolve that lib without breaking a million things.Python wizards, help is very welcome to help get this through