Reintroduce achievement changes (using vanilla save compatibility system) #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 16, 2023
… with older save files" This reverts commit accc960.
This commit uses the vanilla CompatibleNumber system to fix the issues the achievement changes had with saves. Due to the new save file structure, CompatibleNumber had to be updated to 1.3.12. Since 1.3.11 saves are still supported, extra checks for 1.3.11 saves had to be added as well.
VersionNumber had to be changed to 1.3.12 sooner or later, and now that the CompatibleNumber is 1.3.12, I think this is a good time. VersionNumber is what appears in the app title and in the corner of the main menu.
…n of this new achievements was reverted in accc960, but these changes were accidentally left in). Regalis11#251" This reverts commit 75eee99.
ChronoQuote
force-pushed
the
Achievement-changes-(using-vanilla-save-compatibility-system)
branch
from
aaa1be1 to
d5460fb
Compare
ChronoQuote
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR acts as an alternative to #200, which also reintroduces the achievement changes but uses a new save compatibility system to resolve the issues they had with saves. In this branch, the issues are instead resolved with the vanilla CompatibleNumber system.
4d337e0 Revert "Reverted achievement changes because they break compatibility with older save files"
d5460fb Revert "Removed leftover bits of the SCP-066 achievement (the addition of this new achievements was reverted in accc960, but these changes were accidentally left in). #251"
These revert commits accc960 and 75eee99.
Summary of reintroduced changes:
DrawEndingto make "SCPs encountered" value on ending screen more accurate (since it is based on achievement order); now 990 is the only SCP missing from this value because it has no achievementNote that some pieces of these changes (like the update to
DrawEnding) were mistakenly never reverted in the first place and so were not actually reintroduced by this commit, but everything is still listed above anyway.Video showcasing some of these changes: https://streamable.com/5ypca8
7a464e2 Fix save compatibility with achievement changes
This commit uses the vanilla CompatibleNumber system to fix the issues the achievement changes had with saves.
Due to the new save file structure, CompatibleNumber had to be updated to 1.3.12. Since 1.3.11 saves are still supported, extra checks for 1.3.11 saves had to be added as well.
For an explanation of the CompatibleNumber system, see #200.
09dee89 Change version number to 1.3.12
VersionNumber had to be changed to 1.3.12 sooner or later, and now that the CompatibleNumber is 1.3.12, I think this is a good time.
VersionNumber is what appears in the app title and in the corner of the main menu.