Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remnants of removed SCP-066 achievement in dev branch #251

Closed
ChronoQuote opened this issue Sep 1, 2023 · 1 comment
Closed

Remnants of removed SCP-066 achievement in dev branch #251

ChronoQuote opened this issue Sep 1, 2023 · 1 comment

Comments

@ChronoQuote
Copy link

ChronoQuote commented Sep 1, 2023

When accc960 removed the new SCP-066 achievement from the dev branch, a couple pieces of it remained, including the achievement icon (GFX\menu\achievements\Achv066.jpg), and the code that triggers the achievement:

scpcb/NPCs.bb

Lines 3920 to 3923 in 6933225

If dist < 1.0+n\LastDist Then
GiveAchievement(Achv066)
n\State = Rand(2,3)
EndIf

Since Achv066 no longer exists, it'll have a default value of 0, which is the ID of the SCP-008 achievement. So currently, in the dev branch, approaching 066 will trigger 008's achievement.

This isn't a huge deal since you should already have 008's achievement by the time you can even meet 066, but it's an easy fix. Alternatively, one of either #200 or #258 could be merged.

Regalis11 added a commit that referenced this issue Sep 25, 2023
…s new achievements was reverted in accc960, but these changes were accidentally left in). #251
@Regalis11
Copy link
Owner

Addressed in 75eee99

ChronoQuote added a commit to Jabka666/scpcb that referenced this issue Sep 25, 2023
…n of this new achievements was reverted in accc960, but these changes were accidentally left in). Regalis11#251"

This reverts commit 75eee99.
ChronoQuote added a commit to Jabka666/scpcb that referenced this issue Sep 25, 2023
…n of this new achievements was reverted in accc960, but these changes were accidentally left in). Regalis11#251"

This reverts commit 75eee99.
Regalis11 added a commit that referenced this issue Sep 26, 2023
…n of this new achievements was reverted in accc960, but these changes were accidentally left in). #251"

This reverts commit 75eee99.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants