Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the value for the regular font weight for headings #143

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

marionnegp
Copy link
Contributor

This closes #142

Copy link

changeset-bot bot commented Oct 1, 2024

🦋 Changeset detected

Latest commit: 7e330a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rhds/tokens Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marionnegp marionnegp self-assigned this Oct 1, 2024
Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for red-hat-design-tokens ready!

Name Link
🔨 Latest commit 7e330a8
🔍 Latest deploy log https://app.netlify.com/sites/red-hat-design-tokens/deploys/67054f566d006d0008701750
😎 Deploy Preview https://deploy-preview-143--red-hat-design-tokens.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marionnegp marionnegp requested a review from markcaron October 1, 2024 20:18
Copy link
Collaborator

@coreyvickery coreyvickery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marionnegp There is still some text with 300 under the Font family heading on the tokens demo page. Might want to get rid of that and then I will approve.

Copy link
Contributor

@zeroedin zeroedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a patch changeset.

@marionnegp marionnegp requested a review from zeroedin October 7, 2024 16:11
@bennypowers bennypowers enabled auto-merge (squash) October 8, 2024 15:27
@bennypowers bennypowers dismissed zeroedin’s stale review October 8, 2024 15:29

Changeset added

@bennypowers bennypowers merged commit aea6a9f into main Oct 8, 2024
5 checks passed
@bennypowers bennypowers deleted the fix/heading-font-weight branch October 8, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Value change for --rh-font-weight-heading-regular
4 participants