Skip to content

Commit

Permalink
fix: change the value for the regular font weight for headings (#143)
Browse files Browse the repository at this point in the history
* fix: change the value for the regular font weight for headings

* fix: update URL to Noto Sans repo and remove 300 from Noto Sans embed code

* feat: add changeset
  • Loading branch information
marionnegp authored Oct 8, 2024
1 parent f4f68be commit aea6a9f
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .changeset/tasty-flowers-greet.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rhds/tokens": patch
---

Change the value for regular font weight token (`var(--rh-font-weight-heading-regular, 300)`) for headings from `300` to `400`
4 changes: 2 additions & 2 deletions tokens/font/family.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ font:
[Red Hat Fonts](https://github.com/RedHatOfficial/RedHatFont), designed by Jeremy Mickel
and released under Open Font License, form the typographic basis for the Red Hat Design
System. Pages using non-latin characters should fall back to
[Noto Sans](https://github.com/notofonts/noto-fonts). By loading language-specific Noto
[Noto Sans](https://notofonts.github.io/). By loading language-specific Noto
Sans fonts, <abbr title="Red Hat Design System">RHDS</abbr> can accomodate mixed-language
content including <span lang="ar">العربية</span>, <span lang="he">עברית</span>,
<span lang="jp">日本語</span>, <span lang="kr">조선말</span>, <span lang="ml">മലയാളം</span>,
Expand All @@ -20,7 +20,7 @@ font:
```html
<link rel="preconnect" href="https://fonts.googleapis.com">
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
<link href="https://fonts.googleapis.com/css2?family=Noto+Sans+Hebrew:wght@300;500;700&family=Noto+Sans+JP:wght@300;500;700&family=Noto+Sans+KR:wght@300;500;700&family=Noto+Sans+Malayalam:wght@300;500;700&family=Noto+Sans+SC:wght@300;500;700&family=Noto+Sans+TC:wght@300;500;700&family=Noto+Sans+Tamil:wght@300;500;700&family=Noto+Sans+Thai:wght@300;500;700&display=swap" rel="stylesheet">
<link href="https://fonts.googleapis.com/css2?family=Noto+Sans+Hebrew:wght@500;700&family=Noto+Sans+JP:wght@500;700&family=Noto+Sans+KR:wght@500;700&family=Noto+Sans+Malayalam:wght@500;700&family=Noto+Sans+SC:wght@500;700&family=Noto+Sans+TC:wght@500;700&family=Noto+Sans+Tamil:wght@500;700&family=Noto+Sans+Thai:wght@500;700&display=swap" rel="stylesheet">
```
heading:
Expand Down
2 changes: 1 addition & 1 deletion tokens/font/weight.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ font:
fontFamily: var(--rh-font-family-heading)
regular:
$description: Regular font weight for headings
$value: 300
$value: 400
attributes:
category: typography
medium:
Expand Down

0 comments on commit aea6a9f

Please sign in to comment.