Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update crayon colors with new brand colors #119

Merged
merged 11 commits into from
Dec 3, 2023
Merged

feat: update crayon colors with new brand colors #119

merged 11 commits into from
Dec 3, 2023

Conversation

marionnegp
Copy link
Contributor

@marionnegp marionnegp commented Nov 15, 2023 •
edited
Loading

This PR updates the crayon colors to the new brand colors and updates the semantic token values. No semantic token names were modified, removed, or added.

Notes for reviewers

To see tables that show old token names & values vs new token names and values, view the add-new-brand-colors.md changeset.

  • The new blue-40 is not always accessible against gray-70 because its contrast ratio is 3.68:1. @coreyvickery, your spreadsheet had used this for an interactive token and a border token. I changed both semantic tokens to use blue-30, which has a contrast ratio of 6.46:1. If you're good with this change, it'll have to be updated in Figma.
  • There aren't as many red crayon tokens in the new palette, so brand-red-darker and brand-red-darkest both use red-70.

@marionnegp marionnegp added this to the RHDS Tokens 2.0 milestone Nov 15, 2023
@marionnegp marionnegp self-assigned this Nov 15, 2023
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 162701c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rhds/tokens Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Nov 15, 2023 •
edited
Loading

✅ Deploy Preview for red-hat-design-tokens ready!

Name Link
🔨 Latest commit 162701c
🔍 Latest deploy log https://app.netlify.com/sites/red-hat-design-tokens/deploys/656c3ab0117b6e0008c9b2c0
😎 Deploy Preview https://deploy-preview-119--red-hat-design-tokens.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marionnegp marionnegp linked an issue Nov 15, 2023 that may be closed by this pull request
[task] Update new Brand colors in tokens #117
Closed
@marionnegp
Copy link
Contributor Author

@bennypowers, we talked about using old color tokens as fallbacks in RHDS for now. Do I need to retain any old token files here to make that happen?

@marionnegp marionnegp marked this pull request as ready for review November 16, 2023 19:33
bennypowers
bennypowers requested changes Nov 27, 2023
View reviewed changes
Copy link
Member

@bennypowers bennypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's possible, please add more $description fields, which are quite helpful for providing context to developers when selecting tokens in their editors
Screenshot 2023-11-27 at 17 16 33

@zeroedin zeroedin mentioned this pull request Nov 28, 2023
Closed
bennypowers
bennypowers requested changes Dec 3, 2023
View reviewed changes
Copy link
Member

@bennypowers bennypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few tweaks

.changeset/add-new-brand-colors.md Outdated Show resolved Hide resolved
.changeset/add-new-brand-colors.md Outdated Show resolved Hide resolved
bennypowers
bennypowers approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@bennypowers bennypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lemme getta token merge

@bennypowers bennypowers merged commit 41125df into main Dec 3, 2023
4 checks passed
@bennypowers bennypowers deleted the feat/add-only-new-crayon-colors branch December 3, 2023 08:23
marionnegp added a commit that referenced this pull request Feb 27, 2024
@marionnegp
Squashed commit of the following:
3589150 
commit f54e53e
Author: Marionne Patel <[email protected]>
Date:   Mon Feb 26 11:13:00 2024 -0500

    feat: update danger status tokens (#131)

    * feat: change value of --rh-color-status-danger-on-light

    * feat: add --rh-color-icon-status color tokens

    * fix: add `on-dark` for warning icon color

    * feat: add changeset

commit b64dd32
Author: Marionne Patel <[email protected]>
Date:   Mon Jan 15 09:31:06 2024 -0500

    feat: add status color tokens (#124)

    * feat: add status color tokens, fix a duplicated red orange value, change the max width of the copy button to show full token name, and change order of categories on Netlify page

    * feat: add descriptions

    * docs: add changeset

    * feat: group surface status colors with other surface tokens

    * fix: remove space

    * feat: change neutral status to default and note status to info

    * feat: remove caution status colors and add -status to border and surface status tokens

    * feat: update changeset

    ---------

    Co-authored-by: Benny Powers <[email protected]>

commit 9539e1d
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed Dec 13 10:59:13 2023 +0200

    chore: prepare release (#125)

    Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

commit 3c18e2c
Author: Benny Powers <[email protected]>
Date:   Wed Dec 13 10:18:26 2023 +0200

    fix: allow component token names

commit a5dfee5
Author: Marionne Patel <[email protected]>
Date:   Wed Dec 6 07:05:03 2023 -0500

    feat: create a new folder under assets to house breakpoint images (#120)

    Co-authored-by: Benny Powers - עם ישראל חי! <[email protected]>

commit b020c49
Author: Mark Caron <[email protected]>
Date:   Wed Dec 6 03:45:56 2023 -0500

    docs: update README.md (#122)

    Adding stylized alert/admonition for the NOTE

commit 4c64dfc
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Mon Dec 4 12:58:55 2023 -0500

    chore: prepare release (#115)

    Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

commit 9759846
Author: Benny Powers - עם ישראל חי! <[email protected]>
Date:   Mon Dec 4 16:59:42 2023 +0200

    docs: correct stylelint rule name (#121)

commit 41125df
Author: Marionne Patel <[email protected]>
Date:   Sun Dec 3 03:23:12 2023 -0500

    feat: update crayon colors with new brand colors (#119)

    * feat: update crayon colors with new brand colors

    * feat: update semantic token values with new crayon tokens

    * fix: fix typo in interactive tokens file, add code comments

    * feat: add changeset with crayon color updates

    * feat: add semantic token value changes to changeset

    * feat: update token names in stylelint README migration example

    * fix: remove empty keys

    * feat: replace crayon color tables with migration rules and list of tokens new to 2.0

    * feat: added use cases when applicable, fixed a blue migration rule, and updated a brand token values

    * docs: apply suggestions from code review

    * docs: update .changeset/add-new-brand-colors.md

    ---------

    Co-authored-by: Benny Powers - עם ישראל חי! <[email protected]>

commit c793fd8
Author: Benny Powers <[email protected]>
Date:   Thu Jun 8 19:14:14 2023 +0300

    feat(editor): make css var fallback values placeholders (#114)

    * feat(editor): make css var fallback values placeholders

    This lets users more easily choose between the fallback and non-fallback forms
    ```css
    padding: var(--rh-space-xs, 4px);
    margin: var(--rh-space-xs);
    ```

    * docs: add changeset

commit b059238
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Thu May 25 10:56:22 2023 -0400

    chore: prepare release (#112)

    Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

commit f820df6
Author: Steven Spriggs <[email protected]>
Date:   Thu May 25 10:54:24 2023 -0400

    fix: ensure cjs files are included in package (#111)

    * fix: ensure cjs files are included in package

    * chore: update changeset

    * chore: update changeset

commit fa73870
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed May 24 11:06:04 2023 -0400

    chore: prepare release (#109)

    Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

commit a777f24
Author: Michael Potter <[email protected]>
Date:   Wed May 24 11:03:58 2023 -0400

    fix: missing file exports (#108)

    * fix: made typescript compile a dep of style-dictionary

    * chore: added changeset

    * chore: changset

commit 1485cea
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue May 23 13:30:26 2023 -0400

    chore: prepare release (#105)

    Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

commit c80fea2
Author: Steven Spriggs <[email protected]>
Date:   Tue May 23 11:20:40 2023 -0400

    chore: missing script for types in release workflow (#104)

commit 0766863
Author: Steven Spriggs <[email protected]>
Date:   Thu May 18 13:21:25 2023 -0400

    feat: add meta data token export (#103)

    * feat: add meta data token export

    * chore: update comment

    * fix: export entire token object in meta entries

    * docs: update lib/formats/map.js

    * docs: update lib/formats/map.js

    ---------

    Co-authored-by: Benny Powers <[email protected]>

commit d35d8a2
Author: Ivana Rodriguez <[email protected]>
Date:   Mon Apr 24 09:33:30 2023 -0400

    fix: plugin filename should match release tag (#102)

    * fix: plugin filename should match release tag

    * fix: throw error if filename doesn't match

    * ci: break out package step and run after version bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreyvickery coreyvickery coreyvickery approved these changes

@bennypowers bennypowers bennypowers approved these changes

Assignees

@marionnegp marionnegp

Labels
None yet
Projects
Red Hat Design System
Status: Done ☑️
Red Hat Design System Roadmap
Status: Done ☑️
Milestone
RHDS Tokens 2.0
Development

Successfully merging this pull request may close these issues.

[task] Update new Brand colors in tokens
3 participants
@marionnegp @bennypowers @coreyvickery