Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] hex codes for color-context.css will change with tokens update #1363

Closed
zeroedin opened this issue Nov 28, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@zeroedin
Copy link
Collaborator

From @marionnegp on #1318 (comment)

FYI, the fallback hex code for rh-color-surface-darker will change to #292929 in the next tokens update.

@bennypowers follows up with #1318 (comment)

As long as we specify the mappings between old and new names, the linter should fix this automatically. Let's sync on this early this week Nov 6

Reference RedHat-UX/red-hat-design-tokens#119

@zeroedin zeroedin added the bug Something isn't working label Nov 28, 2023
@bennypowers
Copy link
Member

  1. after chore: prepare release red-hat-design-tokens#115 merges and we release @rhds/[email protected], we will need to
  2. update the dep here
  3. copy over the stylelint rules from the tokens 2 changeset
  4. run stylelint --fix here
  5. check for visual regressions

@github-project-automation github-project-automation bot moved this from Backlog to Done ☑️ in Red Hat Design System Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done ☑️
Development

No branches or pull requests

2 participants