-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closing procedure improvements, several fixes #334
Conversation
# Conflicts: # examples/CMakeLists.txt # examples/client_https_get.c # examples/tneat.c # neat_core.c
# Conflicts: # neat_resolver.c
To make this PR more reviewable and ready to merge, I would ask you to:
Ideally, you can detect subsets of this PR that can and should be made into its own separate PRs instead, to make it easier to review and makes it easier for future debugging and bisecting. |
I'm not familiar with squashing commits, many of my commits can't be linked to specific topic. |
Would it help if I use "squash and merge"? |
# Conflicts: # examples/client_http_get.c
Squashing == merging several related commits into one. Easiest done with I don't think it is acceptable for any project to push 93 commits with lacking commit messages and (virtually) no review, but I don't make the rules and I will accept whatever everyone thinks is suitable. (That's absolutely nothing personal against you nor your work, it's a question of what process we should use when merging code.) "squash and merge" is probably a bit too simple for you since it will merge all commits into one, which feels it might be a bit too exaggerated in the other direction. |
I totally agree with you that merging these changes without a review is not a good way but we discussed this and agreed on just merge the changes. |
This is a huge PR, sorry ... :)
Changes:
closing mechanism refactoring
If a peer closes the transport connection, this is now indicated by the
on_close
event and not by receiving no data when callingneat_read
.According to #316
callback handling
The callback handling has been improved in many aspects.
For example
on_all_written
is called every time aneat_write
call has successfully delivered data to the transport layer and the flow buffer is drained.See #272
improved memory management
The library should now handle memory a lot better, valgrind is much happier now. :)
misc changes