Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of TLS support? #297

Closed
dreibh opened this issue Mar 20, 2017 · 2 comments
Closed

Status of TLS support? #297

dreibh opened this issue Mar 20, 2017 · 2 comments

Comments

@dreibh
Copy link
Contributor

dreibh commented Mar 20, 2017

How is the status of TLS support in NEAT? As far as I can see, the only server example supposed to support TLS is server_echo.c. However, a call of
"server_echo -P NEAT_PROPERTY_REQUIRED_SECURITY,NEAT_PROPERTY_TCP_REQUIRED,NEAT_PROPERTY_IPV4_REQUIRED -v 2 -p cert.pem"
results in:
Unable to read properties from NEAT_PROPERTY_REQUIRED_SECURITY,NEAT_PROPERTY_TCP_REQUIRED,NEAT_PROPERTY_IPV4_REQUIRED.
(I assume the properties format has changed, and the instruction how to use server_echo is out of date)?

Using JSON properties also does not turn on security. It seems that neat_security_install() is never called.

The code in do_accept() seems to be broken:
if ((false) &&
(newFlow->socket->stack == NEAT_STACK_TCP)) {
neat_log(ctx, NEAT_LOG_DEBUG, "TCP Server Security");
if (neat_security_install(newFlow->ctx, newFlow) != NEAT_OK) {

"(false) && something" is never true.

@Cylra
Copy link

Cylra commented Jun 19, 2017

Is there any news on TLS support in NEAT? Do you have a working example for the server side?

@weinrank
Copy link
Member

Fixes by #334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants