Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ensmallen & embiggen from requirements #26

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Remove ensmallen & embiggen from requirements #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5e51d0f
update ensmallen, allow future updates
kevinschaper Dec 13, 2022
f35f15c
Remove explicit ensmallen & embiggen requirements, plus a bit of misc…
kevinschaper Jan 26, 2023
6b919be
Trying a slightly different pin for ensmallen
caufieldjh Jan 26, 2023
81faaa6
Update poetry.lock
caufieldjh Jan 26, 2023
5289835
Getting closer to a working set
caufieldjh Jan 26, 2023
cfc9c0e
Update TestGrapeImplementation
caufieldjh Jan 26, 2023
f1019a9
Update poetry lock
caufieldjh Feb 10, 2023
b9ad31f
Workaround - install Ensmallen via pip
caufieldjh Feb 10, 2023
c3c235c
Need to install through pip via poetry
caufieldjh Feb 10, 2023
f881409
Address that sklearn issue
caufieldjh Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/qc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,10 @@ jobs:

- name: Install Poetry
uses: snok/install-poetry@v1
- name: TEMPORARY WORKAROUND - Install Ensmallen
run: poetry run pip install ensmallen
- name: Install dependencies
run: poetry install --no-interaction
run: export POETRY_SKLEARN_ALLOW_DEPRECATED_SKLEARN_PACKAGE_INSTALL=True && poetry install --no-interaction

- name: Check code quality with flake8
run: poetry run tox -e flake8
Expand Down
Loading