Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ensmallen & embiggen from requirements #26

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

kevinschaper
Copy link

This pulls the specific requirements off, and lets them come in via grape.

I initially started by updating embiggen and ensmallen, so there's some lock file updates that might be unnecessary, but hopefully not a problem.

@caufieldjh
Copy link
Contributor

Should resolve downstream dependency incompatibility, e.g. monarch-initiative/monarch-app#43

@caufieldjh
Copy link
Contributor

Ah, right, that's why ensmallen was explicitly included:

  • Installing ensmallen (0.8.36)

  RuntimeError

  Unable to find installation candidates for ensmallen (0.8.36)

  at ~/.local/venv/lib/python3.9/site-packages/poetry/installation/chooser.py:105 in choose_for
      101│ 
      102│             links.append(link)
      103│ 
      104│         if not links:
    → 105│             raise RuntimeError(f"Unable to find installation candidates for {package}")
      106│ 
      107│         # Get the best link
      108│         chosen = max(links, key=lambda link: self._sort_key(package, link))
      109│ 

pyproject.toml Outdated
@@ -15,6 +15,7 @@ importlib = "^1.0.4"
scipy = "^1.9.0"
oaklib = "^0.1.43"
grape = "*"
ensmallen = "0.8.35"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@caufieldjh
Copy link
Contributor

Need to rebuild the poetry.lock to make this work - and for some reason that has taken >90 min and counting

@caufieldjh
Copy link
Contributor

Ensmallen 0.8.35 has this issue: AnacletoLAB/ensmallen#192

@caufieldjh
Copy link
Contributor

This works if ensmallen=0.8.36 is installed with pip, but not with poetry.

Even then, one of the tests fails:

_______________________________________________________________________________________ TestGrapeImplementation.test_all_by_all_pairwise_similarity ________________________________________________________________________________________

self = <tests.test_grape_implementation.TestGrapeImplementation testMethod=test_all_by_all_pairwise_similarity>

    def test_all_by_all_pairwise_similarity(self):
        """Verify that all by all pairwise similarity returns expected results."""
        oi = get_implementation_from_shorthand("grape:sqlite:obo:bfo")
        entities = list(oi.entities())
        tps = oi.all_by_all_pairwise_similarity(entities, entities)
>       self.assertEqual(540, len(list(tps)))
E       AssertionError: 540 != 237

tests/test_grape_implementation.py:96: AssertionError

@caufieldjh
Copy link
Contributor

caufieldjh commented Feb 10, 2023

Now there seems to be some kind of dependency parsing issue - I suspect the mixture of installing packages through pip and through poetry is leading to some incongruency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants