-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ensmallen & embiggen from requirements #26
base: main
Are you sure you want to change the base?
Conversation
Should resolve downstream dependency incompatibility, e.g. monarch-initiative/monarch-app#43 |
Ah, right, that's why ensmallen was explicitly included:
|
pyproject.toml
Outdated
@@ -15,6 +15,7 @@ importlib = "^1.0.4" | |||
scipy = "^1.9.0" | |||
oaklib = "^0.1.43" | |||
grape = "*" | |||
ensmallen = "0.8.35" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Need to rebuild the poetry.lock to make this work - and for some reason that has taken >90 min and counting |
Ensmallen 0.8.35 has this issue: AnacletoLAB/ensmallen#192 |
This works if Even then, one of the tests fails:
|
Now there seems to be some kind of dependency parsing issue - I suspect the mixture of installing packages through pip and through poetry is leading to some incongruency |
This pulls the specific requirements off, and lets them come in via grape.
I initially started by updating embiggen and ensmallen, so there's some lock file updates that might be unnecessary, but hopefully not a problem.