fix: inconsistency in quoted message and regular message white space… #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +52 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2601 +/- ##
==========================================
+ Coverage 81.12% 81.14% +0.02%
==========================================
Files 448 448
Lines 9464 9464
Branches 2312 2312
==========================================
+ Hits 7678 7680 +2
+ Misses 1423 1421 -2
Partials 363 363 ☔ View full report in Codecov by Sentry. |
szuperaz
force-pushed
the
quouted-message-incosistencies
branch
2 times, most recently
from
4a90078 to
f9159c1
Compare
szuperaz
force-pushed
the
quouted-message-incosistencies
branch
from
f9159c1 to
5c30405
Compare
szuperaz
added a commit
to GetStream/stream-chat-css
that referenced
this pull request
Jan 15, 2025
…ges (#322) ### 🎯 Goal - White spaces were treated differently in quoted messages - Adds clamping to quoted message See screenshot for details Merge this if you want the fix for React as well: GetStream/stream-chat-react#2601 ### 🛠 Implementation details _Provide a description of the implementation_ ### 🎨 UI Changes **White space incosistencies** If we quoted a message with line-breaks before...  ...the line breaks were not properly preserved in the quote preview:  **Clamping** Without message clamping quoted messages can take up a lot of space:  With message clamping: 
arnautov-anton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
🎯 Goal
Details: GetStream/stream-chat-css#322
Draft because we have to update stream-chat-css before merging!!!!
🛠 Implementation details
Provide a description of the implementation
🎨 UI Changes
Add relevant screenshots