Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: white space inconsistency in quoted messages, clamp quoted messages #322

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

szuperaz
Copy link
Collaborator

@szuperaz szuperaz commented Jan 14, 2025

🎯 Goal

  • White spaces were treated differently in quoted messages
  • Adds clamping to quoted message

See screenshot for details

Merge this if you want the fix for React as well: GetStream/stream-chat-react#2601

🛠 Implementation details

Provide a description of the implementation

🎨 UI Changes

White space incosistencies

If we quoted a message with line-breaks before...

Screenshot 2025-01-14 at 14 18 45

...the line breaks were not properly preserved in the quote preview:

Screenshot 2025-01-14 at 14 18 50

Clamping

Without message clamping quoted messages can take up a lot of space:

Screenshot 2025-01-14 at 14 12 04

With message clamping:

Screenshot 2025-01-14 at 14 12 11

@szuperaz szuperaz force-pushed the quoted-message-fixes branch from 0d4b933 to e68a7c0 Compare January 15, 2025 10:47
@szuperaz szuperaz merged commit 19fdb4f into main Jan 15, 2025
1 check passed
@szuperaz szuperaz deleted the quoted-message-fixes branch January 15, 2025 12:14
github-actions bot pushed a commit that referenced this pull request Jan 15, 2025
## [5.6.1](v5.6.0...v5.6.1) (2025-01-15)

### Bug Fixes

* white space inconsistency in quoted messages, clamp quoted messages ([#322](#322)) ([19fdb4f](19fdb4f))
Copy link

🎉 This PR is included in version 5.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants