Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of ^ calls #124

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Reduce number of ^ calls #124

merged 2 commits into from
Aug 9, 2022

Conversation

charleskawczynski
Copy link
Member

This PR

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #124 (0bbe8f0) into main (e6eaddc) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   93.83%   93.99%   +0.16%     
==========================================
  Files           8        8              
  Lines         989     1016      +27     
==========================================
+ Hits          928      955      +27     
  Misses         61       61              
Impacted Files Coverage Δ
src/relations.jl 97.01% <100.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@charleskawczynski
Copy link
Member Author

Nice!

main

┌───────────────────────────┬──────────┬──────────┬────────────┬────────────┬────────────┬────────────┬───────────┐
│ Constructor               │   Memory │   allocs │       Time │       Time │       Time │       Time │ N-samples │
│ (+conditions)             │ estimate │ estimate │        min │        max │       mean │     median │           │
├───────────────────────────┼──────────┼──────────┼────────────┼────────────┼────────────┼────────────┼───────────┤
│ PhaseEquil_ρeq_dry        │  0 bytes │        0 │ 336.667 ns │   5.456 μs │ 344.022 ns │ 337.662 ns │     10000 │
│ PhaseEquil_ρeq_sat_adjust │  0 bytes │        0 │   2.151 μs │   7.897 μs │   2.189 μs │   2.156 μs │     10000 │
│ PhaseEquil_ρTq_dry        │  0 bytes │        0 │ 178.780 ns │   6.479 μs │ 184.243 ns │ 179.137 ns │     10000 │
│ PhaseEquil_ρTq_moist      │  0 bytes │        0 │ 178.983 ns │   1.812 μs │ 183.409 ns │ 179.622 ns │     10000 │
│ PhaseEquil_pTq_dry        │  0 bytes │        0 │ 183.358 ns │ 389.942 ns │ 187.228 ns │ 183.732 ns │     10000 │
│ PhaseEquil_pTq_moist      │  0 bytes │        0 │ 183.613 ns │   2.318 μs │ 187.827 ns │ 184.116 ns │     10000 │
│ PhaseEquil_peq_dry        │  0 bytes │        0 │ 344.014 ns │   1.614 μs │ 352.050 ns │ 345.035 ns │     10000 │
│ PhaseEquil_peq_sat_adjust │  0 bytes │        0 │   6.666 μs │  27.488 μs │   6.822 μs │   6.691 μs │     10000 │
│ PhaseEquil_phq_dry        │  0 bytes │        0 │ 350.967 ns │ 895.444 ns │ 359.060 ns │ 351.752 ns │     10000 │
│ PhaseEquil_phq_sat_adjust │  0 bytes │        0 │   5.636 μs │  13.465 μs │   5.759 μs │   5.654 μs │     10000 │
│ PhaseEquil_ρθq_dry        │  0 bytes │        0 │ 478.755 ns │   1.038 μs │ 488.521 ns │ 479.827 ns │     10000 │
│ PhaseEquil_ρθq_sat_adjust │  0 bytes │        0 │  10.448 μs │  47.090 μs │  10.712 μs │  10.505 μs │     10000 │
│ PhaseEquil_pθq_dry        │  0 bytes │        0 │ 475.694 ns │   1.292 μs │ 486.518 ns │ 477.714 ns │     10000 │
│ PhaseEquil_pθq_sat_adjust │  0 bytes │        0 │   2.644 μs │  12.485 μs │   2.710 μs │   2.650 μs │     10000 │
│ PhaseEquil_ρpq_dry        │  0 bytes │        0 │  19.732 ns │  53.938 ns │  20.225 ns │  19.739 ns │     10000 │
│ PhaseEquil_ρpq_sat_adjust │  0 bytes │        0 │  19.732 ns │  57.776 ns │  20.246 ns │  19.818 ns │     10000 │
└───────────────────────────┴──────────┴──────────┴────────────┴────────────┴────────────┴────────────┴───────────┘

This PR:

┌───────────────────────────┬──────────┬──────────┬────────────┬────────────┬────────────┬────────────┬───────────┐
│ Constructor               │   Memory │   allocs │       Time │       Time │       Time │       Time │ N-samples │
│ (+conditions)             │ estimate │ estimate │        min │        max │       mean │     median │           │
├───────────────────────────┼──────────┼──────────┼────────────┼────────────┼────────────┼────────────┼───────────┤
│ PhaseEquil_ρeq_dry        │  0 bytes │        0 │ 292.613 ns │ 496.395 ns │ 294.290 ns │ 293.066 ns │     10000 │
│ PhaseEquil_ρeq_sat_adjust │  0 bytes │        0 │   1.526 μs │   4.261 μs │   1.538 μs │   1.531 μs │     10000 │
│ PhaseEquil_ρTq_dry        │  0 bytes │        0 │ 157.129 ns │   2.084 μs │ 158.295 ns │ 157.455 ns │     10000 │
│ PhaseEquil_ρTq_moist      │  0 bytes │        0 │ 156.839 ns │   1.811 μs │ 158.472 ns │ 157.468 ns │     10000 │
│ PhaseEquil_pTq_dry        │  0 bytes │        0 │ 164.093 ns │ 430.825 ns │ 165.161 ns │ 164.490 ns │     10000 │
│ PhaseEquil_pTq_moist      │  0 bytes │        0 │ 163.736 ns │ 254.385 ns │ 165.017 ns │ 164.334 ns │     10000 │
│ PhaseEquil_peq_dry        │  0 bytes │        0 │ 301.482 ns │ 461.502 ns │ 303.139 ns │ 301.827 ns │     10000 │
│ PhaseEquil_peq_sat_adjust │  0 bytes │        0 │   6.048 μs │  16.603 μs │   6.085 μs │   6.063 μs │     10000 │
│ PhaseEquil_phq_dry        │  0 bytes │        0 │ 303.761 ns │ 429.052 ns │ 305.639 ns │ 304.398 ns │     10000 │
│ PhaseEquil_phq_sat_adjust │  0 bytes │        0 │   5.062 μs │   9.338 μs │   5.092 μs │   5.071 μs │     10000 │
│ PhaseEquil_ρθq_dry        │  0 bytes │        0 │ 408.320 ns │ 524.720 ns │ 410.831 ns │ 409.250 ns │     10000 │
│ PhaseEquil_ρθq_sat_adjust │  0 bytes │        0 │   8.998 μs │  19.501 μs │   9.049 μs │   9.012 μs │     10000 │
│ PhaseEquil_pθq_dry        │  0 bytes │        0 │ 411.060 ns │ 558.365 ns │ 413.004 ns │ 411.530 ns │     10000 │
│ PhaseEquil_pθq_sat_adjust │  0 bytes │        0 │   2.247 μs │   3.335 μs │   2.262 μs │   2.252 μs │     10000 │
│ PhaseEquil_ρpq_dry        │  0 bytes │        0 │  17.352 ns │  43.504 ns │  17.625 ns │  17.648 ns │     10000 │
│ PhaseEquil_ρpq_sat_adjust │  0 bytes │        0 │  17.355 ns │  24.760 ns │  17.616 ns │  17.652 ns │     10000 │
└───────────────────────────┴──────────┴──────────┴────────────┴────────────┴────────────┴────────────┴───────────┘

@charleskawczynski
Copy link
Member Author

bors r+

@bors bors bot merged commit a8aa614 into main Aug 9, 2022
@bors bors bot deleted the ck/performance branch August 9, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant