Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report CHERI exceptions in xTVAL #40

Merged

Conversation

arichardson
Copy link
Member

The matches the latest ISA spec and QEMU

The matches the latest ISA spec and QEMU
@PeterRugg
Copy link
Contributor

Hmm, does this duplicate the info between xccsr and xtval? I would expect we would remove the reporting from xccsr alongside adding it to xtval?

@arichardson
Copy link
Member Author

We currently still have both in the ISA spec, but I agree it's redundant.

@nwf
Copy link
Member

nwf commented Nov 16, 2020

Can we get rid of the xccsr bits from the spec? Having to update just one CSR on exception is, I think, more "the RISC-V way" and would simplify the work I need to do for #18. ;)

@arichardson
Copy link
Member Author

Can we get rid of the xccsr bits from the spec? Having to update just one CSR on exception is, I think, more "the RISC-V way" and would simplify the work I need to do for #18. ;)

Yes that would be great. I found a bug in qemu that I won't have to fix if we do that :)

@bsdjhb
Copy link
Contributor

bsdjhb commented Nov 16, 2020

I would be happy if we removed the xccsr bits. I had deprecated them in ISAv8 to give us time to make the transition in all our implementations. I suspect our P1 and CheriFreeRTOS still use xccsr?

@jrtc27
Copy link
Member

jrtc27 commented Nov 17, 2020

I would be happy if we removed the xccsr bits. I had deprecated them in ISAv8 to give us time to make the transition in all our implementations. I suspect our P1 and CheriFreeRTOS still use xccsr?

It seems Piccolo hasn't pulled that change in even in the source (yay don't you love code copies). CheriFreeRTOS only looks at the CHERI cause if you use the simple sandbox mechanism so yes it will break but nothing actually uses that other than the old secure ballot box system.

@arichardson
Copy link
Member Author

@jrtc27 Is this okay to merge now? I'll open a separate PR for the xccsr changes.

@arichardson arichardson merged commit afad306 into CTSRD-CHERI:master Nov 18, 2020
@arichardson arichardson deleted the report-cheri-exc-in-tval branch November 18, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants