Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches, Kristy #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 50 additions & 18 deletions lib/linked_list.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,39 +7,71 @@ def initialize
@head = nil
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(1)
# Space complexity - O(1)
def add_first(data)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


@head = Node.new(data, @head)
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(1)
# Space complexity - O(1)
def get_first

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


return nil if head.nil?
return @head.data if !head.nil?
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n)
# Space complexity - O(n)
def length

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 However your space complexity is wrong. It's O(1). The list doesn't change in size.

return 0
if @head.nil?
return 0
end
current = @head
length = 1
until current.next.nil?
length += 1
current = current.next
end
return length
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n)
# Space complexity - O(n)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does the space complexity grow compared to the size of the list?

def add_last(data)

if @head.nil?
@head = Node.new(data)
else
last = self.find_last
last.next = Node.new(data)
end

end

# Time complexity - ?
# Space complexity - ?
def get_last
def find_last
current = @head

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if head is nil?

Suggested change
current = @head
return nil if head.nil?
current = head

until current.next.nil?
current = current.next
end
return current
end

# Time complexity - O(n)
# Space complexity - O(n)
def get_last

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

return self.find_last.data
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n)
# Space complexity - O(n)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is the space complexity O(n), do you add n elements onto the list?

def get_at_index(index)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about if the index is greater than the length of the list?


current = @head
index.times do
if current.nil? || current.next.nil?
return nil
else
current = current.next
end
end
return current.data
end
end
8 changes: 4 additions & 4 deletions test/linked_list_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
end
end

xdescribe 'add_first & get_first' do
describe 'add_first & get_first' do
it 'can add values to an empty list' do
# Act
@list.add_first(3)
Expand Down Expand Up @@ -51,7 +51,7 @@
end
end

xdescribe "length" do
describe "length" do
it "will return 0 for an empty list" do
expect(@list.length).must_equal 0
end
Expand All @@ -66,7 +66,7 @@
end
end

xdescribe "addLast & getLast" do
describe "addLast & getLast" do
it "will add to the front if the list is empty" do
@list.add_last(1)
expect(@list.get_first).must_equal 1
Expand All @@ -91,7 +91,7 @@

end

xdescribe 'get_at_index' do
describe 'get_at_index' do
it 'returns nil if the index is outside the bounds of the list' do
expect(@list.get_at_index(3)).must_be_nil
end
Expand Down