Branches, Kristy #37
Open
Branches, Kristy #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Dec 18, 2019
| # Time complexity - ? | ||
| # Space complexity - ? | ||
| # Time complexity - O(n) | ||
| # Space complexity - O(n) |
There was a problem hiding this comment.
How is the space complexity O(n), do you add n elements onto the list?
| # Time complexity - ? | ||
| # Space complexity - ? | ||
| # Time complexity - O(n) | ||
| # Space complexity - O(n) | ||
| def get_at_index(index) |
There was a problem hiding this comment.
What about if the index is greater than the length of the list?
| # Space complexity - ? | ||
| def get_last | ||
| def find_last | ||
| current = @head |
There was a problem hiding this comment.
What if head is nil?
Suggested change
| current = @head | |
| return nil if head.nil? | |
| current = head |
|
|
||
| # Time complexity - O(n) | ||
| # Space complexity - O(n) | ||
| def get_last |
| # Time complexity - ? | ||
| # Space complexity - ? | ||
| # Time complexity - O(n) | ||
| # Space complexity - O(n) |
There was a problem hiding this comment.
How does the space complexity grow compared to the size of the list?
| # Time complexity - ? | ||
| # Space complexity - ? | ||
| # Time complexity - O(n) | ||
| # Space complexity - O(n) | ||
| def length |
There was a problem hiding this comment.
👍 However your space complexity is wrong. It's O(1). The list doesn't change in size.
| # Time complexity - ? | ||
| # Space complexity - ? | ||
| # Time complexity - O(1) | ||
| # Space complexity - O(1) | ||
| def get_first |
| # Time complexity - ? | ||
| # Space complexity - ? | ||
| # Time complexity - O(1) | ||
| # Space complexity - O(1) | ||
| def add_first(data) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked List Comprehension Questions